[webkit-changes] [WebKit/WebKit] 1a99dd: Set value of m_textAsOfLastFormControlChangeEvent ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a99dd74ee9b62f22ec9030d7d89535c9affc209
      https://github.com/WebKit/WebKit/commit/1a99dd74ee9b62f22ec9030d7d89535c9affc209
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    A LayoutTests/fast/events/onchange-js-expected.txt
    A LayoutTests/fast/events/onchange-js.html
    M Source/WebCore/html/HTMLTextFormControlElement.cpp

  Log Message:
  -----------
  Set value of m_textAsOfLastFormControlChangeEvent before triggering change event

Set value of m_textAsOfLastFormControlChangeEvent before triggering change event
https://bugs.webkit.org/show_bug.cgi?id=250025

Reviewed by Chris Dumez.

This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.

Merge - https://src.chromium.org/viewvc/blink?revision=175565&view=revision

The value is updated inside change event, which gets overwritten by setTextAsOfLastFormControlChangeEvent. This patch ensure that new value if similar to previous value trigger change event.

* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(HTMLTextFormControl::dispatchFormControlChangeEvent): Move "dispatchChangeEvent" after setting the value
* LayoutTests/fast/events/onchange-js.html: Add Test Case
* LayoutTests/fast/events/onchange-js-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/258395@main