[webkit-changes] [WebKit/WebKit] d741aa: Fix assert when parsing invalid CSS selector

Matthieu Dubet noreply at github.com
Tue Jan 3 10:41:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d741aacc0a0d44b5041b5aa90fccc48417422b72
      https://github.com/WebKit/WebKit/commit/d741aacc0a0d44b5041b5aa90fccc48417422b72
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    M Source/WebCore/css/parser/CSSSelectorParser.cpp

  Log Message:
  -----------
  Fix assert when parsing invalid CSS selector
https://bugs.webkit.org/show_bug.cgi?id=249994
rdar://103809119

Reviewed by Tim Nguyen.

When a CSS selector is invalid, we should just abort
its parsing (instead of asserting that it's correct).

Some tests are crashing because of this (since 258355 at main):
fast/css/font_property_normal.html
fast/css/parsing-invalid-block-recovery.html

* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeRelativeNestedSelector):

Canonical link: https://commits.webkit.org/258392@main




More information about the webkit-changes mailing list