[webkit-changes] [WebKit/WebKit] aee01b: [ITP] User initiated cross-domain link navigations...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aee01bb955fb9818f0fbb802cd5b5392773a33a4
      https://github.com/WebKit/WebKit/commit/aee01bb955fb9818f0fbb802cd5b5392773a33a4
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-01-02 (Mon, 02 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [ITP] User initiated cross-domain link navigations getting counted as Top Frame Redirects
https://bugs.webkit.org/show_bug.cgi?id=223405
rdar://75552559

Reviewed by Wenson Hsieh and David Kilzer.

This patch fixes a use-after-move on `userInitiatedActivity`.
The variable `wasPotentiallyInitiatedByUser` uses the RefPtr
`userInitiatedActivity` to determine if a navigation was user
initiated. Since it has already been moved, the RefPtr will
always be null. This causes an issue where ITP may incorrectly
treat a user-initiated navigation as a main frame redirect.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/258382@main