From noreply at github.com Sun Jan 1 10:20:45 2023 From: noreply at github.com (Alan Baradlay) Date: Sun, 01 Jan 2023 10:20:45 -0800 Subject: [webkit-changes] [WebKit/WebKit] 992e7f: [IFC][list marker] Adjust nested list markers when... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 992e7fe2b7fb32ade4727d19f8511a90e60da8ff https://github.com/WebKit/WebKit/commit/992e7fe2b7fb32ade4727d19f8511a90e60da8ff Author: Alan Baradlay Date: 2023-01-01 (Sun, 01 Jan 2023) Changed paths: A LayoutTests/fast/lists/overlapping-nested-list-markers-expected.html A LayoutTests/fast/lists/overlapping-nested-list-markers.html M LayoutTests/platform/ios/css1/box_properties/padding_right-expected.txt M LayoutTests/platform/ios/fast/lists/002-expected.txt M LayoutTests/platform/ios/fast/lists/002-vertical-expected.txt M LayoutTests/platform/mac/css1/box_properties/margin_right-expected.txt M LayoutTests/platform/mac/css1/box_properties/padding_right-expected.txt M LayoutTests/platform/mac/fast/lists/002-expected.txt M LayoutTests/platform/mac/fast/lists/002-vertical-expected.txt M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp Log Message: ----------- [IFC][list marker] Adjust nested list markers when intrusive float is present https://bugs.webkit.org/show_bug.cgi?id=249975 Reviewed by Antti Koivisto. The following html markup

- overlapping nested list markers

produces 2 list markers. These markers are placed on the same line. * * overlapping nested list markers. However in quirks mode:

- non-overlapping nested list markers

each list maker is on a dedicated line. * * non-overlapping nested list markers This is controlled by negative margin start on the list marker box. These list marker positions are affected by any overlapping floats, even when the float is not intrusive to the line itself. This patch makes sure the we take floats into account when computing the final position of such list items. LineLayout::updateListMarkerDimensions: Cache the list marker's offset from the associated list item. In case of nested list markers (when multiple markers share the same line), the containing block is not necessarily the associated

. This offset is later may be adjusted by taking overlapping floats into account. LineBoxBuilder::adjustOutsideListMarkersPosition: In this function we compute the final position of the list markers and also make that nested list markers do avoid float boxes. * LayoutTests/fast/lists/overlapping-nested-list-markers-expected.html: Added. * LayoutTests/fast/lists/overlapping-nested-list-markers.html: Added. * Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h: (WebCore::Layout::BlockLayoutState::floatingState const): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::createDisplayContentForLine): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp: (WebCore::Layout::InlineFormattingGeometry::adjustMarginStartForListMarker const): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h: * Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h: (WebCore::Layout::InlineFormattingState::addNestedListMarkerOffset): (WebCore::Layout::InlineFormattingState::nestedListMarkerOffset const): (WebCore::Layout::InlineFormattingState::resetNestedListMarkerOffsets): * Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h: (WebCore::Layout::InlineLevelBox::setLogicalLeft): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::LineBoxBuilder): (WebCore::Layout::LineBoxBuilder::build): (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): (WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const): (WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h: (WebCore::Layout::LineBoxBuilder::blockLayoutState const): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateListMarkerDimensions): (WebCore::LayoutIntegration::LineLayout::constructContent): Canonical link: https://commits.webkit.org/258372 at main From noreply at github.com Sun Jan 1 11:25:24 2023 From: noreply at github.com (Antti Koivisto) Date: Sun, 01 Jan 2023 11:25:24 -0800 Subject: [webkit-changes] [WebKit/WebKit] 6dabb8: [@property] Fallback that does not match syntax sh... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dabb8f934a3f64c639eb12d8c24ddea1c16101e https://github.com/WebKit/WebKit/commit/6dabb8f934a3f64c639eb12d8c24ddea1c16101e Author: Antti Koivisto Date: 2023-01-01 (Sun, 01 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt M Source/WebCore/css/CSSVariableReferenceValue.cpp M Source/WebCore/css/CSSVariableReferenceValue.h M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.h Log Message: ----------- [@property] Fallback that does not match syntax should make var() invalid https://bugs.webkit.org/show_bug.cgi?id=249981 rdar://103799338 Reviewed by Sam Weinig. The fallback value must match the syntax definition of the custom property being referenced, otherwise the declaration is invalid at computed-value time. https://drafts.css-houdini.org/css-properties-values-api/#fallbacks-in-var-references * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt: * Source/WebCore/css/CSSVariableReferenceValue.cpp: (WebCore::CSSVariableReferenceValue::resolveVariableFallback const): Check the syntax of the fallback. (WebCore::CSSVariableReferenceValue::resolveVariableReference const): (WebCore::CSSVariableReferenceValue::resolveTokenRange const): (WebCore::CSSVariableReferenceValue::resolveVariableReferences const): (WebCore::CSSVariableReferenceValue::resolveVariableFallback): Deleted. (WebCore::CSSVariableReferenceValue::resolveVariableReference): Deleted. (WebCore::CSSVariableReferenceValue::resolveTokenRange): Deleted. Make these non-static (so parser context is available) and did some return value cleanup. * Source/WebCore/css/CSSVariableReferenceValue.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::isValidCustomPropertyValueForSyntax): * Source/WebCore/css/parser/CSSPropertyParser.h: Canonical link: https://commits.webkit.org/258373 at main From noreply at github.com Sun Jan 1 19:02:51 2023 From: noreply at github.com (Alan Baradlay) Date: Sun, 01 Jan 2023 19:02:51 -0800 Subject: [webkit-changes] [WebKit/WebKit] 10f255: [IFC] Enable nested list items with intrusive floats Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10f255c1ee3f5eb0d15cedfd34405ef1f1b99314 https://github.com/WebKit/WebKit/commit/10f255c1ee3f5eb0d15cedfd34405ef1f1b99314 Author: Alan Baradlay Date: 2023-01-01 (Sun, 01 Jan 2023) Changed paths: M LayoutTests/platform/ios/fast/lists/001-vertical-expected.txt M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h Log Message: ----------- [IFC] Enable nested list items with intrusive floats https://bugs.webkit.org/show_bug.cgi?id=249977 Reviewed by Antti Koivisto. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::printReason): (WebCore::LayoutIntegration::canUseForChild): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: Canonical link: https://commits.webkit.org/258374 at main From noreply at github.com Sun Jan 1 20:47:30 2023 From: noreply at github.com (Yusuke Suzuki) Date: Sun, 01 Jan 2023 20:47:30 -0800 Subject: [webkit-changes] [WebKit/WebKit] 11eab4: [JSC] Store JSWebAssemblyInstance in WasmToJS stub... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11eab47bbd63261ddae6477bb34cafd50ae76703 https://github.com/WebKit/WebKit/commit/11eab47bbd63261ddae6477bb34cafd50ae76703 Author: Yusuke Suzuki Date: 2023-01-01 (Sun, 01 Jan 2023) Changed paths: M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/interpreter/CallFrame.cpp M Source/JavaScriptCore/interpreter/StackVisitor.cpp M Source/JavaScriptCore/runtime/JSCast.h M Source/JavaScriptCore/runtime/JSCellInlines.h M Source/JavaScriptCore/runtime/JSType.cpp M Source/JavaScriptCore/runtime/JSType.h M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h M Source/JavaScriptCore/wasm/js/WasmToJS.cpp M Source/JavaScriptCore/wasm/js/WasmToJS.h Log Message: ----------- [JSC] Store JSWebAssemblyInstance in WasmToJS stub instead of JSWebAssemblyModule https://bugs.webkit.org/show_bug.cgi?id=249969 rdar://103789934 Reviewed by Mark Lam. Simplify code generation by storing JSWebAssemblyInstance instead of JSWebAssemblyModule. We also clean up OptimizingCallLinkInfo allocation for WasmToJS stubs. * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::webAssemblyOwner): * Source/JavaScriptCore/interpreter/CallFrame.cpp: (JSC::CallFrame::isAnyWasmCallee const): * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding): * Source/JavaScriptCore/runtime/JSCast.h: * Source/JavaScriptCore/runtime/JSCellInlines.h: (JSC::isWebAssemblyInstance): (JSC::isWebAssemblyModule): Deleted. * Source/JavaScriptCore/runtime/JSType.cpp: (WTF::printInternal): * Source/JavaScriptCore/runtime/JSType.h: * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp: (JSC::JSWebAssemblyInstance::createStructure): * Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp: (JSC::JSWebAssemblyModule::clearJSCallICs): (JSC::JSWebAssemblyModule::finalizeUnconditionally): (JSC::JSWebAssemblyModule::generateWasmToJSStubs): * Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h: * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::handleBadImportTypeUse): (JSC::Wasm::wasmToJS): * Source/JavaScriptCore/wasm/js/WasmToJS.h: Canonical link: https://commits.webkit.org/258375 at main From noreply at github.com Sun Jan 1 21:56:25 2023 From: noreply at github.com (Yusuke Suzuki) Date: Sun, 01 Jan 2023 21:56:25 -0800 Subject: [webkit-changes] [WebKit/WebKit] 1c884d: [JSC] Add lowest/highest accessible address functions Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c884ddcfc16ea40d821dd4ed28594860d7d51df https://github.com/WebKit/WebKit/commit/1c884ddcfc16ea40d821dd4ed28594860d7d51df Author: Yusuke Suzuki Date: 2023-01-01 (Sun, 01 Jan 2023) Changed paths: M Source/JavaScriptCore/tools/Integrity.h M Source/WTF/WTF.xcodeproj/project.pbxproj A Source/WTF/wtf/AccessibleAddress.h M Source/WTF/wtf/CMakeLists.txt M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/WTFConfig.h Log Message: ----------- [JSC] Add lowest/highest accessible address functions https://bugs.webkit.org/show_bug.cgi?id=249984 rdar://103800354 Reviewed by Mark Lam. This patch adds lowestAccessibleAddress / highestAccessibleAddress. On Darwin, lowestAccessibleAddress gets __PAGEZERO information of process' executable. * Source/JavaScriptCore/tools/Integrity.h: (JSC::Integrity::isSanePointer): * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/AccessibleAddress.cpp: Added. (WTF::lowestAccessibleAddress): (WTF::highestAccessibleAddress): * Source/WTF/wtf/AccessibleAddress.h: Added. * Source/WTF/wtf/CMakeLists.txt: Canonical link: https://commits.webkit.org/258376 at main From noreply at github.com Mon Jan 2 00:24:15 2023 From: noreply at github.com (Yusuke Suzuki) Date: Mon, 02 Jan 2023 00:24:15 -0800 Subject: [webkit-changes] [WebKit/WebKit] ef9067: [JSC] Wasm Memory should be non nullptr Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ef906728e98c7ea5144f72c4a5bec2a2561c1e8d https://github.com/WebKit/WebKit/commit/ef906728e98c7ea5144f72c4a5bec2a2561c1e8d Author: Yusuke Suzuki Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp M Source/JavaScriptCore/runtime/BufferMemoryHandle.h M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmBinding.cpp M Source/JavaScriptCore/wasm/WasmInstance.h M Source/JavaScriptCore/wasm/WasmMemory.cpp M Source/JavaScriptCore/wasm/WasmMemory.h M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/js/JSToWasm.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp Log Message: ----------- [JSC] Wasm Memory should be non nullptr https://bugs.webkit.org/show_bug.cgi?id=249863 rdar://103683844 Reviewed by Mark Lam. This patch makes Wasm::Memory holding non-nullptr for zero-sized memory so that we can simplify cage handling, which can happen frequently in Wasm code. If Gigacage is enabled, we just use base-pointer. If not, allocate a page and decommit it. * Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp: (JSC::BufferMemoryHandle::nullBasePointer): (JSC::BufferMemoryHandle::~BufferMemoryHandle): * Source/JavaScriptCore/runtime/BufferMemoryHandle.h: * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::restoreWebAssemblyGlobalState): (JSC::Wasm::ExpressionType>::emitIndirectCall): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState): (JSC::Wasm::B3IRGenerator::emitIndirectCall): * Source/JavaScriptCore/wasm/WasmInstance.h: (JSC::Wasm::Instance::updateCachedMemory): * Source/JavaScriptCore/wasm/WasmMemory.cpp: (JSC::Wasm::Memory::Memory): (JSC::Wasm::Memory::grow): (JSC::Wasm::Memory::fill): (JSC::Wasm::Memory::copy): (JSC::Wasm::Memory::init): * Source/JavaScriptCore/wasm/WasmMemory.h: * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp: (JSC::JSWebAssemblyMemory::buffer): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::evaluate): Canonical link: https://commits.webkit.org/258377 at main From noreply at github.com Mon Jan 2 03:19:57 2023 From: noreply at github.com (Commit Queue) Date: Mon, 02 Jan 2023 03:19:57 -0800 Subject: [webkit-changes] [WebKit/WebKit] cee499: Wasm Tail Call needs to restore callee save regist... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cee499e5516c550b861c4bda2657023d5e076c06 https://github.com/WebKit/WebKit/commit/cee499e5516c550b861c4bda2657023d5e076c06 Author: Mark Lam Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/JavaScriptCore/llint/WebAssembly.asm Log Message: ----------- Wasm Tail Call needs to restore callee save registers preserved by caller. https://bugs.webkit.org/show_bug.cgi?id=249979 Reviewed by Yusuke Suzuki. In a normal call sequence where we have functions A, B, and C, and A calls B, which in turn calls C, the following sequence of events occur: 1. On entry to B from A, B preserves A's callee save registers. 2. On entry to C from B, C preserves B's callee save registers. 3. On exit from C to B, C restores B's callee save registers. 4. On exit from B to A, B restores A's callee save registers. However, when we have a tail call sequence like this instead: A calls B, and B tail calls C, the following events should occur: 1. On entry to B from A, B preserves A's callee save registers. 2. Before B tails call to C, B restores A's callee save registers. 3. On entry to C from B, C preserves A's callee save registers (which was restored in (2)). 4. On exit from C to A, C restores A's callee save registers. In our current implementation, we have a bug where step (2) is missing for one of the callee save registers i.e. the wasmInstance register. This only affects useFastTLS mode. For NoTLS mode, the wasmInstance register is used as a global register (similar to how TLS is used), and is not meant to be preserved / restored like a callee save register. This has been tested with ASSERTs in vmEntryToJavaScript (and friends) that verifies that callee save registers have been restored on exit. However, these ASSERTs are only in my local builds and relies on other dependencies. So, I'll have to defer landing these ASSERTs to a subsequent patch. * Source/JavaScriptCore/llint/WebAssembly.asm: Canonical link: https://commits.webkit.org/258378 at main From noreply at github.com Mon Jan 2 06:07:38 2023 From: noreply at github.com (Carlos Garcia Campos) Date: Mon, 02 Jan 2023 06:07:38 -0800 Subject: [webkit-changes] [WebKit/WebKit] 5b9af9: [GLIB] Many network process crashes when running W... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b9af92f602ee677d977c4b49768c66f0862a903 https://github.com/WebKit/WebKit/commit/5b9af92f602ee677d977c4b49768c66f0862a903 Author: Carlos Garcia Campos Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/WTF/wtf/glib/RunLoopSourcePriority.h M Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannel.h M Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelGLib.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp Log Message: ----------- [GLIB] Many network process crashes when running WPT tests https://bugs.webkit.org/show_bug.cgi?id=232629 Reviewed by Michael Catanzaro. Stop using GLib async APIs for network cache IOChannel implementation, and use the sync API from a thread instead. The async API ends up doing the job in a thread because file streams are not pollable. The problem is that the internal GThreadPool tries to change the thread scheduler setting and it fails when the current thread uses the idle scheduler, which is the case of disk cache background threads. This reverts the workaround introduced in 244519 at main. * Source/WTF/wtf/glib/RunLoopSourcePriority.h: * Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannel.h: (WebKit::NetworkCache::IOChannel::isOpened const): * Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelGLib.cpp: (WebKit::NetworkCache::IOChannel::IOChannel): (WebKit::NetworkCache::IOChannel::read): (WebKit::NetworkCache::IOChannel::write): (WebKit::NetworkCache::fillDataFromReadBuffer): Deleted. (WebKit::NetworkCache::inputStreamReadReadyCallback): Deleted. (WebKit::NetworkCache::IOChannel::readSyncInThread): Deleted. (WebKit::NetworkCache::outputStreamWriteReadyCallback): Deleted. * Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp: (WebKit::NetworkCache::Storage::Storage): (WebKit::NetworkCache::qosForBackgroundIOQueue): Deleted. Canonical link: https://commits.webkit.org/258379 at main From noreply at github.com Mon Jan 2 06:50:49 2023 From: noreply at github.com (Carlos Garcia Campos) Date: Mon, 02 Jan 2023 06:50:49 -0800 Subject: [webkit-changes] [WebKit/WebKit] ee5217: [WPE][GTK] Robustly handle subprocess leaks Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee52175fab81d992a812d6b4ee1aee603a1412c8 https://github.com/WebKit/WebKit/commit/ee52175fab81d992a812d6b4ee1aee603a1412c8 Author: Carlos Garcia Campos Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/WebKit/WebProcess/WebProcess.cpp Log Message: ----------- [WPE][GTK] Robustly handle subprocess leaks https://bugs.webkit.org/show_bug.cgi?id=249272 Reviewed by Michael Catanzaro. Call _exit from a secondary thread after the connection is closed if the main thread doesn't exit in 10 seconds. * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::callExitSoon): (WebKit::WebProcess::initializeConnection): Canonical link: https://commits.webkit.org/258380 at main From noreply at github.com Mon Jan 2 10:43:53 2023 From: noreply at github.com (Sam Weinig) Date: Mon, 02 Jan 2023 10:43:53 -0800 Subject: [webkit-changes] [WebKit/WebKit] 0e7b8c: Add enough BNF support for all CSS property longha... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e7b8c42e6a0955ba6664560ecd90648f03148a1 https://github.com/WebKit/WebKit/commit/0e7b8c42e6a0955ba6664560ecd90648f03148a1 Author: Sam Weinig Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/process-css-properties.py M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py Log Message: ----------- Add enough BNF support for all CSS property longhand grammars https://bugs.webkit.org/show_bug.cgi?id=249980 rdar://103795673 Reviewed by Antti Koivisto. Adds the remaining BNF parsing support in process-css-properties.py to parse all the CSS property and descriptor definitions specified by CSS specifications. This just adds the parsing of the grammars themselves though, and generation of the actual C++ parsers is still to come. But, with all the grammars now supported, we can enforce that a grammar is at least added to CSSProperties.json for each longhand. And in fact, what this change does is add a new "parser-grammar-unused" field that is required for all longhands that are currently using a custom parser function, as well as a "parser-grammar-unused-reason" field that has the reason it is still using the custom parser function, usually due to some kind of term we don't support generation for yet. The majority of this change is going through each property and descriptor and adding the unused grammars and reasons, as well as updating the specification metadata and "values" arrays. For the "values" arrays, we now have a hard check that any keyword the grammar supports is listed in the "values" array as well. Eventually, we should remove the "values" array entirely, and derive it from the grammars, but to do that, we need to update the "css-status" website to support parsing the grammars as well, so for now, we just enforce they are in sync. A few other smaller changes include: - Requiring "parser-grammar", "parser-function" or "skip-parser" for each longhand ("custom-parser" is only used for shorthands, and should be removed in a subsequent change). - Renaming "parser-requires-*" fields to "parser-function-requires-*" to better indicate that these only are used when "parser-function" is used as well. - Renaming "custom-parser-allows-number-or-integer-input" to "parser-function-allows-number-or-integer-input" for the same reason. - Added a new --dump-unused-grammars argument to process-css-properties.py to print out all the properties and descriptors with unused grammars as well as the "reasons". - Added a new --check-unused-grammars-values argument to process-css-properties.py to check "values" arrays against the unused grammars. This is not checked by default as at least initially, I just want the unused grammars to be checked for whether they parse. - Added support for literals (e.g. the '[' the production in css-grid), functional notation (e.g. 'rect( [ | auto ]#{4} )' in css-masking) and functional references (e.g. '' in css-masking as well) to the BNF parser. - Add support for all the BNF nodes to the Term class cluster, adding LiteralTerm, GroupTerm, OptionalTerm, BoundedRepetitionTerm, FixedSizeRepetitionTerm, and FunctionTerm. Also renamed and expanded CommaSeparatedRepetitionTerm to UnboundedRepetitionTerm. * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/process-css-properties.py: * Tools/Scripts/webkitpy/style/checkers/jsonchecker.py: Canonical link: https://commits.webkit.org/258381 at main From noreply at github.com Mon Jan 2 11:33:55 2023 From: noreply at github.com (Charlie Wolfe) Date: Mon, 02 Jan 2023 11:33:55 -0800 Subject: [webkit-changes] [WebKit/WebKit] aee01b: [ITP] User initiated cross-domain link navigations... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aee01bb955fb9818f0fbb802cd5b5392773a33a4 https://github.com/WebKit/WebKit/commit/aee01bb955fb9818f0fbb802cd5b5392773a33a4 Author: Charlie Wolfe Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: ----------- [ITP] User initiated cross-domain link navigations getting counted as Top Frame Redirects https://bugs.webkit.org/show_bug.cgi?id=223405 rdar://75552559 Reviewed by Wenson Hsieh and David Kilzer. This patch fixes a use-after-move on `userInitiatedActivity`. The variable `wasPotentiallyInitiatedByUser` uses the RefPtr `userInitiatedActivity` to determine if a navigation was user initiated. Since it has already been moved, the RefPtr will always be null. This causes an issue where ITP may incorrectly treat a user-initiated navigation as a main frame redirect. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/258382 at main From noreply at github.com Mon Jan 2 17:09:12 2023 From: noreply at github.com (Charlie Wolfe) Date: Mon, 02 Jan 2023 17:09:12 -0800 Subject: [webkit-changes] [WebKit/WebKit] cf203f: Remove unneeded content extension logging Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf203f4511ff5d596126af5057da721eb625901f https://github.com/WebKit/WebKit/commit/cf203f4511ff5d596126af5057da721eb625901f Author: Charlie Wolfe Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/platform/Logging.h Log Message: ----------- Remove unneeded content extension logging https://bugs.webkit.org/show_bug.cgi?id=249959 rdar://103780523 Reviewed by Wenson Hsieh. This removes some content extension query transform logging which is no longer needed. * Source/WebCore/contentextensions/ContentExtensionActions.cpp: (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::applyToURL const): * Source/WebCore/platform/Logging.h: Canonical link: https://commits.webkit.org/258383 at main From noreply at github.com Tue Jan 3 02:19:28 2023 From: noreply at github.com (=?UTF-8?B?xb1hbiBEb2JlcsWhZWs=?=) Date: Tue, 03 Jan 2023 02:19:28 -0800 Subject: [webkit-changes] [WebKit/WebKit] a91030: AccessibilityObjectAtspi::textAttributes() should ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a910306f1de52119a900d570b630b03e609ab031 https://github.com/WebKit/WebKit/commit/a910306f1de52119a900d570b630b03e609ab031 Author: ?an Dober?ek Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp Log Message: ----------- AccessibilityObjectAtspi::textAttributes() should move attributes HashMap into the returning struct https://bugs.webkit.org/show_bug.cgi?id=250019 Reviewed by Carlos Garcia Campos. In AccessibilityObjectAtspi::textAttributes(), the HashMap can be moved into the returning TextAttributes struct, removing the nuisance of copying the object otherwise. * Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp: (WebCore::AccessibilityObjectAtspi::textAttributes const): Canonical link: https://commits.webkit.org/258384 at main From noreply at github.com Tue Jan 3 02:37:53 2023 From: noreply at github.com (=?UTF-8?B?xb1hbiBEb2JlcsWhZWs=?=) Date: Tue, 03 Jan 2023 02:37:53 -0800 Subject: [webkit-changes] [WebKit/WebKit] d0b38a: Fix up copy-prone uses of std::tuple structured bi... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0b38ae861c77ada6620bfd3ed3642956e6f9114 https://github.com/WebKit/WebKit/commit/d0b38ae861c77ada6620bfd3ed3642956e6f9114 Author: ?an Dober?ek Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/html/TextFieldInputType.cpp M Source/WebCore/style/RuleFeature.cpp M Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp Log Message: ----------- Fix up copy-prone uses of std::tuple structured binding https://bugs.webkit.org/show_bug.cgi?id=250018 Reviewed by Carlos Garcia Campos. Adjust a few places where structured binding is used on std::tuple objects, using a lvalue-reference-qualified auto specifier to reference the objects inside the existing tuple rather than copying the whole tuple and retrieving the objects from that. * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::createContainer): * Source/WebCore/style/RuleFeature.cpp: (WebCore::Style::RuleFeatureSet::collectFeatures): * Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp: (WebKit::PrefetchCache::clearExpiredEntries): Canonical link: https://commits.webkit.org/258385 at main From noreply at github.com Tue Jan 3 04:28:48 2023 From: noreply at github.com (Rob Buis) Date: Tue, 03 Jan 2023 04:28:48 -0800 Subject: [webkit-changes] [WebKit/WebKit] 8bacbc: Remove some childTypeAllowed overrides Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8bacbc1a234bf3c1071d38df45e5e1a60112c5ec https://github.com/WebKit/WebKit/commit/8bacbc1a234bf3c1071d38df45e5e1a60112c5ec Author: Rob Buis Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/dom/CDATASection.cpp M Source/WebCore/dom/CDATASection.h M Source/WebCore/dom/Comment.cpp M Source/WebCore/dom/Comment.h M Source/WebCore/dom/Text.cpp M Source/WebCore/dom/Text.h Log Message: ----------- Remove some childTypeAllowed overrides https://bugs.webkit.org/show_bug.cgi?id=250001 Reviewed by Carlos Garcia Campos. Remove some childTypeAllowed overrides since the overrides are superfluous. * Source/WebCore/dom/CDATASection.cpp: (WebCore::CDATASection::childTypeAllowed const): Deleted. * Source/WebCore/dom/CDATASection.h: * Source/WebCore/dom/Comment.cpp: (WebCore::Comment::childTypeAllowed const): Deleted. * Source/WebCore/dom/Comment.h: * Source/WebCore/dom/Text.cpp: (WebCore::Text::childTypeAllowed const): Deleted. * Source/WebCore/dom/Text.h: Canonical link: https://commits.webkit.org/258386 at main From noreply at github.com Tue Jan 3 09:23:49 2023 From: noreply at github.com (Sam Weinig) Date: Tue, 03 Jan 2023 17:23:49 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] a0b270: Remove support for 'custom-parser' in CSSPropertie... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0b27087082a49c6b19298265965109d36581ced https://github.com/WebKit/WebKit/commit/a0b27087082a49c6b19298265965109d36581ced Author: Sam Weinig Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/process-css-properties.py M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py Log Message: ----------- Remove support for 'custom-parser' in CSSProperties.json https://bugs.webkit.org/show_bug.cgi?id=250014 rdar://103820303 Reviewed by Tim Nguyen. Remove support for 'custom-parser' in CSSProperties.json. It is now implicit for shorthands, and longhands should use the more explicit 'parser-function'. * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/process-css-properties.py: * Tools/Scripts/webkitpy/style/checkers/jsonchecker.py: Canonical link: https://commits.webkit.org/258387 at main From noreply at github.com Tue Jan 3 09:42:37 2023 From: noreply at github.com (Tim Nguyen) Date: Tue, 03 Jan 2023 09:42:37 -0800 Subject: [webkit-changes] [WebKit/WebKit] eea82b: Re-import css/selectors WPT Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eea82b4820d18eec751b0610df4400bcdc0fb2f4 https://github.com/WebKit/WebKit/commit/eea82b4820d18eec751b0610df4400bcdc0fb2f4 Author: Tim Nguyen Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/selectors/eof-right-after-selector-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/eof-some-after-selector-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-027-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-027.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.html R LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-relative-argument-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-relative-argument.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/fullscreen-pseudo-class-in-has-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/fullscreen-pseudo-class-in-has.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-after-removing-non-first-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-after-removing-non-first-element.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-for-wiping-an-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-for-wiping-an-element.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/host-pseudo-class-in-has-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/host-pseudo-class-in-has.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/subject-has-invalidation-with-display-none-anchor-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/subject-has-invalidation-with-display-none-anchor-element.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/sound-state-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/sound-state.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting-expected.html R LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-attribute-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-attribute.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-002-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-002.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-has-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-has.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-not-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-not.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-nth-child-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-nth-child.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-universal-selector-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-universal-selector.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-of-invalid-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-of-invalid.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-156.xml M LayoutTests/imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-156c.xml A LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings-expected.xht R LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings.htm A LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/scope-selector-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/selectors/scope-selector.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/spurious-brace-crash.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-027-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/tests-options.json Log Message: ----------- Re-import css/selectors WPT https://bugs.webkit.org/show_bug.cgi?id=250016 rdar://103823764 Reviewed by Antti Koivisto. Upstream revision: https://github.com/web-platform-tests/wpt/commit/7c13daa091dccae6fcb2e7a0a69f9b32dc4fc52f * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/eof-right-after-selector-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/eof-some-after-selector-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-027-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-027.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-relative-argument-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-relative-argument.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/fullscreen-pseudo-class-in-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/fullscreen-pseudo-class-in-has.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-after-removing-non-first-element-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-after-removing-non-first-element.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-for-wiping-an-element-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-for-wiping-an-element.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/host-pseudo-class-in-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/host-pseudo-class-in-has.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/subject-has-invalidation-with-display-none-anchor-element-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/subject-has-invalidation-with-display-none-anchor-element.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/sound-state-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/sound-state.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/media/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nesting.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-attribute-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-attribute.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-002-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-classname-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-has-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-has.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-not-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-not.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-nth-child-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-nth-child.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-universal-selector-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-child-of-universal-selector.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-of-invalid-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/nth-of-invalid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-156.xml: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-156c.xml: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/root-siblings.htm. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/scope-selector-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/scope-selector.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-attr-many.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/spurious-brace-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/focus-visible-027-expected.txt: Added. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/media/media-loading-state-expected.txt: Added. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/selectors/media/media-playback-state-expected.txt: Added. * LayoutTests/tests-options.json: Canonical link: https://commits.webkit.org/258388 at main From noreply at github.com Tue Jan 3 09:48:31 2023 From: noreply at github.com (Tim Nguyen) Date: Tue, 03 Jan 2023 17:48:31 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 008a2e: Selector argument for :nth-of-type or :nth-last-of... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 008a2e643a90d660aca4f029516a4c534e509c3c https://github.com/WebKit/WebKit/commit/008a2e643a90d660aca4f029516a4c534e509c3c Author: Tim Nguyen Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/css/parser/CSSSelectorParser.cpp Log Message: ----------- Selector argument for :nth-of-type or :nth-last-of-type should be rejected https://bugs.webkit.org/show_bug.cgi?id=249990 rdar://103805150 Reviewed by Antti Koivisto. The selector argument is only valid for :nth-child/:nth-last-child, it does not make sense for :nth-of-type/:nth-last-of-type given the selector matched is always the tagname (type). WebKit also didn't process the selector argument at matching time for the type selectors. See https://w3c.github.io/csswg-drafts/selectors/#nth-of-type-pseudo Test: imported/w3c/web-platform-tests/css/selectors/nth-of-invalid.html * LayoutTests/TestExpectations: * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumePseudo): Canonical link: https://commits.webkit.org/258389 at main From noreply at github.com Tue Jan 3 10:35:49 2023 From: noreply at github.com (Tetsuharu Ohzeki) Date: Tue, 03 Jan 2023 10:35:49 -0800 Subject: [webkit-changes] [WebKit/WebKit] 1c7e2e: Move oncopy/oncut/onpaste to GlobalEventHandlers Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c7e2e801ad30c50f1313047040db3ebb961d415 https://github.com/WebKit/WebKit/commit/1c7e2e801ad30c50f1313047040db3ebb961d415 Author: Tetsuharu Ohzeki Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/fast/dom/event-attribute-availability-expected.txt M LayoutTests/fast/dom/event-handler-attributes-expected.txt M LayoutTests/fast/dom/event-handler-attributes.html M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt M Source/WebCore/dom/DocumentAndElementEventHandlers.idl M Source/WebCore/dom/GlobalEventHandlers.idl Log Message: ----------- Move oncopy/oncut/onpaste to GlobalEventHandlers https://bugs.webkit.org/show_bug.cgi?id=249702 Reviewed by Tim Nguyen. This follows the spec change. * LayoutTests/fast/dom/event-attribute-availability-expected.txt: * LayoutTests/fast/dom/event-handler-attributes-expected.txt: * LayoutTests/fast/dom/event-handler-attributes.html: * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt: * Source/WebCore/dom/DocumentAndElementEventHandlers.idl: The spec removed this interface but we need to keep it because we have some non-standard event handlers. * Source/WebCore/dom/GlobalEventHandlers.idl: Canonical link: https://commits.webkit.org/258390 at main From noreply at github.com Tue Jan 3 10:38:44 2023 From: noreply at github.com (Gavin) Date: Tue, 03 Jan 2023 10:38:44 -0800 Subject: [webkit-changes] [WebKit/WebKit] d37103: Port InlinePathData to the new CoreIPC serializati... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d37103ac313f95c0d98ac255013f469f3e0d1a5a https://github.com/WebKit/WebKit/commit/d37103ac313f95c0d98ac255013f469f3e0d1a5a Author: Gavin Phillips Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Modules/webauthn/AttestationConveyancePreference.h M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/page/AutoplayEvent.h M Source/WebCore/page/ModalContainerTypes.h M Source/WebCore/platform/TextRecognitionResult.h M Source/WebCore/platform/graphics/InlinePathData.h M Source/WebCore/platform/text/TextChecking.h A Source/WebCore/platform/text/TextCheckingRequestIdentifier.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make A Source/WebKit/GPUProcess/graphics/InlinePathData.serialization.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp A Source/WebKit/Shared/TextRecognitionResult.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: ----------- Port InlinePathData to the new CoreIPC serialization format https://bugs.webkit.org/show_bug.cgi?id=249398 rdar://103404505 Reviewed by Alex Christensen. This change ports the below to the new IPC serialization format: - LineData - MoveData - QuadCurveData - BezierCurveData - ArcData::Type - ArcData - TextRecognitionWordData - TextRecognitionLineData - TextRecognitionBlockData - TextRecognitionResult - ModalContainerDecision - AutoplayEventFlags - AttestationConveyancePreference * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/webauthn/AttestationConveyancePreference.h: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/AutoplayEvent.h: * Source/WebCore/page/ModalContainerTypes.h: * Source/WebCore/platform/TextRecognitionResult.h: (WebCore::TextRecognitionResult::isEmpty const): (WebCore::TextRecognitionWordData::encode const): Deleted. (WebCore::TextRecognitionWordData::decode): Deleted. (WebCore::TextRecognitionLineData::encode const): Deleted. (WebCore::TextRecognitionLineData::decode): Deleted. (WebCore::TextRecognitionBlockData::encode const): Deleted. (WebCore::TextRecognitionBlockData::decode): Deleted. (WebCore::TextRecognitionResult::encode const): Deleted. (WebCore::TextRecognitionResult::decode): Deleted. * Source/WebCore/platform/graphics/InlinePathData.h: (WebCore::MoveData::encode const): Deleted. (WebCore::MoveData::decode): Deleted. (WebCore::LineData::encode const): Deleted. (WebCore::LineData::decode): Deleted. (WebCore::ArcData::encode const): Deleted. (WebCore::ArcData::decode): Deleted. (WebCore::QuadCurveData::encode const): Deleted. (WebCore::QuadCurveData::decode): Deleted. (WebCore::BezierCurveData::encode const): Deleted. (WebCore::BezierCurveData::decode): Deleted. * Source/WebCore/platform/text/TextChecking.h: * Source/WebCore/platform/text/TextCheckingRequestIdentifier.h: Copied from Source/WebCore/page/AutoplayEvent.h. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/GPUProcess/graphics/InlinePathData.serialization.in: Added. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: (IPC::serializedIdentifiers): * Source/WebKit/Shared/TextRecognitionResult.serialization.in: Added. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/258391 at main From noreply at github.com Tue Jan 3 10:41:16 2023 From: noreply at github.com (Matthieu Dubet) Date: Tue, 03 Jan 2023 10:41:16 -0800 Subject: [webkit-changes] [WebKit/WebKit] d741aa: Fix assert when parsing invalid CSS selector Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d741aacc0a0d44b5041b5aa90fccc48417422b72 https://github.com/WebKit/WebKit/commit/d741aacc0a0d44b5041b5aa90fccc48417422b72 Author: Matthieu Dubet Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/css/parser/CSSSelectorParser.cpp Log Message: ----------- Fix assert when parsing invalid CSS selector https://bugs.webkit.org/show_bug.cgi?id=249994 rdar://103809119 Reviewed by Tim Nguyen. When a CSS selector is invalid, we should just abort its parsing (instead of asserting that it's correct). Some tests are crashing because of this (since 258355 at main): fast/css/font_property_normal.html fast/css/parsing-invalid-block-recovery.html * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeRelativeNestedSelector): Canonical link: https://commits.webkit.org/258392 at main From noreply at github.com Tue Jan 3 11:14:20 2023 From: noreply at github.com (Aditya Keerthi) Date: Tue, 03 Jan 2023 19:14:20 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 771504: HTMLVideoElement::supportsFullscreen() is incorrec... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 771504e8eccd7361ee9ef89081333f661e92402c https://github.com/WebKit/WebKit/commit/771504e8eccd7361ee9ef89081333f661e92402c Author: Aditya Keerthi Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/html/HTMLVideoElement.cpp Log Message: ----------- HTMLVideoElement::supportsFullscreen() is incorrect when video uses element fullscreen and the fullscreen API is disabled https://bugs.webkit.org/show_bug.cgi?id=249810 rdar://103359417 Reviewed by Dean Jackson. * Source/WebCore/html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen const): Avoid short-circuiting when `ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN)` is true. Canonical link: https://commits.webkit.org/258393 at main From noreply at github.com Tue Jan 3 11:18:10 2023 From: noreply at github.com (Wenson Hsieh) Date: Tue, 03 Jan 2023 19:18:10 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 5d11f0: REGRESSION (248723@main): Videos on bbc.co.uk fail... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d11f0377c180c6fb87a0d60f84082c75753eac1 https://github.com/WebKit/WebKit/commit/5d11f0377c180c6fb87a0d60f84082c75753eac1 Author: Wenson Hsieh Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: A LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe-expected.txt A LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe.html A LayoutTests/http/tests/contentfiltering/resources/lots-of-text.html M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp Log Message: ----------- REGRESSION (248723 at main): Videos on bbc.co.uk fail to load when content filtering is enabled https://bugs.webkit.org/show_bug.cgi?id=249811 rdar://103247851 Reviewed by Brent Fulgham and Alex Christensen. On articles on bbc.co.uk, video elements are embedded inside subframes, and are only interactive once the containing subframe has finished loading (i.e. dispatched the "load" event). In the case where: 1. Content filtering is enabled, and also happens in the network process via the `CONTENT_FILTERING_IN_NETWORKING_PROCESS` codepath new in iOS 16/macOS Ventura. 2. The subframe is loaded from a disk cache entry (as opposed to over the network, or in memory cache). ...we end up never dispatching the load event on the subframe, due to the fact that the corresponding `WebCore::SubresourceLoader` driving the subframe load never gets notified that loading finished. This is because, in following code within the network process (in the codepath marked below), we exit early after delivering the cached data to the content filter, before either sending `WebResourceLoader::DidReceiveResource` or `WebResourceLoader::DidFinishResourceLoad` (the latter of which we use in the case where we don't already have a shareable resource handle). To fix this, we simply pull the logic to dispatch `WebResourceLoader::DidFinishResourceLoad` out into a separate callback, and invoke it from both places. ``` #if ENABLE(SHAREABLE_RESOURCE) if (!entry->shareableResourceHandle().isNull()) { #if ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS) if (m_contentFilter && !m_contentFilter->continueAfterDataReceived(entry->buffer()->makeContiguous(), entry->buffer()->size())) { m_contentFilter->continueAfterNotifyFinished(m_parameters.request.url()); m_contentFilter->stopFilteringMainResource(); // <------- return; } #endif send(Messages::WebResourceLoader::DidReceiveResource(entry->shareableResourceHandle())); return; } #endif ``` Note that we prefer dispatching `DidFinishResourceLoad` over `DidReceiveResource` below (which we would normally use in this shareable resource handle codepath), since the resource loader in the web process would already have received the data when content filtering is enabled, so sending the entire cached resource handle again is redundant. Test: http/tests/contentfiltering/load-event-in-allowed-subframe.html * LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe-expected.txt: Added. * LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe.html: Added. * LayoutTests/http/tests/contentfiltering/resources/lots-of-text.html: Added. Add a new test resource that consists of an HTML page that contains a large amount of text. This ensures that we'll attempt to store it in disk cache, which is a necessary part of reproducing this bug. * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::sendResultForCacheEntry): Dispatch `WebResourceLoader::DidFinishResourceLoad` in both content filtering codepaths when `CONTENT_FILTERING_IN_NETWORKING_PROCESS` is enabled. Canonical link: https://commits.webkit.org/258394 at main From noreply at github.com Tue Jan 3 11:50:46 2023 From: noreply at github.com (Ahmad Saleem) Date: Tue, 03 Jan 2023 19:50:46 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 1a99dd: Set value of m_textAsOfLastFormControlChangeEvent ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a99dd74ee9b62f22ec9030d7d89535c9affc209 https://github.com/WebKit/WebKit/commit/1a99dd74ee9b62f22ec9030d7d89535c9affc209 Author: Ahmad Saleem Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: A LayoutTests/fast/events/onchange-js-expected.txt A LayoutTests/fast/events/onchange-js.html M Source/WebCore/html/HTMLTextFormControlElement.cpp Log Message: ----------- Set value of m_textAsOfLastFormControlChangeEvent before triggering change event Set value of m_textAsOfLastFormControlChangeEvent before triggering change event https://bugs.webkit.org/show_bug.cgi?id=250025 Reviewed by Chris Dumez. This patch is to align WebKit with Blink / Chromium and Gecko / Firefox. Merge - https://src.chromium.org/viewvc/blink?revision=175565&view=revision The value is updated inside change event, which gets overwritten by setTextAsOfLastFormControlChangeEvent. This patch ensure that new value if similar to previous value trigger change event. * Source/WebCore/html/HTMLTextFormControlElement.cpp: (HTMLTextFormControl::dispatchFormControlChangeEvent): Move "dispatchChangeEvent" after setting the value * LayoutTests/fast/events/onchange-js.html: Add Test Case * LayoutTests/fast/events/onchange-js-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258395 at main From noreply at github.com Tue Jan 3 11:54:10 2023 From: noreply at github.com (Alan Coon) Date: Tue, 03 Jan 2023 19:54:10 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 2429a7: Versioning. Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: 2429a72f6cabf8cef30ccf417f850b3e45ec1921 https://github.com/WebKit/WebKit/commit/2429a72f6cabf8cef30ccf417f850b3e45ec1921 Author: Alan Coon Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7615.1.16.2 Canonical link: https://commits.webkit.org/257979.10 at safari-7615.1.16-branch From noreply at github.com Tue Jan 3 12:03:08 2023 From: noreply at github.com (Eric Carlson) Date: Tue, 03 Jan 2023 20:03:08 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 83ba7a: Cherry-pick b96cc31eec98. rdar://problem/103003618 Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: 83ba7a2701beb6dcb3a26012a9f8b2cc049be5dc https://github.com/WebKit/WebKit/commit/83ba7a2701beb6dcb3a26012a9f8b2cc049be5dc Author: Eric Carlson Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h M Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm Log Message: ----------- Cherry-pick b96cc31eec98. rdar://problem/103003618 [Cocoa] Softlink macros are not thread safe https://bugs.webkit.org/show_bug.cgi?id=249725 rdar://103003618 Reviewed by Dean Jackson. Load and cache AVCaptureDeviceType constants in the AVCaptureDeviceManager constructor, which is always called on the main thread, so they can be used on the dispatch queue used to discover the current capture devices. * Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h: * Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm: (WebCore::AVCaptureDeviceManager::currentCameras): Use m_avCaptureDeviceTypes instead of the soft link functions directly. (WebCore::AVCaptureDeviceManager::AVCaptureDeviceManager): Cache AVCaptureDeviceType constants. (WebCore::currentCameras): Deleted. Canonical link: https://commits.webkit.org/258244 at main Canonical link: https://commits.webkit.org/257979.11 at safari-7615.1.16-branch From noreply at github.com Tue Jan 3 12:06:33 2023 From: noreply at github.com (Alan Coon) Date: Tue, 03 Jan 2023 12:06:33 -0800 Subject: [webkit-changes] [WebKit/WebKit] Message-ID: Branch: refs/heads/safari-7615.1.17-branch Home: https://github.com/WebKit/WebKit From noreply at github.com Tue Jan 3 12:06:48 2023 From: noreply at github.com (EWS) Date: Tue, 03 Jan 2023 12:06:48 -0800 Subject: [webkit-changes] [WebKit/WebKit] 64ad5f: Interaction regions should take aria visibility in... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64ad5fc43e2e730b5cba0d9a4810ec5d4e4a4cdc https://github.com/WebKit/WebKit/commit/64ad5fc43e2e730b5cba0d9a4810ec5d4e4a4cdc Author: Etienne Segonzac Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/interaction-region/event-region-overflow-expected.txt M LayoutTests/interaction-region/icon-inside-button-single-region-expected.txt A LayoutTests/interaction-region/inline-link-in-aria-hidden-subtree-expected.txt A LayoutTests/interaction-region/inline-link-in-aria-hidden-subtree.html M LayoutTests/interaction-region/inline-link-in-non-composited-iframe-expected.txt M Source/WebCore/page/InteractionRegion.cpp Log Message: ----------- Interaction regions should take aria visibility into account https://bugs.webkit.org/show_bug.cgi?id=250029 Reviewed by Tim Horton. Check for aria visibility before adding an interaction region for an element. * LayoutTests/interaction-region/event-region-overflow-expected.txt: * LayoutTests/interaction-region/icon-inside-button-single-region-expected.txt: * LayoutTests/interaction-region/inline-link-in-non-composited-iframe-expected.txt: Update existing test expectations. * LayoutTests/interaction-region/inline-link-in-aria-hidden-subtree-expected.txt: Added. * LayoutTests/interaction-region/inline-link-in-aria-hidden-subtree.html: Added. Add a test case. * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): Ignore elements that are part of an aria-hidden subtree. Canonical link: https://commits.webkit.org/258396 at main From noreply at github.com Tue Jan 3 12:10:57 2023 From: noreply at github.com (Alan Coon) Date: Tue, 03 Jan 2023 20:10:57 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 459b9a: Versioning. Message-ID: Branch: refs/heads/safari-7615.1.17-branch Home: https://github.com/WebKit/WebKit Commit: 459b9a36973c9d69cb54bd20b8f5ccd12a589766 https://github.com/WebKit/WebKit/commit/459b9a36973c9d69cb54bd20b8f5ccd12a589766 Author: Alan Coon Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7615.1.17 Canonical link: https://commits.webkit.org/258382.1 at safari-7615.1.17-branch From noreply at github.com Tue Jan 3 12:15:39 2023 From: noreply at github.com (Alan Coon) Date: Tue, 03 Jan 2023 12:15:39 -0800 Subject: [webkit-changes] [WebKit/WebKit] Message-ID: Branch: refs/tags/WebKit-7615.1.16.2 Home: https://github.com/WebKit/WebKit From noreply at github.com Tue Jan 3 12:26:45 2023 From: noreply at github.com (Ahmad Saleem) Date: Tue, 03 Jan 2023 12:26:45 -0800 Subject: [webkit-changes] [WebKit/WebKit] 4558ea: Remove HTMLHeadElement.profile Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4558ead042b2345e80cb55f18656577132d4ff43 https://github.com/WebKit/WebKit/commit/4558ead042b2345e80cb55f18656577132d4ff43 Author: Ahmad Saleem Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: R LayoutTests/dom/html/level2/html/HTMLHeadElement01-expected.txt R LayoutTests/dom/html/level2/html/HTMLHeadElement01.html R LayoutTests/dom/html/level2/html/HTMLHeadElement01.js R LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01-expected.txt R LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.js R LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.xhtml M LayoutTests/fast/dom/element-attribute-js-null-expected.txt M LayoutTests/fast/dom/element-attribute-js-null.html M Source/WebCore/html/HTMLAttributeNames.in M Source/WebCore/html/HTMLHeadElement.idl M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadElement.cpp M Source/WebKitLegacy/mac/DOM/DOMHTMLHeadElement.mm Log Message: ----------- Remove HTMLHeadElement.profile Remove HTMLHeadElement.profile https://bugs.webkit.org/show_bug.cgi?id=249896 Reviewed by Ryosuke Niwa. This patch is to align with Web-Specifications and other browser engines by removing 'profile' attribute support. The patch removes "profile" attribute from 'head' element, which was removed from HTML Specifications in 2010 and later dropped by browsers as far back as 2014. Currently, only Safari / WebKit support this. * Source/WebCore/html/HTMLHeadElement.idl: Remove 'profile' * Source/WebCore/html/HTMLAttributeNames.in: Remove 'profile' * Source/WebKitLegacy/mac/DOM/DOMHTMLHeadElement.mm: Return null for 'profileAttr' & early return for setProfile function * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadElement.cpp: (webkit_dom_html_head_element_get_profile): Return 'nullptr' (webkit_dom_html_head_element_set_profile): Early return * LayoutTests/fast/dom/element-attribute-js-null.html: Rebaselined * LayoutTests/fast/dom/element-attribute-js-null-expected.txt: Rebaselined * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.xhtml: Removed * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.js: Ditto * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01-expected.txt: Ditto * LayoutTests/dom/html/level2/html/HTMLHeadElement01.html: Removed * LayoutTests/dom/html/level2/html/HTMLHeadElement01.js: Ditto * LayoutTests/dom/html/level2/html/HTMLHeadElement01-expected.txt: Ditto Canonical link: https://commits.webkit.org/258397 at main From noreply at github.com Tue Jan 3 12:32:19 2023 From: noreply at github.com (Ahmad Saleem) Date: Tue, 03 Jan 2023 20:32:19 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] f61cf2: Incorrect caret movement in some RTL contenteditab... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f61cf23abe063f69ce6408c47a6454825ce011e8 https://github.com/WebKit/WebKit/commit/f61cf23abe063f69ce6408c47a6454825ce011e8 Author: Ahmad Saleem Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: A LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt A LayoutTests/editing/selection/skip-non-editable-rtl.html M Source/WebCore/editing/VisiblePosition.cpp Log Message: ----------- Incorrect caret movement in some RTL contenteditable elements Incorrect caret movement in some RTL contenteditable elements https://bugs.webkit.org/show_bug.cgi?id=249905 Reviewed by Ryosuke Niwa. This patch is to align WebKit with Blink / Chromium and Gecko / Firefox. Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=183843 Content editable when mixed in direction RTL, it was not moving caret because editing boundary was not calculated correctly. In RTL scenario, nodes need to be calculated from after or before for left and right respectively. Based on the direction of the block calculates appropriate editing boundary. * Source/WebCore/editing/VisiblePosition.cpp: (VisiblePosition::left): Remove 'FIXME' and respect direction (VisiblePosition::right): Remove 'FIXME' and respect direction * LayoutTests/editing/selection/skip-non-editable-rtl.html: Add Test Case * LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258398 at main From noreply at github.com Tue Jan 3 12:35:10 2023 From: noreply at github.com (Nikos Mouchtaris) Date: Tue, 03 Jan 2023 20:35:10 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 30db21: Snapshotting of mainframe and subframe PDFs are bl... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30db210558cfc9c0600560297b4b312a1afc8e3a https://github.com/WebKit/WebKit/commit/30db210558cfc9c0600560297b4b312a1afc8e3a Author: Nikolaos Mouchtaris Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: ----------- Snapshotting of mainframe and subframe PDFs are blank in UI-side compositing mode https://bugs.webkit.org/show_bug.cgi?id=249065 rdar://103160251 Reviewed by Simon Fraser. Use an in process buffer when snapshotting for a frame containing a pdf. For subframe pdfs, create a WebCore::Image using the underlying data of the ShareableBitmap (which creates a CGImage using ShareableBitmap data as the CGDataProviderRef) and draw that into the GraphicsContext displaylist, which gets the image to the GPU process. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotAtSize): Canonical link: https://commits.webkit.org/258399 at main From noreply at github.com Tue Jan 3 12:59:37 2023 From: noreply at github.com (EWS) Date: Tue, 03 Jan 2023 12:59:37 -0800 Subject: [webkit-changes] [WebKit/WebKit] 7e720e: Convert six API classes to use generated serializa... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e720e06b1178d479f844eb87e99db007fd370cf https://github.com/WebKit/WebKit/commit/7e720e06b1178d479f844eb87e99db007fd370cf Author: Brent Fulgham Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/APIError.cpp M Source/WebKit/Shared/API/APIError.h A Source/WebKit/Shared/API/APIError.serialization.in R Source/WebKit/Shared/API/APIFrameHandle.cpp M Source/WebKit/Shared/API/APIFrameHandle.h A Source/WebKit/Shared/API/APIFrameHandle.serialization.in R Source/WebKit/Shared/API/APIPageHandle.cpp M Source/WebKit/Shared/API/APIPageHandle.h A Source/WebKit/Shared/API/APIPageHandle.serialization.in M Source/WebKit/Shared/API/APIURL.h A Source/WebKit/Shared/API/APIURL.serialization.in M Source/WebKit/Shared/API/APIURLRequest.cpp M Source/WebKit/Shared/API/APIURLRequest.h A Source/WebKit/Shared/API/APIURLRequest.serialization.in R Source/WebKit/Shared/API/APIURLResponse.cpp M Source/WebKit/Shared/API/APIURLResponse.h A Source/WebKit/Shared/API/APIURLResponse.serialization.in M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp M Source/WebKit/Shared/UserData.cpp M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: ----------- Convert six API classes to use generated serialization https://bugs.webkit.org/show_bug.cgi?id=249799 Reviewed by Alex Christensen. Convert APIError, APIFrameHandle, APIPageHandle, APIURL, APIURLRequest, and APIURLResponse types to use the new generated serializers. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/API/APIError.cpp: (API::Error::encode const): Deleted. (API::Error::decode): Deleted. * Source/WebKit/Shared/API/APIError.h: * Source/WebKit/Shared/API/APIError.serialization.in: Added. * Source/WebKit/Shared/API/APIFrameHandle.cpp: Removed. * Source/WebKit/Shared/API/APIFrameHandle.h: * Source/WebKit/Shared/API/APIFrameHandle.serialization.in: Added. * Source/WebKit/Shared/API/APIPageHandle.cpp: Removed. * Source/WebKit/Shared/API/APIPageHandle.h: (API::PageHandle::create): (API::PageHandle::createAutoconverting): (API::PageHandle::PageHandle): * Source/WebKit/Shared/API/APIPageHandle.serialization.in: Added. * Source/WebKit/Shared/API/APIURL.h: (API::URL::encode const): Deleted. (API::URL::decode): Deleted. * Source/WebKit/Shared/API/APIURL.serialization.in: Added. * Source/WebKit/Shared/API/APIURLRequest.cpp: (API::URLRequest::encode const): Deleted. (API::URLRequest::decode): Deleted. * Source/WebKit/Shared/API/APIURLRequest.h: * Source/WebKit/Shared/API/APIURLRequest.serialization.in: Added. * Source/WebKit/Shared/API/APIURLResponse.cpp: Removed. * Source/WebKit/Shared/API/APIURLResponse.h: (API::URLResponse::URLResponse): * Source/WebKit/Shared/API/APIURLResponse.serialization.in: Added. * Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp: * Source/WebKit/Shared/UserData.cpp: (WebKit::UserData::encode): (WebKit::UserData::decode): * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/258400 at main From noreply at github.com Tue Jan 3 13:17:41 2023 From: noreply at github.com (Brandon Stewart) Date: Tue, 03 Jan 2023 13:17:41 -0800 Subject: [webkit-changes] [WebKit/WebKit] 02a5e3: Cleanup Changelog Scripts Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02a5e30761fc261f874b36fa03f2e6c41958de22 https://github.com/WebKit/WebKit/commit/02a5e30761fc261f874b36fa03f2e6c41958de22 Author: Brandon Stewart Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: R Tools/Scripts/roll-over-ChangeLogs Log Message: ----------- Cleanup Changelog Scripts https://bugs.webkit.org/show_bug.cgi?id=250021 Reviewed by Brent Fulgham. Remove roll-over-changelogs as Changelogs were removed last year. * Tools/Scripts/roll-over-ChangeLogs: Removed. Canonical link: https://commits.webkit.org/258401 at main From noreply at github.com Tue Jan 3 13:48:10 2023 From: noreply at github.com (Per Arne Vollan) Date: Tue, 03 Jan 2023 13:48:10 -0800 Subject: [webkit-changes] [WebKit/WebKit] 088424: Add required syscall to all WebKit sandboxes Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 088424c3ef5f0da29e868cd21b22ea83127b4f66 https://github.com/WebKit/WebKit/commit/088424c3ef5f0da29e868cd21b22ea83127b4f66 Author: Per Arne Vollan Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: ----------- Add required syscall to all WebKit sandboxes https://bugs.webkit.org/show_bug.cgi?id=250034 rdar://102648393 Reviewed by Brent Fulgham. Add SYS_ulock_wait2 to all WebKit sandboxes. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/258402 at main From noreply at github.com Tue Jan 3 14:04:04 2023 From: noreply at github.com (Chris Dumez) Date: Tue, 03 Jan 2023 14:04:04 -0800 Subject: [webkit-changes] [WebKit/WebKit] da4821: [CSS-Typed-OM] flex-basis / flex-grow / flex-shrin... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da48215a5f58b6125a7423b14f79cd37d8156a50 https://github.com/WebKit/WebKit/commit/da48215a5f58b6125a7423b14f79cd37d8156a50 Author: Chris Dumez Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink.html Log Message: ----------- [CSS-Typed-OM] flex-basis / flex-grow / flex-shrink computed values should be clamped https://bugs.webkit.org/show_bug.cgi?id=250036 Reviewed by Tim Nguyen. flex-basis / flex-grow / flex-shrink computed values should be clamped, since the specification indicates the values cannot be negative: - https://w3c.github.io/csswg-drafts/css-flexbox/#flex-basis-property - https://w3c.github.io/csswg-drafts/css-sizing-3/#propdef-width - https://w3c.github.io/csswg-drafts/css-flexbox/#flex-shrink-property - https://w3c.github.io/csswg-drafts/css-flexbox/#flex-grow-property Update the Web-Platform-Tests accordingly. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-grow.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-shrink.html: Canonical link: https://commits.webkit.org/258403 at main From noreply at github.com Tue Jan 3 14:27:34 2023 From: noreply at github.com (Alex Christensen) Date: Tue, 03 Jan 2023 22:27:34 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 71a3b4: Don't punycode U+00ED Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71a3b490a749c416a034f91ae79ceca528788f33 https://github.com/WebKit/WebKit/commit/71a3b490a749c416a034f91ae79ceca528788f33 Author: Alex Christensen Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WTF/wtf/URLHelpers.cpp M Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm Log Message: ----------- Don't punycode U+00ED https://bugs.webkit.org/show_bug.cgi?id=250035 rdar://103841792 Reviewed by Tim Horton. It is visually different than 'i' and it is used in several languages that have many native speakers. It is also not punycoded in Chrome or Firefox. * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::isLookalikeCharacter): * Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/258404 at main From noreply at github.com Tue Jan 3 15:05:04 2023 From: noreply at github.com (Sam Weinig) Date: Tue, 03 Jan 2023 15:05:04 -0800 Subject: [webkit-changes] [WebKit/WebKit] ebc41d: 'parser-grammar-unused-reason' used for a few prop... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ebc41da45e849b096eed7c0c7be3c1210cdf96f4 https://github.com/WebKit/WebKit/commit/ebc41da45e849b096eed7c0c7be3c1210cdf96f4 Author: Sam Weinig Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/process-css-properties.py Log Message: ----------- 'parser-grammar-unused-reason' used for a few properties with used parser-grammars https://bugs.webkit.org/show_bug.cgi?id=250026 rdar://103835748 Reviewed by Tim Nguyen. Enforce that 'parser-grammar-unused-reason' is only used when 'parser-grammar-unused' is also set. * Source/WebCore/css/CSSProperties.json: Replace use of 'parser-grammar-unused-reason' with 'parser-grammar-comment' for properties with valid 'parser-grammar's. * Source/WebCore/css/process-css-properties.py: (StylePropertyCodeGenProperties.from_json): (DescriptorCodeGenProperties.from_json): Add check that 'parser-grammar-unused-reason' is only set when 'parser-grammar-unused' is also set. Canonical link: https://commits.webkit.org/258405 at main From noreply at github.com Tue Jan 3 15:14:06 2023 From: noreply at github.com (Chris Dumez) Date: Tue, 03 Jan 2023 23:14:06 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 43fd1b: [CSS-Typed-OM] Fix WPT tests to stop expecting neg... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43fd1b396d360bd56165c0e62a45af47d29a67e5 https://github.com/WebKit/WebKit/commit/43fd1b396d360bd56165c0e62a45af47d29a67e5 Author: Chris Dumez Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray.html M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width.html Log Message: ----------- [CSS-Typed-OM] Fix WPT tests to stop expecting negative computed values for CSS properties that only allow positive values https://bugs.webkit.org/show_bug.cgi?id=250041 Reviewed by Tim Nguyen. Fix CSS Typed OM WPT tests to stop expecting negative computed values for CSS properties that only allow positive values: - animation-duration: https://w3c.github.io/csswg-drafts/css-animations/#animation-duration - animation-iteration-count: https://w3c.github.io/csswg-drafts/css-animations/#animation-iteration-count https://w3c.github.io/csswg-drafts/css-animations/#typedef-single-animation-iteration-count - block-size: https://w3c.github.io/csswg-drafts/css-logical/#propdef-block-size https://w3c.github.io/csswg-drafts/css-sizing-3/#propdef-width - min-block-size: https://w3c.github.io/csswg-drafts/css-logical/#propdef-min-block-size https://w3c.github.io/csswg-drafts/css2/#propdef-min-width - max-block-size: https://w3c.github.io/csswg-drafts/css-logical/#propdef-max-block-size https://w3c.github.io/csswg-drafts/css2/#propdef-max-width - font-size-adjust: https://w3c.github.io/csswg-drafts/css-fonts-5/#font-size-adjust-prop - font-stretch: https://w3c.github.io/csswg-drafts/css-fonts/#font-stretch-prop - column-gap: - row-gap: https://w3c.github.io/csswg-drafts/css-align/#column-row-gap - padding-block-start: - padding-block-end: - padding-inline-start: - padding-inline-end: https://w3c.github.io/csswg-drafts/css-logical/#padding-properties https://w3c.github.io/csswg-drafts/css-box-4/#propdef-padding-top - shape-margin: https://w3c.github.io/csswg-drafts/css-shapes/#shape-margin-property - stroke-dasharray: https://svgwg.org/svg2-draft/painting.html#StrokeDashing https://svgwg.org/svg2-draft/painting.html#DataTypeDasharray - width: https://w3c.github.io/csswg-drafts/css-sizing-3/#propdef-width - min-width: https://w3c.github.io/csswg-drafts/css-sizing-3/#propdef-min-width - max-width: https://w3c.github.io/csswg-drafts/css-sizing-3/#propdef-max-width * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/block-size.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-stretch.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width.html: Canonical link: https://commits.webkit.org/258406 at main From noreply at github.com Tue Jan 3 15:49:45 2023 From: noreply at github.com (Sihui) Date: Tue, 03 Jan 2023 15:49:45 -0800 Subject: [webkit-changes] [WebKit/WebKit] 88b820: Resync wpt tests for FileSystemAccess API from ups... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88b8207e010f88451c85aafa9672e307cc57494a https://github.com/WebKit/WebKit/commit/88b8207e010f88451c85aafa9672e307cc57494a Author: Sihui Liu Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/local-fs-test-helpers.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/opaque-origin-sandbox.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/sandboxed-fs-test-helpers.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/sync-access-handle-test.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/test-helpers.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.html A LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.js A LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.worker.html R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-IndexedDB.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-isSameEntry.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-BroadcastChannel.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-Error.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-frames.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-windows.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-workers.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-frames.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-windows.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-workers.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-remove.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-getDirectoryHandle.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-getFileHandle.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-iteration.js A LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-move.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-removeEntry.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-resolve.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemFileHandle-create-sync-access-handle-dedicated-worker.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemFileHandle-getFile.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemSyncAccessHandle-flush.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream-piped.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream-write.js R LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream.js M LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/file-system-access/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/META.yml A LayoutTests/imported/w3c/web-platform-tests/fs/README.md A LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.html A LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.js A LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker.html A LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window.html A LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-dedicated-worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-service-worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-shared-worker.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target.html A LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-blob-helpers.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-helpers.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-serialize-helpers.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/opaque-origin-sandbox.html A LayoutTests/imported/w3c/web-platform-tests/fs/resources/sandboxed-fs-test-helpers.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/sync-access-handle-test.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/test-helpers.js A LayoutTests/imported/w3c/web-platform-tests/fs/resources/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-IndexedDB.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-buckets.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-getUniqueId.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-isSameEntry.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-BroadcastChannel.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-Error.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-frames.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-windows.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-workers.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-frames.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-windows.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-workers.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-remove.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-getDirectoryHandle.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-getFileHandle.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-iteration.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-removeEntry.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-resolve.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-create-sync-access-handle.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-getFile.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-move.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemSyncAccessHandle-flush.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream-piped.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream-write.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream.js A LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/fs/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/interfaces/file-system-access.idl A LayoutTests/imported/w3c/web-platform-tests/interfaces/fs.idl M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wk2/TestExpectations Log Message: ----------- Resync wpt tests for FileSystemAccess API from upstream https://bugs.webkit.org/show_bug.cgi?id=249761 rdar://103622164 Reviewed by Chris Dumez. Resync FileSystemAccess API related tests from upstream fa93f70273eb7f9a8210a4decc7c4aaf79b206eb. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.js: (idl_array.self.GLOBAL.isWindow): * LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/local-fs-test-helpers.js: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target.js: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/opaque-origin-sandbox.html: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/test-helpers.js: (async createFileWithContents): (garbageCollect): Deleted. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.js: Added. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-move.js: Added. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/file-system-access/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-IndexedDB.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-buckets.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-getUniqueId.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-Error.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-frames.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-windows.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-postMessage-workers.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-remove.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-getFileHandle.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-iteration.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-lock.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemDirectoryHandle-resolve.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-getSize.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-create-sync-access-handle.https.tentative.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-create-sync-access-handle-dedicated-worker.https.tentative.window.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-getFile.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-move.https.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.js: Added. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker.js: Added. (sync_access_handle_test): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker.js: Added. (sync_access_handle_test): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.worker.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker.js: Added. (sync_access_handle_test): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-read-write.https.tentative.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.js. (sync_access_handle_test): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.js. (sync_access_handle_test): * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-piped.https.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream-write.https.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemWritableFileStream.https.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/META.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/README.md: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.js. * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.worker-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.html. * LayoutTests/imported/w3c/web-platform-tests/fs/opaque-origin.https.window.js: Added. (add_iframe): (async verify_does_exist_in_data_uri_iframe): (async verify_results_from_sandboxed_child_window): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-dedicated-worker.js: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-service-worker.js: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target-shared-worker.js: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target.html: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/resources/message-target.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target.js. (async receiver): (add_message_event_handlers): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-blob-helpers.js: Added. (async create_message_target_blob_url): (async create_message_target_data_uri): (async create_message_target_html_without_subresources): (async fetch_text): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-helpers.js: Added. (create_dedicated_worker): (async create_service_worker): (async add_iframe): (async open_window): (async wait_for_loaded_message): (create_message_channel): (async create_file_system_handles): (async do_post_message_test): (async do_message_port_test): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/messaging-serialize-helpers.js: Added. (async serialize_handles): (async serialize_handle): (async serialize_file_system_handle): (async serialize_file_system_file_handle): (async serialize_file_system_directory_handle): (async assert_equals_cloned_handles): (assert_equals_serialized_handles): (assert_equals_serialized_handle): (assert_equals_serialized_file_system_handle): (assert_equals_serialized_file_system_file_handle): (assert_equals_serialized_file_system_directory_handle): (serialize_message_error_event): (assert_equals_serialized_message_error_event): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/opaque-origin-sandbox.html: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/opaque-origin-sandbox.html. * LayoutTests/imported/w3c/web-platform-tests/fs/resources/sandboxed-fs-test-helpers.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/sandboxed-fs-test-helpers.js. (async cleanupSandboxedFileSystem): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/sync-access-handle-test.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/sync-access-handle-test.js. (async cleanupSandboxedFileSystem): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/test-helpers.js: Copied from LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/test-helpers.js. (navigator.userAgent.includes): (async getFileSize): (async getFileContents): (async getDirectoryEntryCount): (async getSortedDirectoryEntries): (async createFileWithContents): (async cleanup_writable): * LayoutTests/imported/w3c/web-platform-tests/fs/resources/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-IndexedDB.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-IndexedDB.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-buckets.js: Added. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-getUniqueId.js: Added. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-isSameEntry.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-isSameEntry.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-BroadcastChannel.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-BroadcastChannel.js. (async create_broadcast_channel): (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-Error.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-Error.js. (async do_send_message_error_test): (async do_receive_message_error_test): (async do_send_and_receive_message_error_test): (async do_send_message_port_error_test): (async do_receive_message_port_error_test): (async do_send_and_receive_message_port_error_test): (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-frames.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-frames.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-windows.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-windows.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-MessagePort-workers.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-MessagePort-workers.js. (directory_test.async t): (self.SharedWorker.undefined.directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-frames.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-frames.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-windows.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-windows.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-postMessage-workers.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-postMessage-workers.js. (directory_test.async t): (self.SharedWorker.undefined.directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-remove.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemBaseHandle-remove.js. (directory_test.async t): (promise_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-getDirectoryHandle.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-getDirectoryHandle.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-getFileHandle.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-getFileHandle.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-iteration.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-iteration.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-removeEntry.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-removeEntry.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemDirectoryHandle-resolve.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemDirectoryHandle-resolve.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-create-sync-access-handle.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemFileHandle-create-sync-access-handle-dedicated-worker.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-getFile.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemFileHandle-getFile.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemFileHandle-move.js: Added. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemSyncAccessHandle-flush.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemSyncAccessHandle-flush.js. (sync_access_handle_test.async handle): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream-piped.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream-piped.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream-write.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream-write.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemWritableFileStream.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/file-system-access/script-tests/FileSystemWritableFileStream.js. (directory_test.async t): * LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/fs/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/interfaces/file-system-access.idl: * LayoutTests/imported/w3c/web-platform-tests/interfaces/fs.idl: Copied from LayoutTests/imported/w3c/web-platform-tests/interfaces/file-system-access.idl. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/258407 at main From noreply at github.com Tue Jan 3 15:53:54 2023 From: noreply at github.com (Said Abou-Hallawa) Date: Tue, 03 Jan 2023 23:53:54 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 1674cd: [GPU Process] [FormControls] Add a ControlPart for... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1674cd025bc6a390cb98dbe576137d3b4a24f873 https://github.com/WebKit/WebKit/commit/1674cd025bc6a390cb98dbe576137d3b4a24f873 Author: Said Abou-Hallawa Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/controls/ControlFactory.h M Source/WebCore/platform/graphics/controls/ControlPart.cpp M Source/WebCore/platform/graphics/controls/ControlPart.h M Source/WebCore/platform/graphics/controls/ControlStyle.cpp M Source/WebCore/platform/graphics/controls/ControlStyle.h M Source/WebCore/platform/graphics/controls/PlatformControl.h A Source/WebCore/platform/graphics/controls/ProgressBarPart.cpp A Source/WebCore/platform/graphics/controls/ProgressBarPart.h M Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlMac.h M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm M Source/WebCore/platform/graphics/mac/controls/MeterMac.h A Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.h A Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.mm M Source/WebCore/platform/graphics/mac/controls/TextFieldMac.h M Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeAdwaita.cpp M Source/WebCore/rendering/RenderThemeAdwaita.h M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: ----------- [GPU Process] [FormControls] Add a ControlPart for ProgressBar https://bugs.webkit.org/show_bug.cgi?id=249675 rdar://103569550 Reviewed by Aditya Keerthi. The ProgressBarPart will handle drawing the progress bar form control. On macOS, AppKit will be used to draw the platform control through the class ProgressBarMac. ProgressBarPart will hold the attributes: 'position' and 'animationStartTime' which control the display of the progress bar. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/controls/ControlFactory.h: * Source/WebCore/platform/graphics/controls/ControlPart.cpp: (WebCore::ControlPart::rectForBounds): * Source/WebCore/platform/graphics/controls/ControlPart.h: * Source/WebCore/platform/graphics/controls/ControlStyle.cpp: (WebCore::operator<<): * Source/WebCore/platform/graphics/controls/ControlStyle.h: * Source/WebCore/platform/graphics/controls/PlatformControl.h: (WebCore::PlatformControl::rectForBounds const): * Source/WebCore/platform/graphics/controls/ProgressBarPart.cpp: Copied from Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h.(WebCore::ProgressBarPart::create): (WebCore::ProgressBarPart::ProgressBarPart): (WebCore::ProgressBarPart::createPlatformControl): * Source/WebCore/platform/graphics/controls/ProgressBarPart.h: Copied from Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h. (WebCore::ProgressBarPart::position const): (WebCore::ProgressBarPart::animationStartTime const): * Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm: (WebCore::ButtonControlMac::updateCellStates): * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm: (WebCore::ControlFactoryMac::createPlatformProgressBar): * Source/WebCore/platform/graphics/mac/controls/ControlMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlMac.mm: (WebCore::ControlMac::inflatedRect): (WebCore::ControlMac::controlSizeForFont const): (WebCore::ControlMac::controlSizeForSystemFont const): (WebCore::ControlMac::controlSizeForSize const): (WebCore::ControlMac::sizeForSystemFont const): (WebCore::ControlMac::setFocusRingClipRect): (WebCore::ControlMac::updateCellStates): (WebCore::ControlMac::calculateControlSize const): Deleted. * Source/WebCore/platform/graphics/mac/controls/MeterMac.h: * Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.h: Copied from Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h. (WebCore::ProgressBarMac::owningProgressBarPart const): * Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.mm: Added. (WebCore::ProgressBarMac::ProgressBarMac): (WebCore::ProgressBarMac::cellSize const): (WebCore::ProgressBarMac::cellOutsets const): (WebCore::ProgressBarMac::rectForBounds const): (WebCore::ProgressBarMac::draw): * Source/WebCore/platform/graphics/mac/controls/TextFieldMac.h: * Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::createProgressBarPartForRenderer): (WebCore::RenderTheme::createControlPart const): (WebCore::RenderTheme::extractControlStyleStatesForRenderer const): (WebCore::RenderTheme::progressBarRectForBounds const): * Source/WebCore/rendering/RenderTheme.h: * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::progressBarRectForBounds const): * Source/WebCore/rendering/RenderThemeAdwaita.h: * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::canPaint const): (WebCore::RenderThemeMac::canCreateControlPartForRenderer const): (WebCore::RenderThemeMac::progressBarRectForBounds const): (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): Deleted. (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]): Deleted. (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:]): Deleted. (WebCore::RenderThemeMac::progressBarSizes const): Deleted. (WebCore::RenderThemeMac::progressBarMargins const): Deleted. (WebCore::RenderThemeMac::minimumProgressBarHeight const): Deleted. (WebCore::RenderThemeMac::paintProgressBar): Deleted. * Source/WebKit/Shared/WTFArgumentCoders.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/258408 at main From noreply at github.com Tue Jan 3 16:28:48 2023 From: noreply at github.com (Brandon Stewart) Date: Tue, 03 Jan 2023 16:28:48 -0800 Subject: [webkit-changes] [WebKit/WebKit] 7a7910: Add Masonry Track Sizing Tests Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a79101a21e1462bee8dc459dfa4b6745c81ae3e https://github.com/WebKit/WebKit/commit/7a79101a21e1462bee8dc459dfa4b6745c81ae3e Author: Brandon Stewart Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html Log Message: ----------- Add Masonry Track Sizing Tests https://bugs.webkit.org/show_bug.cgi?id=249860 Reviewed by Brent Fulgham. Add tests to ensure track sizing functionality is working for definite blocks and full row spanning blocks. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html: Added. Canonical link: https://commits.webkit.org/258409 at main From noreply at github.com Tue Jan 3 16:53:28 2023 From: noreply at github.com (Sam Weinig) Date: Tue, 03 Jan 2023 16:53:28 -0800 Subject: [webkit-changes] [WebKit/WebKit] 78551d: Add support for custom annotations in the CSS BNF ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78551d0c1acbf2e69884ad14f993d45f4ca1caed https://github.com/WebKit/WebKit/commit/78551d0c1acbf2e69884ad14f993d45f4ca1caed Author: Sam Weinig Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.h M Source/WebCore/css/process-css-properties.py Log Message: ----------- Add support for custom annotations in the CSS BNF syntax https://bugs.webkit.org/show_bug.cgi?id=250010 rdar://103817055 Reviewed by Simon Fraser. Adds suppport for a custom syntax to annotate the CSS property grammar BNF to allow passing additional information to the generators on a per term basis. The syntax is of the form `@(foo-bar baz)`. That is an '@' symbol followed by a space separated list of identifiers inside a pair of parentheses. In this initial commit, it is used to annotate a '#' multiplier as: "normal | #@(no-single-item-opt)" This will tell the code generators to not use the default behavior of stashing a single item list as the item itself, but rather to always return a list. * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeFontVariationTag): Deleted. (WebCore::CSSPropertyParserHelpers::consumeFontVariationSettings): Deleted. * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontTag): (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFeatureTagValue): (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFeatureSettings): (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeVariationTagValue): (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFeatureTag): Deleted. * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.h: * Source/WebCore/css/process-css-properties.py: Canonical link: https://commits.webkit.org/258410 at main From noreply at github.com Tue Jan 3 17:04:12 2023 From: noreply at github.com (Per Arne Vollan) Date: Wed, 04 Jan 2023 01:04:12 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 8c5dd8: Initially allow syscall mach in sandbox v3 Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c5dd8c31d25f3dcee0bae6f71d1509a9b697131 https://github.com/WebKit/WebKit/commit/8c5dd8c31d25f3dcee0bae6f71d1509a9b697131 Author: Per Arne Vollan Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebKit/Shared/Sandbox/common.sb Log Message: ----------- Initially allow syscall mach in sandbox v3 https://bugs.webkit.org/show_bug.cgi?id=250051 rdar://103764832 Reviewed by Brent Fulgham. Initially allow syscall mach in sandbox v3, since it was allowed in v1. Individual sandboxes will deny mach syscalls. * Source/WebKit/Shared/Sandbox/common.sb: Canonical link: https://commits.webkit.org/258411 at main From noreply at github.com Tue Jan 3 17:48:06 2023 From: noreply at github.com (Alan Baradlay) Date: Wed, 04 Jan 2023 01:48:06 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 8f9288: Remove LineBox::rootInlineBoxAlignmentOffset Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f928849b0796ce12b76247ce99b78f17cafa008 https://github.com/WebKit/WebKit/commit/8f928849b0796ce12b76247ce99b78f17cafa008 Author: Alan Baradlay Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/platform/ios/fast/text/international/bidi-neutral-run-expected.txt M LayoutTests/platform/ios/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt M LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp Log Message: ----------- Remove LineBox::rootInlineBoxAlignmentOffset https://bugs.webkit.org/show_bug.cgi?id=250030 Reviewed by Antti Koivisto. text-align property can introduce a gap between the line box and the root inline box. e.g.

right aligned text

The visual left of the root inline box is > 0 (provided the text width is < 1000px) However in logical context, the root inline box's left is always 0 while LineBox::rootInlineBoxAlignmentOffset returns the offset. Because of this, we usually do "rootInlineBox.left() + LineBox::rootInlineBoxAlignmentOffset()"" to find the actual logical left of the root inline box. In this patch, we change this behavior by offsetting the root inline box/removing LineBox::rootInlineBoxAlignmentOffset. This patch fixes some logic issues which were hidden by the fact that the root inline box's left was always assumed to be 0. (and it is also in preparation for fixing webkit.org/b/249974) * Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h: (WebCore::Layout::InlineLevelBox::logicalRight const): (WebCore::Layout::InlineLevelBox::createRootInlineBox): * Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp: (WebCore::Layout::LineBox::LineBox): (WebCore::Layout::LineBox::logicalRectForTextRun const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h: (WebCore::Layout::LineBox::rootInlineBoxAlignmentOffset const): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): (WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::build): (WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::flipRootInlineBoxRectToVisualForWritingMode const): (WebCore::Layout::InlineDisplayContentBuilder::movePointHorizontallyForWritingMode const): Deleted. * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp: (WebCore::Layout::InlineDisplayLineBuilder::build const): Canonical link: https://commits.webkit.org/258412 at main From noreply at github.com Tue Jan 3 17:56:33 2023 From: noreply at github.com (Elliott Williams) Date: Wed, 04 Jan 2023 01:56:33 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 4663bc: Generate web preferences using feature status taxo... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4663bc861b1e2ece8476a5c8708b4825cf4b03a9 https://github.com/WebKit/WebKit/commit/4663bc861b1e2ece8476a5c8708b4825cf4b03a9 Author: Elliott Williams Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/css-custom-properties-api/initialValue.html M LayoutTests/fast/css-custom-paint/properties.html M LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html M LayoutTests/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html M LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html M LayoutTests/highlight/highlight-world-leak.html M LayoutTests/http/tests/clear-site-data/bfcache.html M LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html M LayoutTests/media/vp9.html M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/webgl/webgl-draft-extensions-flag-default.html M LayoutTests/webrtc/video-av1.html M LayoutTests/webrtc/vp9-vtb.html M Source/WTF/Scripts/GeneratePreferences.rb A Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml R Source/WTF/Scripts/Preferences/WebPreferences.yaml R Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml R Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml R Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/WebCoreMacros.cmake M Source/WebCore/page/Settings.yaml M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/WebPreferences.h M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/PlatformWin.cmake M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb M Source/WebKitLegacy/mac/Scripts/generate-preferences.sh M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h M Tools/DumpRenderTree/CMakeLists.txt M Tools/DumpRenderTree/DerivedSources-input.xcfilelist M Tools/DumpRenderTree/DerivedSources.make M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm M Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm M Tools/WebKitTestRunner/CMakeLists.txt M Tools/WebKitTestRunner/DerivedSources-input.xcfilelist M Tools/WebKitTestRunner/DerivedSources.make Log Message: ----------- Generate web preferences using feature status taxonomy https://bugs.webkit.org/show_bug.cgi?id=247926 rdar://92112770 Reviewed by Brent Fulgham. Merge WebPreferences*.yaml into UnifiedWebPreferences.yaml. Insteading of using different preference files to distinguish between experimental features, internal features, and debug preferences, each preference has a `status` field that determines where it ends up. The status field was introduced as WebKit::API::FeatureStatus in https://commits.webkit.org/257166 at main, and current statuses were generated by surveying Safari/WebKit contributors at Apple. Feature status determines whether a preference is ephemeral, or backed by persistent storage. It currently determines which of the preexisting experimental / internal debug API declarations a preference appears in. Future work will expose a new interface for clients to see *all* exposed features, grouping them by status, and will replace the preexisting ExperimentalFeatures/InternalDebugFeatures listings with views onto the main list. * Source/WTF/Scripts/GeneratePreferences.rb: - Remove the base/debug/experimental/internal distinctions, and just parse an arbitrary list of preference files. - Parse feature statuses, and add methods for preference templates to query them. - Add support for automatically static_casting enum preferences to their unrefined type. It's still not possible for a UI-visible feature to be anything other than a boolean toggle, which limits the features that can be marked as "internal", "developer", "testable", "preview", and "stable". - Small quality of life changes, such as the ability to output _all_ the parse errors in a single run of the generator script. * Source/WTF/Scripts/Preferences/WebPreferences.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Added. Make some fixes and status changes to the initial version of this file generated from the survey. The main categories of fixes are: - Any preference which can be exposed in UI (including "internal" features) needs a human-readable name. - Any preference exposed beyond WebCore needs defaults values for WebKit and WebKitLegacy. - Preferences with "custom" bindings that were merely static_casts now use the automatic static_cast support provided by the generator script. - Non-boolean preferences can't be exposed as an "experimental" or "internal debug" feature yet. For now, these are reclassified as "embedder" preferences. As a test fixup: Service workers are not implemented for WebKitLegacy, and ServiceWorkersEnabled's new status of "developer" was causing the setting to be errantly turned on in DumpRenderTree. There's no reason for this flag to be exposed at all in WKL, so hide it. * Source/WTF/WTF.xcodeproj/project.pbxproj: Update file references. * Source/WTF/wtf/CMakeLists.txt: Update file references. * Source/WebCore/CMakeLists.txt: Update GenerateSettings.rb invocation. Inline the settings macro since this is the only place we use it. * Source/WebCore/DerivedSources-input.xcfilelist: Update file references. * Source/WebCore/DerivedSources.make: Update file references and GenerateSettings.rb invocation. * Source/WebCore/Scripts/GenerateSettings.rb: Update to consume the unified preferences file. The WebCore-only Settings.yaml still hosts non-feature settings. These don't need a status assigned to them; WebCore::Settings doesn't use the feature status field and these are never exposed in API (if they were, we'd probably consider them all "embedder settings"). * Source/WebCore/WebCoreMacros.cmake: Remove settings macro, no longer used. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Update file references. * Source/WebKit/CMakeLists.txt: Update GenerateSettings.rb invocation. * Source/WebKit/DerivedSources-input.xcfilelist: Update file references. * Source/WebKit/DerivedSources.make: Update file references and GenerateSettings.rb invocation. * Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb: Automatic static_casting. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Replace "Internal Debug" and "Experimental" classifications with status-based categories. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb: Use statuses to determine what constitutes an "experimental feature". * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb: Enumerate the entire list of exposed preferences. Instead of calling special updateBoolValueForFeatureKey functions for experimental or internal-debug features, pass an "ephemeral?" flag into the main updateValueForKey which determines whether the update should be persisted into user defaults. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb: Use statuses to determine what constitutes an "internal debug" feature. * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: Pass an "ephemeral" flag to set*ValueforKey. To match existing behavior, layout testing overrides are set as non-ephemeral. They don't actually cause user defaults writes, because the WebPreferences instance used by layout tests is non-persistent (doesn't have an identifier). (WKPreferencesSetBoolValueForKeyForTesting): (WKPreferencesSetDoubleValueForKeyForTesting): (WKPreferencesSetUInt32ValueForKeyForTesting): (WKPreferencesSetStringValueForKeyForTesting): * Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm: (WebKit::WebPreferences::platformInitializeStore): Adopt new macro names. (WebKit::setDebugUInt32ValueIfInUserDefaults): Deleted because no persisted preferences use uint32_t values. * Source/WebKit/UIProcess/WebPreferences.cpp: Instead of calling special updateBoolValueForFeatureKey functions for experimental or internal-debug features, update the main set/updateValueForKey methods to take an "ephemeral?" flag which determines whether the update should be persisted into user defaults. (WebKit::WebPreferences::setBoolValueForKey): (WebKit::WebPreferences::setDoubleValueForKey): (WebKit::WebPreferences::setUInt32ValueForKey): (WebKit::WebPreferences::setStringValueForKey): (WebKit::WebPreferences::updateStringValueForKey): (WebKit::WebPreferences::updateBoolValueForKey): (WebKit::WebPreferences::updateUInt32ValueForKey): (WebKit::WebPreferences::updateDoubleValueForKey): (WebKit::WebPreferences::updateFloatValueForKey): (WebKit::WebPreferences::updateBoolValueForInternalDebugFeatureKey): Deleted. (WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey): Deleted. * Source/WebKit/UIProcess/WebPreferences.h: Ditto above changes. * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: Update file references. * Source/WebKitLegacy/PlatformMac.cmake: Update GeneratePreferences.rb invocation. * Source/WebKitLegacy/PlatformWin.cmake: Ditto. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: Use statuses. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: Use statuses. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb: Support automatic static_casting. * Source/WebKitLegacy/mac/Scripts/generate-preferences.sh: Update GeneratePreferences.rb invocation. * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h: Add include statement needed for static_casting. In TestWebKitAPI, many API tests set features by searching +[WKPreferences _experimentalFeatures] and +[WKPreferences _internalDebugFeatures] for a matching key. This is frustratingly brittle, and because many features are being removed from the "experimental" UI, these search sites must be updated. * Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: * Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: (TestWebKitAPI::TEST): * Tools/DumpRenderTree/DerivedSources-input.xcfilelist: Update file references. * Tools/DumpRenderTree/DerivedSources.make: Update GeneratePreferences.rb invocation. * Tools/WebKitTestRunner/DerivedSources-input.xcfilelist: Ditto. * Tools/WebKitTestRunner/DerivedSources.make: Ditto. Update some layout test baselines, and modify some tests to enable a feature flag that they depend on which was previously in Experimental Features (and therefore on by default). Going forward, features in the "testable" status or one of the developer-facing statuses ("developer", "preview", "stable") are enabled during layout testing. * LayoutTests/css-custom-properties-api/initialValue.html: * LayoutTests/fast/css-custom-paint/properties.html: * LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html: * LayoutTests/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html: * LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html: * LayoutTests/highlight/highlight-world-leak.html: * LayoutTests/http/tests/clear-site-data/bfcache.html: * LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html: * LayoutTests/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html: * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html: * LayoutTests/media/vp9.html: * LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-default.html: * LayoutTests/webrtc/video-av1.html: * LayoutTests/webrtc/vp9-vtb.html: Canonical link: https://commits.webkit.org/258413 at main From noreply at github.com Tue Jan 3 17:59:31 2023 From: noreply at github.com (megangardner) Date: Wed, 04 Jan 2023 01:59:31 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 7eb369: Interaction: Have to tap twice to navigate on YouT... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7eb369c661c68dfc878641ff4228bf3c12cdac96 https://github.com/WebKit/WebKit/commit/7eb369c661c68dfc878641ff4228bf3c12cdac96 Author: Megan Gardner Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h M Source/WebCore/page/ios/ContentChangeObserver.cpp M Source/WebCore/page/ios/ContentChangeObserver.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: ----------- Interaction: Have to tap twice to navigate on YouTube search results https://bugs.webkit.org/show_bug.cgi?id=249740 rdar://101981614 Reviewed by Tim Horton. The Content Change Observer is triggered on the YouTube search page due to some additional information that is presented on hover. This new UI isn't interactable with additional clicks, so we should just ignore the CCO in this case and let the click fully register which allows the link to be followed with one click instead of two. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableContentChangeObserver const): * Source/WebCore/page/Quirks.h: * Source/WebCore/page/ios/ContentChangeObserver.cpp: (WebCore::isContentChangeObserverEnabled): (WebCore::ContentChangeObserver::startContentObservationForDuration): (WebCore::ContentChangeObserver::didAddTransition): (WebCore::ContentChangeObserver::didInstallDOMTimer): (WebCore::ContentChangeObserver::rendererWillBeDestroyed): (WebCore::ContentChangeObserver::touchEventDidStart): (WebCore::ContentChangeObserver::touchEventDidFinish): (WebCore::ContentChangeObserver::mouseMovedDidStart): (WebCore::ContentChangeObserver::mouseMovedDidFinish): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::handleSyntheticClick): (WebKit::WebPage::completeSyntheticClick): Canonical link: https://commits.webkit.org/258414 at main From noreply at github.com Tue Jan 3 18:00:36 2023 From: noreply at github.com (EWS) Date: Wed, 04 Jan 2023 02:00:36 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] dc7bc5: WebKit::WebPageProxy::takeFocus() should take a We... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc7bc53309b5eda8f53fd8771933f2b69c48f135 https://github.com/WebKit/WebKit/commit/dc7bc53309b5eda8f53fd8771933f2b69c48f135 Author: David Kilzer Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/page/FocusDirection.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp Log Message: ----------- WebKit::WebPageProxy::takeFocus() should take a WebCore::FocusDirection https://bugs.webkit.org/show_bug.cgi?id=249958 Reviewed by Alex Christensen. Update WebPageProxy::takeFocus() to use the enum class WebCore::FocusDirection type instead of uint32_t. * Source/WebCore/page/FocusDirection.h: - Fix formatting nit. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: - Add WebCore::FocusDirection enum class for IPC. * Source/WebKit/UIProcess/WebPageProxy.cpp: - Remove 'using namespace WebCore;' statement as drive-by clean-up. (WebKit::WebPageProxy::takeFocus): - Switch to use WebCore::FocusDirection type. - Remove unneeded static_cast<> operators. * Source/WebKit/UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::takeFocus): - Switch to use WebCore::FocusDirection type. * Source/WebKit/UIProcess/WebPageProxy.messages.in: Ditto. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::takeFocus): - Remove unneeded static_cast<> operator. Canonical link: https://commits.webkit.org/258415 at main From noreply at github.com Tue Jan 3 18:19:55 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 02:19:55 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 97d658: Make sure calling moveParagaph() with proper param... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 97d658482be252a38bb1128072ec6a3372928605 https://github.com/WebKit/WebKit/commit/97d658482be252a38bb1128072ec6a3372928605 Author: Ahmad Saleem Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: A LayoutTests/editing/execCommand/listify-output-crash-expected.txt A LayoutTests/editing/execCommand/listify-output-crash.html M Source/WebCore/editing/InsertListCommand.cpp Log Message: ----------- Make sure calling moveParagaph() with proper parameters in InsertListCommand::listifyParagraph() Make sure calling moveParagaph() with proper parameters in InsertListCommand::listifyParagraph() https://bugs.webkit.org/show_bug.cgi?id=202900 Reviewed by Ryosuke Niwa. Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=175338 This patch changes InsertListCommand::listifyParagraph() to calculate start and end positions of paragraph to move before calling moveParagaph(). Before this patch start and end positions are calculated then we insert a list element, UL/OL, and list item element, LI. These insertion can make start and end position no longer points paragraph boundary, attached test case causes this situation. Calculating start and end positions of paragraph after all DOM tree modifications ensures we call moveParagraph with valid parameters. * Source/WebCore/editing/InsertListCommand.cpp: (InsertListCommand::listifyParagraph): Refactor to update layout before selecting new start and end boundaries * LayoutTests/editing/execCommand/listify-output-crash.html: Add Test Case * LayoutTests/editing/execCommand/listify-output-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258416 at main From noreply at github.com Tue Jan 3 18:49:41 2023 From: noreply at github.com (Nikos Mouchtaris) Date: Tue, 03 Jan 2023 18:49:41 -0800 Subject: [webkit-changes] [WebKit/WebKit] 109394: Share some adjustTransientZoom() code between Tile... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10939443b246921d69184ae50092f7462a2a06b9 https://github.com/WebKit/WebKit/commit/10939443b246921d69184ae50092f7462a2a06b9 Author: Nikolaos Mouchtaris Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/DrawingArea.cpp M Source/WebKit/WebProcess/WebPage/DrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Log Message: ----------- Share some adjustTransientZoom() code between TiledCoreAnimationDrawingArea and RemoteLayerTreeDrawingAreaMac https://bugs.webkit.org/show_bug.cgi?id=250050 rdar://103851612 Reviewed by Simon Fraser. Share code that prepopulates the zoomed area in adjustTransientZoom() by moving it to DrawingArea. * Source/WebKit/WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::mainFrameTiledBacking const): (WebKit::DrawingArea::prepolateRectForZoom): * Source/WebKit/WebProcess/WebPage/DrawingArea.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::mainFrameTiledBacking const): Deleted. * Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h: * Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm: (WebKit::RemoteLayerTreeDrawingAreaMac::adjustTransientZoom): (WebKit::RemoteLayerTreeDrawingAreaMac::mainFrameTiledBacking const): Deleted. * Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom): (WebKit::TiledCoreAnimationDrawingArea::mainFrameTiledBacking const): Deleted. Canonical link: https://commits.webkit.org/258417 at main From noreply at github.com Tue Jan 3 18:57:36 2023 From: noreply at github.com (Brandon Stewart) Date: Wed, 04 Jan 2023 02:57:36 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] b93352: Skip masonry-columns-item-placement-auto-flow-next... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b93352783c4cc119de0d978f03235d11847beaee https://github.com/WebKit/WebKit/commit/b93352783c4cc119de0d978f03235d11847beaee Author: Brandon Stewart Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/TestExpectations Log Message: ----------- Skip masonry-columns-item-placement-auto-flow-next-001.html due to consistent failures on iOS https://bugs.webkit.org/show_bug.cgi?id=250028 rdar://103836338 Reviewed by Brent Fulgham. Skip test case for now due to failures on iOS. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/258418 at main From noreply at github.com Tue Jan 3 19:09:03 2023 From: noreply at github.com (Wenson Hsieh) Date: Wed, 04 Jan 2023 03:09:03 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 498d27: Add plumbing to raise Xcode issues when client-sid... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 498d27b7264195c8850d344b542b62f95946c211 https://github.com/WebKit/WebKit/commit/498d27b7264195c8850d344b542b62f95946c211 Author: Wenson Hsieh Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/Platform/SourcesCocoa.txt A Source/WebKit/Platform/cocoa/NetworkIssueReporter.h A Source/WebKit/Platform/cocoa/NetworkIssueReporter.mm M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: ----------- Add plumbing to raise Xcode issues when client-side network issues are detected https://bugs.webkit.org/show_bug.cgi?id=249897 rdar://102778314 Reviewed by Tim Horton. Raise an Xcode issue when certain network activity is observed (`NetworkIssueReporter::shouldReport` returns `true`). * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::reportNetworkIssue): If `NetworkIssueReporter::shouldReport` returned `true`, send an IPC message to the UI process, with the request URL. * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::didReceiveResponse): Consult `NetworkIssueReporter::shouldReport` upon receiving a request response. * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::configurationForSessionID): Unconditionally set `_skipsStackTraceCapture` to `YES`, for WebKit. Regardless of whether or not we're actively running in Xcode (and network issue reporting is runtime-enabled), it's never necessary to surface stack traces in the WebKit network process to developers. * Source/WebKit/Platform/SourcesCocoa.txt: * Source/WebKit/Platform/cocoa/NetworkIssueReporter.h: Added. * Source/WebKit/Platform/cocoa/NetworkIssueReporter.mm: Added. * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::reportNetworkIssue): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::prepareToLoadWebPage): Add a new helper method that adds platform data to a given load parameters, and also creates a new network issue reporter if needed. See below for call sites. (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadFile): (WebKit::WebPageProxy::loadDataWithNavigationShared): (WebKit::WebPageProxy::loadSimulatedRequest): (WebKit::WebPageProxy::loadAlternateHTML): (WebKit::WebPageProxy::loadWebArchiveData): Change several call sites of `addPlatformLoadParameters` to use `prepareToLoadWebPage` instead, which additionally creates a new network issue reporter if needed when triggwering navigation via API. (WebKit::WebPageProxy::reportNetworkIssue): Report the incoming issue if the page's `NetworkIssueReporter` has been created. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj:% Canonical link: https://commits.webkit.org/258419 at main From noreply at github.com Tue Jan 3 20:38:09 2023 From: noreply at github.com (Alan Baradlay) Date: Wed, 04 Jan 2023 04:38:09 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 7ae025: [IFC] InlineDisplay::Line::contentLogicalOffset is... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ae025d1d9d9e805555b75819f6fda3474376ae1 https://github.com/WebKit/WebKit/commit/7ae025d1d9d9e805555b75819f6fda3474376ae1 Author: Alan Baradlay Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLine.h M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp Log Message: ----------- [IFC] InlineDisplay::Line::contentLogicalOffset is really "content visual offset in inline direction" https://bugs.webkit.org/show_bug.cgi?id=250033 Reviewed by Antti Koivisto. This value represents the visual content location in inline direction before we flip it for writing mode. * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h: (WebCore::InlineDisplay::Line::contentVisualOffsetInInlineDirection const): (WebCore::InlineDisplay::Line::Line): (WebCore::InlineDisplay::Line::contentLogicalOffset const): Deleted. * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp: (WebCore::Layout::InlineDisplayLineBuilder::build const): * Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::textRun const): * Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h: (WebCore::InlineIterator::LineBoxIteratorModernPath::contentLogicalLeft const): * Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp: (WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const): * Source/WebCore/layout/integration/inline/LayoutIntegrationLine.h: (WebCore::LayoutIntegration::Line::Line): (WebCore::LayoutIntegration::Line::contentVisualOffsetInInlineDirection const): (WebCore::LayoutIntegration::Line::contentLogicalOffset const): Deleted. * Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp: (WebCore::LayoutIntegration::makeAdjustedContent): Canonical link: https://commits.webkit.org/258420 at main From noreply at github.com Tue Jan 3 20:43:12 2023 From: noreply at github.com (Don Olmstead) Date: Wed, 04 Jan 2023 04:43:12 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] d2477f: [CMake] Fix version detection of libwpe Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2477fc765e231521b33da5342255e0520bde404 https://github.com/WebKit/WebKit/commit/d2477fc765e231521b33da5342255e0520bde404 Author: Don Olmstead Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M Source/cmake/FindWPE.cmake M Source/cmake/OptionsPlayStation.cmake Log Message: ----------- [CMake] Fix version detection of libwpe https://bugs.webkit.org/show_bug.cgi?id=250054 Reviewed by Michael Catanzaro. The wrong header was being searched for the version number. Also the regex wasn't correct. Bump the version required by PlayStation to be 1.14. * Source/cmake/FindWPE.cmake: * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/258421 at main From noreply at github.com Tue Jan 3 23:17:21 2023 From: noreply at github.com (Commit Queue) Date: Wed, 04 Jan 2023 07:17:21 +0000 (UTC) Subject: [webkit-changes] [WebKit/WebKit] 95574f: Unreviewed, reverting r258413@main. Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95574fc8fca2ca49042c5c31ed3270ebb4116c45 https://github.com/WebKit/WebKit/commit/95574fc8fca2ca49042c5c31ed3270ebb4116c45 Author: Commit Queue Date: 2023-01-03 (Tue, 03 Jan 2023) Changed paths: M LayoutTests/css-custom-properties-api/initialValue.html M LayoutTests/fast/css-custom-paint/properties.html M LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html M LayoutTests/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html M LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html M LayoutTests/highlight/highlight-world-leak.html M LayoutTests/http/tests/clear-site-data/bfcache.html M LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html M LayoutTests/media/vp9.html M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/webgl/webgl-draft-extensions-flag-default.html M LayoutTests/webrtc/video-av1.html M LayoutTests/webrtc/vp9-vtb.html M Source/WTF/Scripts/GeneratePreferences.rb R Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml A Source/WTF/Scripts/Preferences/WebPreferences.yaml A Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml A Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml A Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/WebCoreMacros.cmake M Source/WebCore/page/Settings.yaml M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/WebPreferences.h M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/PlatformWin.cmake M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb M Source/WebKitLegacy/mac/Scripts/generate-preferences.sh M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h M Tools/DumpRenderTree/CMakeLists.txt M Tools/DumpRenderTree/DerivedSources-input.xcfilelist M Tools/DumpRenderTree/DerivedSources.make M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm M Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm M Tools/WebKitTestRunner/CMakeLists.txt M Tools/WebKitTestRunner/DerivedSources-input.xcfilelist M Tools/WebKitTestRunner/DerivedSources.make Log Message: ----------- Unreviewed, reverting r258413 at main. https://bugs.webkit.org/show_bug.cgi?id=250065 Broke macOS builds Reverted changeset: "Generate web preferences using feature status taxonomy" https://bugs.webkit.org/show_bug.cgi?id=247926 https://commits.webkit.org/258413 at main Canonical link: https://commits.webkit.org/258422 at main From noreply at github.com Wed Jan 4 01:22:33 2023 From: noreply at github.com (youennf) Date: Wed, 04 Jan 2023 01:22:33 -0800 Subject: [webkit-changes] [WebKit/WebKit] 841d41: Limit DOMAudioSession to third-party iframes havin... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 841d41b575bcfd5c59e96ca4d6417ee1a5ea6f7f https://github.com/WebKit/WebKit/commit/841d41b575bcfd5c59e96ca4d6417ee1a5ea6f7f Author: Youenn Fablet Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/http/tests/webrtc/audioSessionInFrames-expected.txt A LayoutTests/http/tests/webrtc/audioSessionInFrames.html A LayoutTests/http/tests/webrtc/resources/audioSessionFrame.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/Modules/audiosession/DOMAudioSession.cpp Log Message: ----------- Limit DOMAudioSession to third-party iframes having microphone access https://bugs.webkit.org/show_bug.cgi?id=249577 rdar://problem/103514560 Reviewed by Eric Carlson. We might want to allow access to DOMAudioSession to more third party iframes in the future. For now, since the main use case is microphone/WebRTC related, let's reduce access to those iframes that can access microphones. * LayoutTests/http/tests/webrtc/audioSessionInFrames-expected.txt: Added. * LayoutTests/http/tests/webrtc/audioSessionInFrames.html: Added. * LayoutTests/http/tests/webrtc/resources/audioSessionFrame.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/Modules/audiosession/DOMAudioSession.cpp: (WebCore::DOMAudioSession::setType): (WebCore::DOMAudioSession::type const): (WebCore::DOMAudioSession::state const): (WebCore::DOMAudioSession::scheduleStateChangeEvent): Canonical link: https://commits.webkit.org/258423 at main From noreply at github.com Wed Jan 4 01:25:42 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 01:25:42 -0800 Subject: [webkit-changes] [WebKit/WebKit] 20043f: Remove unused "positionListMarker" from RenderList... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20043f97b45d02d55e8f9b28f84903dc01aa4b46 https://github.com/WebKit/WebKit/commit/20043f97b45d02d55e8f9b28f84903dc01aa4b46 Author: Ahmad Saleem Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/rendering/RenderListItem.h Log Message: ----------- Remove unused "positionListMarker" from RenderListItem.h Remove unused "positionListMarker" from RenderListItem.h https://bugs.webkit.org/show_bug.cgi?id=250069 Reviewed by Tim Nguyen. This patch removes unused "positionListMarker" which seems to be defined here only but never used or referenced in any other .cpp & .h files. * Source/WebCore/rendering/RenderListItem.h: Remove unused 'positionListMarker' Canonical link: https://commits.webkit.org/258424 at main From noreply at github.com Wed Jan 4 01:26:51 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 01:26:51 -0800 Subject: [webkit-changes] [WebKit/WebKit] 185eb4: Remove unused "nodeUnderMouse" from EventHandler.h Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 185eb43ee5ff0b8c9c221845c1be23a56f02e9f5 https://github.com/WebKit/WebKit/commit/185eb43ee5ff0b8c9c221845c1be23a56f02e9f5 Author: Ahmad Saleem Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/page/EventHandler.h Log Message: ----------- Remove unused "nodeUnderMouse" from EventHandler.h Remove unused "nodeUnderMouse" from EventHandler.h https://bugs.webkit.org/show_bug.cgi?id=250038 Reviewed by Ryosuke Niwa. This patch removes unused "nodeUnderMouse" which seems to be defined here only but never used or referenced in any other .cpp & .h files. * Source/WebCore/page/EventHandler.h: Remove unused 'nodeUnderMouse' Canonical link: https://commits.webkit.org/258425 at main From noreply at github.com Wed Jan 4 02:56:02 2023 From: noreply at github.com (youennf) Date: Wed, 04 Jan 2023 02:56:02 -0800 Subject: [webkit-changes] [WebKit/WebKit] 7598f5: media/audioSession/audioSessionType.html is flaky Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7598f5a99fa221d4c542a8715fa0cc5655444789 https://github.com/WebKit/WebKit/commit/7598f5a99fa221d4c542a8715fa0cc5655444789 Author: Youenn Fablet Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/media/audioSession/audioSessionType.html Log Message: ----------- media/audioSession/audioSessionType.html is flaky https://bugs.webkit.org/show_bug.cgi?id=249998 rdar://problem/103810613 Reviewed by Eric Carlson. The category is set based on media element state. When a media element is playing, its category should be MediaPlayback. But this is racy with how the test is written (promise returned by play). To make the test more predictable, we check internals.audioSessionCategory until it has the expected value. * LayoutTests/media/audioSession/audioSessionType.html: Canonical link: https://commits.webkit.org/258426 at main From noreply at github.com Wed Jan 4 04:22:37 2023 From: noreply at github.com (youennf) Date: Wed, 04 Jan 2023 04:22:37 -0800 Subject: [webkit-changes] [WebKit/WebKit] 05edf3: Make sure LibWebRTCCodecs is correctly configured ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05edf32b39648ad45e37fb5a9b2f3d5292915cff https://github.com/WebKit/WebKit/commit/05edf32b39648ad45e37fb5a9b2f3d5292915cff Author: Youenn Fablet Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp M Source/WebKit/WebProcess/GPU/GPUProcessConnection.h M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm Log Message: ----------- Make sure LibWebRTCCodecs is correctly configured in WebCodecs only code path https://bugs.webkit.org/show_bug.cgi?id=250000 rdar://103582757 Reviewed by Eric Carlson. We were only setting the use of remote frames in peer connection code path, but not WebCodecs. Instead, we now initialize LibWebRTCCodecs remote frame use for each web page. Since we cannot easily change the callbacks when set since they are used in background threads, we are allowing to set the callbacks but not unset them to null. We are now calling LibWebRTCCodecs::setCallbacks at WebPage initialization time. For that matter, we can no longer create a GPUProcess connection to get VP9 info. What we do is setting LibWebRTCCodecs VP9 info when the GPUProcess connection is created. Covered by WebCodec tests exercising decoders. * Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp: * Source/WebKit/WebProcess/GPU/GPUProcessConnection.h: * Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp: * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::LibWebRTCCodecs::setCallbacks): (WebKit::LibWebRTCCodecs::createDecoderInternal): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: (WebKit::LibWebRTCProvider::createPeerConnection): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h: * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformInitialize): Canonical link: https://commits.webkit.org/258427 at main From noreply at github.com Wed Jan 4 04:25:33 2023 From: noreply at github.com (youennf) Date: Wed, 04 Jan 2023 04:25:33 -0800 Subject: [webkit-changes] [WebKit/WebKit] 1796e2: Consider using HAL output unit in case echo cancel... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1796e2f138aba9c879d20e49e6458ae7e3fef898 https://github.com/WebKit/WebKit/commit/1796e2f138aba9c879d20e49e6458ae7e3fef898 Author: Youenn Fablet Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h M Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp Log Message: ----------- Consider using HAL output unit in case echo cancellation is disabled https://bugs.webkit.org/show_bug.cgi?id=235643 rdar://problem/88379822 Reviewed by Eric Carlson. We use RemoteIO aon iOS or HAL on macOS to capture microphone when echo cancellation is off. This allows to bypass voice specific processing and gets higher fidelity recording. On macOS, we only use HAL for recording and not rendering of audio. For that reason we introduce isAudioCaptureUnitRenderingAudio in WebCore that is used in WebKit to play audio or not through the capture unit. Update MockAudioSharedInternalUnit to enable echo cancellation according the boolean parameter instead of properties provided to MockAudioSharedInternalUnit. * Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSourceFactory::isAudioCaptureUnitRenderingAudio): * Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h: * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp: (WebCore::CoreAudioSharedInternalUnit::create): (WebCore::CoreAudioSharedUnit::setupAudioUnit): (WebCore::CoreAudioSharedUnit::validateOutputDevice): * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h: * Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm: (WebCore::MockAudioSharedUnit::singleton): (WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit): (WebCore::MockAudioSharedInternalUnit::set): * Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp: (WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start): (WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::captureUnitIsStarting): Canonical link: https://commits.webkit.org/258428 at main From noreply at github.com Wed Jan 4 06:48:21 2023 From: noreply at github.com (Philippe Normand) Date: Wed, 04 Jan 2023 06:48:21 -0800 Subject: [webkit-changes] [WebKit/WebKit] c8a10c: [GLib] Allow GStreamer tracer usage in test harness Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8a10ceb17997c4cd9cb310fcea2bdedb405c625 https://github.com/WebKit/WebKit/commit/c8a10ceb17997c4cd9cb310fcea2bdedb405c625 Author: Philippe Normand Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Tools/Scripts/webkitpy/port/glib.py Log Message: ----------- [GLib] Allow GStreamer tracer usage in test harness https://bugs.webkit.org/show_bug.cgi?id=250075 Reviewed by ?an Dober?ek. The `GST_TRACERS` environment variable is useful when debugging media tests. * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): Canonical link: https://commits.webkit.org/258429 at main From noreply at github.com Wed Jan 4 07:04:51 2023 From: noreply at github.com (EWS) Date: Wed, 04 Jan 2023 07:04:51 -0800 Subject: [webkit-changes] [WebKit/WebKit] 8bc1b9: Remove HTMLElement::form() and de-virtualize the m... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8bc1b9f068aa6256966efb5c40963ebd8009a87c https://github.com/WebKit/WebKit/commit/8bc1b9f068aa6256966efb5c40963ebd8009a87c Author: Alexey Shvayka Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/compile-event-handler-lexical-scopes-form-owner-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/compile-event-handler-lexical-scopes-form-owner.html M Source/WebCore/bindings/js/JSHTMLElementCustom.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormControlElement.h M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLFormElement.h M Source/WebCore/html/HTMLImageElement.h M Source/WebCore/html/HTMLLabelElement.h M Source/WebCore/html/HTMLLegendElement.h M Source/WebCore/html/HTMLObjectElement.h M Source/WebCore/html/HTMLOptionElement.h Log Message: ----------- Remove HTMLElement::form() and de-virtualize the method https://bugs.webkit.org/show_bug.cgi?id=248880 Reviewed by Ryosuke Niwa. De-virtualization of form() speeds up HTMLFormControlElement, removes method forwarding from form-associated elements, and exposes 2 issues: 1. HTMLFormElement::shouldAutocorrect() attempted to access form() on a

element, which doesn't make sense as nested forms are not allowed by HTML [1]. Removed in favor of now identical HTMLElement::shouldAutocorrect(), resolving a few FIXMEs. 2. Per spec [2], JSHTMLElement::pushEventHandlerScope() should set up HTMLFormElement's lexical scope only for form-associated elements rather than all descendants. This speeds up inline event handler compilation / execution and aligns WebKit with Blink and partly Gecko. [1] https://html.spec.whatwg.org/multipage/forms.html#the-form-element (content model) [2] https://html.spec.whatwg.org/multipage/webappapis.html#getting-the-current-value-of-the-event-handler (step 3.5) * Source/WebCore/bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope const): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::form const): Deleted. * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLFormControlElement.cpp: * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::shouldAutocorrect const): Deleted. * Source/WebCore/html/HTMLFormElement.h: * Source/WebCore/html/HTMLImageElement.h: * Source/WebCore/html/HTMLLabelElement.h: * Source/WebCore/html/HTMLLegendElement.h: * Source/WebCore/html/HTMLObjectElement.h: * Source/WebCore/html/HTMLOptionElement.h: * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/compile-event-handler-lexical-scopes-form-owner-expected.txt * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/compile-event-handler-lexical-scopes-form-owner.html Canonical link: https://commits.webkit.org/258430 at main From noreply at github.com Wed Jan 4 07:58:49 2023 From: noreply at github.com (Per Arne Vollan) Date: Wed, 04 Jan 2023 07:58:49 -0800 Subject: [webkit-changes] [WebKit/WebKit] 34a36c: Re-land Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34a36c72aeaa47bf2c96a203864218128144db63 https://github.com/WebKit/WebKit/commit/34a36c72aeaa47bf2c96a203864218128144db63 Author: Per Arne Vollan Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm M Source/WebKit/Shared/SandboxExtension.h M Source/WebKit/Shared/WebPageCreationParameters.cpp M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.cpp M Source/WebKit/Shared/WebProcessCreationParameters.h M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm M Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp M Source/WebKit/UIProcess/UserMediaProcessManager.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp M Source/WebKit/WebProcess/MediaStream/MediaDeviceSandboxExtensions.h M Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp M Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.h M Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.messages.in M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/win/WebProcessWin.cpp Log Message: ----------- Re-land https://bugs.webkit.org/show_bug.cgi?id=249999 rdar://92608084 Unreviewed, re-land . Re-land with an assert fix and crash fix. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::SandboxExtension::createHandleForMachBootstrapExtension): (WebKit::SandboxExtension::createHandleForMachLookup): (WebKit::SandboxExtension::createHandlesForMachLookup): * Source/WebKit/Shared/SandboxExtension.h: * Source/WebKit/Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode): * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions): (WebKit::WebPageProxy::grantAccessToAssetServices): (WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry): * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::registerNotificationObservers): * Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm: (WebKit::WebProcessProxy::fontdMachExtensionHandles const): (WebKit::WebProcessProxy::fontdMachExtensionHandle const): Deleted. * Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp: (WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::addSource): * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest): * Source/WebKit/UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon): (WebKit::WebPageProxy::creationParameters): * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp: (WebKit::MediaDeviceSandboxExtensions::MediaDeviceSandboxExtensions): (WebKit::MediaDeviceSandboxExtensions::encode const): (WebKit::MediaDeviceSandboxExtensions::decode): * Source/WebKit/WebProcess/MediaStream/MediaDeviceSandboxExtensions.h: (WebKit::MediaDeviceSandboxExtensions::machBootstrapExtension): * Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp: (WebKit::SpeechRecognitionRealtimeMediaSourceManager::grantSandboxExtensions): (WebKit::SpeechRecognitionRealtimeMediaSourceManager::revokeSandboxExtensions): * Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.h: * Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.messages.in: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::m_appHighlightsVisible): (WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon): (WebKit::WebPage::userMediaAccessWasGranted): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::grantUserMediaDeviceSandboxExtensions): (WebKit::WebProcess::revokeUserMediaDeviceSandboxExtensions): * Source/WebKit/WebProcess/WebProcess.h: * Source/WebKit/WebProcess/WebProcess.messages.in: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::revokeAccessToAssetServices): (WebKit::WebProcess::switchFromStaticFontRegistryToUserFontRegistry): (WebKit::WebProcess::openDirectoryCacheInvalidated): * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: * Source/WebKit/WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::switchFromStaticFontRegistryToUserFontRegistry): * Source/WebKit/WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::grantAccessToAssetServices): (WebKit::WebProcess::switchFromStaticFontRegistryToUserFontRegistry): Canonical link: https://commits.webkit.org/258431 at main From noreply at github.com Wed Jan 4 08:47:06 2023 From: noreply at github.com (Alan Baradlay) Date: Wed, 04 Jan 2023 08:47:06 -0800 Subject: [webkit-changes] [WebKit/WebKit] 46380d: [IFC] showRenderTree always dumps the first root i... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46380d75db7aecede078c984683db3fb8556dfd1 https://github.com/WebKit/WebKit/commit/46380d75db7aecede078c984683db3fb8556dfd1 Author: Alan Baradlay Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp Log Message: ----------- [IFC] showRenderTree always dumps the first root inline box's geometry https://bugs.webkit.org/show_bug.cgi?id=250061 Reviewed by Antti Koivisto. showInlineContent dumps boxes[0] as the root inline box geometry for each line. * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::showInlineContent): Merge the 2 separate inner for loops and use 2 dedicated TextStream objects instead (to print inline boxes first). Canonical link: https://commits.webkit.org/258432 at main From noreply at github.com Wed Jan 4 09:12:42 2023 From: noreply at github.com (Commit Queue) Date: Wed, 04 Jan 2023 09:12:42 -0800 Subject: [webkit-changes] [WebKit/WebKit] 07e931: WebKit::LegacyCustomProtocolManager::didReceiveRes... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07e9312ccba7cc1c280a7638c4e03030db0aba06 https://github.com/WebKit/WebKit/commit/07e9312ccba7cc1c280a7638c4e03030db0aba06 Author: David Kilzer Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in M Source/WebKit/PlatformMac.cmake A Source/WebKit/Shared/Cocoa/CacheStoragePolicy.h A Source/WebKit/Shared/Cocoa/CacheStoragePolicy.serialization.in M Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm M Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp M Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: ----------- WebKit::LegacyCustomProtocolManager::didReceiveResponse() should take a specific type for cacheStoragePolicy https://bugs.webkit.org/show_bug.cgi?id=250006 Reviewed by Alex Christensen. Update LegacyCustomProtocolManager::didReceiveResponse() to use new WebKit::CacheStoragePolicy enum class instead of uint32_t. Helper methods are used to convert between CacheStoragePolicy and NSURLCacheStoragePolicy enum values. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/PlatformMac.cmake: - Add CacheStoragePolicy.serialization.in to build files. * Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: (WebKit::LegacyCustomProtocolManager::didReceiveResponse): * Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: (WebKit::LegacyCustomProtocolManager::didReceiveResponse): * Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: - Switch to use WebKit::CacheStoragePolicy. * Source/WebKit/Shared/Cocoa/CacheStoragePolicy.h: Add. (WebKit::CacheStoragePolicy): (WebKit::toNSURLCacheStoragePolicy): (WebKit::toCacheStoragePolicy): - Add enum class and conversion functions. * Source/WebKit/Shared/Cocoa/CacheStoragePolicy.serialization.in: Add. - Add for IPC. * Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: (-[WKCustomProtocolLoader connection:didReceiveResponse:]): * Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: (WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse): * Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: (WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse): - Switch to use WebKit::CacheStoragePolicy. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: - Add CacheStoragePolicy.h and CacheStoragePolicy.serialization.in to Xcode project. Canonical link: https://commits.webkit.org/258433 at main From noreply at github.com Wed Jan 4 09:16:02 2023 From: noreply at github.com (Vitor Roriz) Date: Wed, 04 Jan 2023 09:16:02 -0800 Subject: [webkit-changes] [WebKit/WebKit] ac2f8a: Implementing CounterStyle representation from Styl... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac2f8a4229ceb0edf14da7a59709f299970836b4 https://github.com/WebKit/WebKit/commit/ac2f8a4229ceb0edf14da7a59709f299970836b4 Author: Vitor Roriz Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/css/CSSCounterStyle.cpp A Source/WebCore/css/CSSCounterStyle.h A Source/WebCore/css/CSSCounterStyleDescriptors.cpp A Source/WebCore/css/CSSCounterStyleDescriptors.h M Source/WebCore/css/CSSCounterStyleRule.cpp M Source/WebCore/css/CSSCounterStyleRule.h M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/dom/Element.h M Source/WebCore/style/MatchedDeclarationsCache.cpp Log Message: ----------- Implementing CounterStyle representation from StyleRuleCounterStyle https://bugs.webkit.org/show_bug.cgi?id=248666 rdar://102910060 Reviewed by Antti Koivisto. Reviewed by Antti Koivisto. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Adding CSSCounterStyle and CSSCounterStyleDescriptors .h and .cpp files. * Source/WebCore/css/CSSCounterStyle.cpp: Added. (WebCore::CounterStyle::isInRange const): Returns true if counter is in range, as defined by https://www.w3.org/TR/css-counter-styles-3/#descdef-counter-style-range. (WebCore::CounterStyle::CounterStyle): (WebCore::CounterStyle::create): (WebCore::CounterStyle::createCounterStyleDecimal): Create a CounterStyle object representing a Decimal counter. (WebCore::CounterStyle::setFallbackReference): (WebCore::CounterStyle::extendAndResolve): Extend another CounterStyle as defined by https://www.w3.org/TR/css-counter-styles-3/#extends-system and resolve its Extend reference. The counter's system value is then promoted from 'extend' to the valye of the CounterStyle we are extending. (WebCore::CounterStyle::text): Dummy text representation for the counter. The real representation wil be implemented by rdar://103648354. * Source/WebCore/css/CSSCounterStyle.h: Added. (WebCore::CounterStyle::operator== const): (WebCore::CounterStyle::fallbackName const): (WebCore::CounterStyle::extendsName const): (WebCore::CounterStyle::isFallbackUnresolved): (WebCore::CounterStyle::isExtendsUnresolved): (WebCore::CounterStyle::isExtendsSystem const): (WebCore::CounterStyle::system const): (WebCore::CounterStyle::isPredefinedCounterStyle const): Returns true if CounterStyle is predefined by the user agent stylesheet. A counter style parsed from author-defined rule will return false. (WebCore::CounterStyle::isAutoRange const): Returns true if the range descriptor is set to 'auto'. A 'auto' value is represented by a empty vector of ranges. * Source/WebCore/css/CSSCounterStyleRule.cpp: (WebCore::toCounterStyleSystemEnum): * Source/WebCore/css/CSSCounterStyleRule.h: Moving enum to CSSCounterStyle.h. Adding getters for the properties's CSS values. * Source/WebCore/css/CSSStyleSheet.cpp: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeCounterStyleSystem): * Source/WebCore/dom/Element.h: * Source/WebCore/style/MatchedDeclarationsCache.cpp: (WebCore::Style::MatchedDeclarationsCache::isCacheable): Adding FIXME with matching radars. CSSCounterStyleDescriptors defines the descriptors for the counter-style rule in a specialized manner. It serves as a payload for CSSCounterStyle. * Source/WebCore/css/CSSCounterStyleDescriptors.cpp: Added. (WebCore::translateRangeFromStyleProperties): (WebCore::symbolToString): (WebCore::translatePadFromStyleProperties): (WebCore::translateNegativeSymbolsFromStyleProperties): (WebCore::translateSymbolsFromStyleProperties): (WebCore::translateFallbackNameFromStyleProperties): (WebCore::translatePrefixFromStyleProperties): (WebCore::translateSuffixFromStyleProperties): (WebCore::extractDataFromSystemDescriptor): (WebCore::CSSCounterStyleDescriptors::setExplicitlySetDescriptors): Translation from CSSValues of rule's properties to adequated specialized types. (WebCore::CSSCounterStyleDescriptors::create): Creates an instance of CSSCounterStyleDescriptor based on StyleProperties. A create function was preferred instead of a constructor in order to maintain the class as a aggregate, enabling desginated initializers. * Source/WebCore/css/CSSCounterStyleDescriptors.h: Added. Canonical link: https://commits.webkit.org/258434 at main From noreply at github.com Wed Jan 4 09:20:29 2023 From: noreply at github.com (Chris Fleizach) Date: Wed, 04 Jan 2023 09:20:29 -0800 Subject: [webkit-changes] [WebKit/WebKit] 3f6b03: AX: nested role="presentation" elements break role... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f6b035046547cbbff1ceb77d98f8767a7a8ba89 https://github.com/WebKit/WebKit/commit/3f6b035046547cbbff1ceb77d98f8767a7a8ba89 Author: Chris Fleizach Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/accessibility/mac/nested-tree-presentation-roles-expected.txt A LayoutTests/accessibility/mac/nested-tree-presentation-roles.html M Source/WebCore/accessibility/AccessibilityTree.cpp M Source/WebCore/accessibility/AccessibilityTree.h Log Message: ----------- AX: nested role="presentation" elements break role="tree" behavior https://bugs.webkit.org/show_bug.cgi?id=227906 Reviewed by Andres Gonzalez. Trees can have arbitrary levels of nesting of role="presentational" elements. * LayoutTests/accessibility/mac/nested-tree-presentation-roles-expected.txt: Added. * LayoutTests/accessibility/mac/nested-tree-presentation-roles.html: Added. * Source/WebCore/accessibility/AccessibilityTree.cpp: (WebCore::AccessibilityTree::isTreeValid const): (WebCore::AccessibilityTree::nodeHasTreeItemChild const): Deleted. * Source/WebCore/accessibility/AccessibilityTree.h: Canonical link: https://commits.webkit.org/258435 at main From noreply at github.com Wed Jan 4 10:01:48 2023 From: noreply at github.com (Alex Christensen) Date: Wed, 04 Jan 2023 10:01:48 -0800 Subject: [webkit-changes] [WebKit/WebKit] 24a172: Rebaseline IDN test for WK1 after 258404@main Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24a17225812f20be6217f8321cf1536999950781 https://github.com/WebKit/WebKit/commit/24a17225812f20be6217f8321cf1536999950781 Author: Alex Christensen Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/fast/encoding/idn-security-expected.txt M LayoutTests/fast/encoding/idn-security.html Log Message: ----------- Rebaseline IDN test for WK1 after 258404 at main https://bugs.webkit.org/show_bug.cgi?id=250083 rdar://103878160 Unreviewed. * LayoutTests/fast/encoding/idn-security-expected.txt: * LayoutTests/fast/encoding/idn-security.html: Canonical link: https://commits.webkit.org/258436 at main From noreply at github.com Wed Jan 4 10:34:30 2023 From: noreply at github.com (Don Olmstead) Date: Wed, 04 Jan 2023 10:34:30 -0800 Subject: [webkit-changes] [WebKit/WebKit] 851c25: [PlayStation] Fix build after 258431@main Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 851c257d391514dd3075e2dece9717f0d70a45c3 https://github.com/WebKit/WebKit/commit/851c257d391514dd3075e2dece9717f0d70a45c3 Author: Don Olmstead Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp Log Message: ----------- [PlayStation] Fix build after 258431 at main https://bugs.webkit.org/show_bug.cgi?id=250084 Unreviewed build fix. Update method signatures. * Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp: Canonical link: https://commits.webkit.org/258437 at main From noreply at github.com Wed Jan 4 10:43:01 2023 From: noreply at github.com (=?UTF-8?B?4q2QY2FpdHDirZA=?=) Date: Wed, 04 Jan 2023 10:43:01 -0800 Subject: [webkit-changes] [WebKit/WebKit] ea7efa: [JSC] Expose error messages from ShadowRealms to o... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ea7efa2f7f885f2dc5d0dea65d185fb9974cbf58 https://github.com/WebKit/WebKit/commit/ea7efa2f7f885f2dc5d0dea65d185fb9974cbf58 Author: Caitlin Potter Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M JSTests/stress/shadow-realm-evaluate.js M Source/JavaScriptCore/runtime/Error.cpp M Source/JavaScriptCore/runtime/Error.h M Source/JavaScriptCore/runtime/ShadowRealmPrototype.cpp Log Message: ----------- [JSC] Expose error messages from ShadowRealms to outer realm https://bugs.webkit.org/show_bug.cgi?id=249324 Reviewed by Yusuke Suzuki. This adds stuff from a yet unmerged spec change from https://github.com/tc39/proposal-shadowrealm/pull/382. This particular implementation only concerns itself with converting a primitive exception to a String and using that as the TypeError message, or else accessing the own "message" property of an object and using that, which is sufficient to inherit messages from a native Error. A more robust approach could attempt to load "message" from the prototype chain, and could incorporate some limited source information from the source error into the new error message. Canonical link: https://commits.webkit.org/258438 at main From noreply at github.com Wed Jan 4 10:45:53 2023 From: noreply at github.com (Dean Jackson) Date: Wed, 04 Jan 2023 10:45:53 -0800 Subject: [webkit-changes] [WebKit/WebKit] 60f0ca: Safari should pass current URL to ARQL when using ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60f0cac6d918171da9beae365f712a3ac1166bd1 https://github.com/WebKit/WebKit/commit/60f0cac6d918171da9beae365f712a3ac1166bd1 Author: Dean Jackson Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: ----------- Safari should pass current URL to ARQL when using ASVLaunchPreview https://bugs.webkit.org/show_bug.cgi?id=250056 rdar://103499310 Reviewed by Tim Horton. ARQL have updated the ASVLaunchPreview API to allow an originating URL. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/258439 at main From noreply at github.com Wed Jan 4 12:10:35 2023 From: noreply at github.com (Ryan Haddad) Date: Wed, 04 Jan 2023 12:10:35 -0800 Subject: [webkit-changes] [WebKit/WebKit] e581d8: [EWS] Adjust Big Sur bot allocation Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e581d875e971d99940aca8b214ba9e80259816c9 https://github.com/WebKit/WebKit/commit/e581d875e971d99940aca8b214ba9e80259816c9 Author: Ryan Haddad Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Tools/CISupport/ews-build/config.json Log Message: ----------- [EWS] Adjust Big Sur bot allocation https://bugs.webkit.org/show_bug.cgi?id=250087 rdar://problem/103880039 Reviewed by Alexey Proskuryakov. Adjust Big Sur bot allocation to ensure that 12-core machines are used for layout tests, and those with fewer cores are allocated to API tests. ews100: 6 core machine -> API tests, replaced by ews105 ews129: 8 core machine -> API tests, replaced by ews116 ews153: 4 core machine -> API tests, replaced by ews169 * Tools/CISupport/ews-build/config.json: Canonical link: https://commits.webkit.org/258440 at main From noreply at github.com Wed Jan 4 12:13:04 2023 From: noreply at github.com (Michael Saboff) Date: Wed, 04 Jan 2023 12:13:04 -0800 Subject: [webkit-changes] [WebKit/WebKit] cbde56: REGRESSION(257823@main): named-groups/lookbehind.j... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbde560aa655d9f1759f23336aa506ccaaef8ee2 https://github.com/WebKit/WebKit/commit/cbde560aa655d9f1759f23336aa506ccaaef8ee2 Author: Michael Saboff Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A JSTests/stress/regexp-lookaround-captures.js M Source/JavaScriptCore/yarr/YarrInterpreter.cpp M Source/JavaScriptCore/yarr/YarrInterpreter.h M Source/JavaScriptCore/yarr/YarrJIT.cpp M Source/JavaScriptCore/yarr/YarrParser.h M Source/JavaScriptCore/yarr/YarrPattern.cpp M Source/JavaScriptCore/yarr/YarrPattern.h M Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp M Source/WebCore/contentextensions/URLFilterParser.cpp Log Message: ----------- REGRESSION(257823 at main): named-groups/lookbehind.js Test262-test is failing https://bugs.webkit.org/show_bug.cgi?id=249330 rdar://103367993 Reviewed by Mark Lam. Relanding 258310 at main with a fix for the issue found in https://bugs.webkit.org/show_bug.cgi?id=249855. That issue was that we were hitting an ASSERT in clearSubpatternStart() where the subpatternId passed in was 0, which is the whole match start index and not a subpattern. The fix is to make sure that we always start with a subpatternId of no less than 1. This is handled in the new method PatternAlternative::firstCleanupSubpatternId(). Fixed the case where a nested capturing group within a lookahead / lookbehind doesn't get its capture cleared if the lookaround fails. This has been a long standing issue for lookaheads. The fix is slightly different in the Yarr interpreter than in the Yarr JIT. For the interpreter, the Parenthetical Assertion processing will clear the nested captures within the assertion for the case where an inverted assertion succeeds or a normal assertion fails. For the JIT, the clearing is done at the end of a failed top level alternative for all the contained captures for that alternative. Updated the test accordingly. * JSTests/stress/regexp-lookaround-captures.js: Added. (arrayToString): (dumpValue): (compareArray): (testRegExp): (testRegExp.c): * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::matchBackReference): (JSC::Yarr::Interpreter::backtrackBackReference): (JSC::Yarr::Interpreter::recordParenthesesMatch): (JSC::Yarr::Interpreter::resetMatches): (JSC::Yarr::Interpreter::matchParenthesesOnceBegin): (JSC::Yarr::Interpreter::matchParenthesesOnceEnd): (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin): (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd): (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd): (JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd): (JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd): (JSC::Yarr::ByteCompiler::emitDisjunction): (JSC::Yarr::ByteTermDumper::dumpTerm): * Source/JavaScriptCore/yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::containsAnyCaptures): (JSC::Yarr::ByteTerm::subpatternId): (JSC::Yarr::ByteTerm::lastSubpatternId): * Source/JavaScriptCore/yarr/YarrJIT.cpp: * Source/JavaScriptCore/yarr/YarrParser.h: (JSC::Yarr::Parser::parseTokens): * Source/JavaScriptCore/yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin): (JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin): (JSC::Yarr::YarrPatternConstructor::copyDisjunction): (JSC::Yarr::YarrPatternConstructor::disjunction): * Source/JavaScriptCore/yarr/YarrPattern.h: (JSC::Yarr::PatternTerm::containsAnyCaptures): (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::needToCleanupCaptures const): (JSC::Yarr::PatternAlternative::firstCleanupSubpatternId): (JSC::Yarr::PatternDisjunction::addNewAlternative): * Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp: (JSC::Yarr::SyntaxChecker::disjunction): * Source/WebCore/contentextensions/URLFilterParser.cpp: (WebCore::ContentExtensions::PatternParser::disjunction): Canonical link: https://commits.webkit.org/258441 at main From noreply at github.com Wed Jan 4 12:23:26 2023 From: noreply at github.com (Don Olmstead) Date: Wed, 04 Jan 2023 12:23:26 -0800 Subject: [webkit-changes] [WebKit/WebKit] 849890: [CMake] Add PlayStation system module variable Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84989015fa0501b84a8582897384612bf3fca346 https://github.com/WebKit/WebKit/commit/84989015fa0501b84a8582897384612bf3fca346 Author: Don Olmstead Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: ----------- [CMake] Add PlayStation system module variable https://bugs.webkit.org/show_bug.cgi?id=250085 Reviewed by Fujii Hironori. Exposes the `_IS_SYSMODULE` value from `playstation_module` to `cmakeconfig.h` so it can be used in the build. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/258442 at main From noreply at github.com Wed Jan 4 12:30:47 2023 From: noreply at github.com (Cameron McCormack) Date: Wed, 04 Jan 2023 12:30:47 -0800 Subject: [webkit-changes] [WebKit/WebKit] db0ade: Call FontCache::invalidate under memory pressure Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db0ade3c62fb2c65e7b2b1a8060b886981ded622 https://github.com/WebKit/WebKit/commit/db0ade3c62fb2c65e7b2b1a8060b886981ded622 Author: Cameron McCormack Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Log Message: ----------- Call FontCache::invalidate under memory pressure https://bugs.webkit.org/show_bug.cgi?id=249561 rdar://103498661 Reviewed by Myles C. Maxfield. The changes in bug 234061 caused us not to call FontCache::invalidate under memory pressure, which we should do, since it clears some data that the current platformReleaseNoncriticalMemory does not do. The two things that are done -- clearing m_systemFontDatabaseCoreText and m_fontFamilySpecificationCoreTextCache -- are also done by invalidate(), so we can replace them with an invalidate() call. * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::platformReleaseNoncriticalMemory): Canonical link: https://commits.webkit.org/258443 at main From noreply at github.com Wed Jan 4 12:40:57 2023 From: noreply at github.com (Brandon Stewart) Date: Wed, 04 Jan 2023 12:40:57 -0800 Subject: [webkit-changes] [WebKit/WebKit] 941d50: Align Masonry Track Sizing Tests with WPT Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 941d50ec8f2c74a2c2007458f33638914ef683f2 https://github.com/WebKit/WebKit/commit/941d50ec8f2c74a2c2007458f33638914ef683f2 Author: Brandon Stewart Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html Log Message: ----------- Align Masonry Track Sizing Tests with WPT https://bugs.webkit.org/show_bug.cgi?id=250098 Reviewed by Tim Nguyen. Had to make several small whitespace changes and a small ref fix up when exporting to the WPT repo. * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html: Canonical link: https://commits.webkit.org/258444 at main From noreply at github.com Wed Jan 4 12:58:41 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 12:58:41 -0800 Subject: [webkit-changes] [WebKit/WebKit] e05300: Remove HTMLPreElement.wrap IDL attribute Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e05300060c5ebc3284080412f900403d9be5075a https://github.com/WebKit/WebKit/commit/e05300060c5ebc3284080412f900403d9be5075a Author: Ahmad Saleem Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/fast/dom/boolean-attribute-reflection-expected.txt M LayoutTests/fast/dom/boolean-attribute-reflection.html M Source/WebCore/html/HTMLPreElement.idl Log Message: ----------- Remove HTMLPreElement.wrap IDL attribute Remove HTMLPreElement.wrap IDL attribute https://bugs.webkit.org/show_bug.cgi?id=249965 Reviewed by Alexey Shvayka. This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and web-specification. Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=179131 This patch remove "wrap" from IDL file of the "Pre" element and align WebKit with web standards. It was removed from Blink in 2014. * Source/WebCore/html/HTMLPreElement.idl: Remove 'wrap' * LayoutTests/fast/dom/boolean-attribute-reflection.html: Rebaselined * LayoutTests/fast/dom/boolean-attribute-reflection-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/258445 at main From noreply at github.com Wed Jan 4 13:31:22 2023 From: noreply at github.com (=?UTF-8?B?xb1hbiBEb2JlcsWhZWs=?=) Date: Wed, 04 Jan 2023 13:31:22 -0800 Subject: [webkit-changes] [WebKit/WebKit] b41ac5: StringConcatenate's StringTypeAdapter... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b41ac5266fe96d75848e7de585dc61d6b29d261c https://github.com/WebKit/WebKit/commit/b41ac5266fe96d75848e7de585dc61d6b29d261c Author: ?an Dober?ek Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WTF/wtf/text/StringConcatenate.h M Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp Log Message: ----------- StringConcatenate's StringTypeAdapter> incorrectly writes into a 16-bit destination https://bugs.webkit.org/show_bug.cgi?id=250070 Reviewed by Sam Weinig. When StringTypeAdapter> writes into any destination string, the offset value shouldn't be multiplied by the size of the string's character type. Pointer arithmetic will take care of that on its own. Test case in the StringConcatenate suite is provided, covering both 8-bit and 16-bit strings constructed partially or completely from a tuple object. The StringTypeAdapter specialization is also adjusted to only keep a reference to the tuple object, and not copy it. Passes over the tuple elements are done with lambdas that take arguments through const lvalue references, avoiding any copying of the contained elements. * Source/WTF/wtf/text/StringConcatenate.h: (WTF::StringTypeAdapter Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54dd46449a7308573361679a9c5a0f37c7a771e7 https://github.com/WebKit/WebKit/commit/54dd46449a7308573361679a9c5a0f37c7a771e7 Author: Chris Dumez Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html Log Message: ----------- Fix css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html WPT test https://bugs.webkit.org/show_bug.cgi?id=250049 Reviewed by Tim Nguyen. Fix css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html WPT test so that it expects "normal" as computed value when the input is a length that is zero, as per: - https://w3c.github.io/csswg-drafts/css-text/#letter-spacing-property """ For legacy reasons, a computed letter-spacing of zero yields a resolved value (getComputedStyle() return value) of normal. """ * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html: Canonical link: https://commits.webkit.org/258447 at main From noreply at github.com Wed Jan 4 13:46:11 2023 From: noreply at github.com (Elliott Williams) Date: Wed, 04 Jan 2023 13:46:11 -0800 Subject: [webkit-changes] [WebKit/WebKit] 9def6e: Generate web preferences using feature status taxo... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9def6e6f0258ddd9171d32bec2fffb684dbc7b8b https://github.com/WebKit/WebKit/commit/9def6e6f0258ddd9171d32bec2fffb684dbc7b8b Author: Elliott Williams Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/css-custom-properties-api/initialValue.html M LayoutTests/fast/css-custom-paint/properties.html M LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html M LayoutTests/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html M LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html M LayoutTests/highlight/highlight-world-leak.html M LayoutTests/http/tests/clear-site-data/bfcache.html M LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html M LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html M LayoutTests/media/vp9.html M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/webgl/webgl-draft-extensions-flag-default.html M LayoutTests/webrtc/video-av1.html M LayoutTests/webrtc/vp9-vtb.html M Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_packet/remote_estimate.h M Source/WTF/Scripts/GeneratePreferences.rb A Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml R Source/WTF/Scripts/Preferences/WebPreferences.yaml R Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml R Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml R Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/WebCoreMacros.cmake M Source/WebCore/page/Settings.yaml M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/WebPreferences.h M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/PlatformWin.cmake M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb M Source/WebKitLegacy/mac/Scripts/generate-preferences.sh M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h M Tools/DumpRenderTree/CMakeLists.txt M Tools/DumpRenderTree/DerivedSources-input.xcfilelist M Tools/DumpRenderTree/DerivedSources.make M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm M Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm M Tools/WebKitTestRunner/CMakeLists.txt M Tools/WebKitTestRunner/DerivedSources-input.xcfilelist M Tools/WebKitTestRunner/DerivedSources.make Log Message: ----------- Generate web preferences using feature status taxonomy https://bugs.webkit.org/show_bug.cgi?id=247926 rdar://92112770 Reviewed by Brent Fulgham. Merge WebPreferences*.yaml into UnifiedWebPreferences.yaml. Insteading of using different preference files to distinguish between experimental features, internal features, and debug preferences, each preference has a `status` field that determines where it ends up. The status field was introduced as WebKit::API::FeatureStatus in https://commits.webkit.org/257166 at main, and current statuses were generated by surveying Safari/WebKit contributors at Apple. Feature status determines whether a preference is ephemeral, or backed by persistent storage. It currently determines which of the preexisting experimental / internal debug API declarations a preference appears in. Future work will expose a new interface for clients to see *all* exposed features, grouping them by status, and will replace the preexisting ExperimentalFeatures/InternalDebugFeatures listings with views onto the main list. * Source/WTF/Scripts/GeneratePreferences.rb: - Remove the base/debug/experimental/internal distinctions, and just parse an arbitrary list of preference files. - Parse feature statuses, and add methods for preference templates to query them. - Add support for automatically static_casting enum preferences to their unrefined type. It's still not possible for a UI-visible feature to be anything other than a boolean toggle, which limits the features that can be marked as "internal", "developer", "testable", "preview", and "stable". - Small quality of life changes, such as the ability to output _all_ the parse errors in a single run of the generator script. * Source/WTF/Scripts/Preferences/WebPreferences.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Removed. * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Added. Make some fixes and status changes to the initial version of this file generated from the survey. The main categories of fixes are: - Any preference which can be exposed in UI (including "internal" features) needs a human-readable name. - Any preference exposed beyond WebCore needs defaults values for WebKit and WebKitLegacy. - Preferences with "custom" bindings that were merely static_casts now use the automatic static_cast support provided by the generator script. - Non-boolean preferences can't be exposed as an "experimental" or "internal debug" feature yet. For now, these are reclassified as "embedder" preferences. As a test fixup: Service workers are not implemented for WebKitLegacy, and ServiceWorkersEnabled's new status of "developer" was causing the setting to be errantly turned on in DumpRenderTree. There's no reason for this flag to be exposed at all in WKL, so hide it. * Source/WTF/WTF.xcodeproj/project.pbxproj: Update file references. * Source/WTF/wtf/CMakeLists.txt: Update file references. * Source/WebCore/CMakeLists.txt: Update GenerateSettings.rb invocation. Inline the settings macro since this is the only place we use it. * Source/WebCore/DerivedSources-input.xcfilelist: Update file references. * Source/WebCore/DerivedSources.make: Update file references and GenerateSettings.rb invocation. * Source/WebCore/Scripts/GenerateSettings.rb: Update to consume the unified preferences file. The WebCore-only Settings.yaml still hosts non-feature settings. These don't need a status assigned to them; WebCore::Settings doesn't use the feature status field and these are never exposed in API (if they were, we'd probably consider them all "embedder settings"). * Source/WebCore/WebCoreMacros.cmake: Remove settings macro, no longer used. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Update file references. * Source/WebKit/CMakeLists.txt: Update GenerateSettings.rb invocation. * Source/WebKit/DerivedSources-input.xcfilelist: Update file references. * Source/WebKit/DerivedSources.make: Update file references and GenerateSettings.rb invocation. * Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb: Automatic static_casting. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Replace "Internal Debug" and "Experimental" classifications with status-based categories. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb: Use statuses to determine what constitutes an "experimental feature". * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesGetterSetters.cpp.erb: Enumerate the entire list of exposed preferences. Instead of calling special updateBoolValueForFeatureKey functions for experimental or internal-debug features, pass an "ephemeral?" flag into the main updateValueForKey which determines whether the update should be persisted into user defaults. * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb: Use statuses to determine what constitutes an "internal debug" feature. * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: Pass an "ephemeral" flag to set*ValueforKey. To match existing behavior, layout testing overrides are set as non-ephemeral. They don't actually cause user defaults writes, because the WebPreferences instance used by layout tests is non-persistent (doesn't have an identifier). (WKPreferencesSetBoolValueForKeyForTesting): (WKPreferencesSetDoubleValueForKeyForTesting): (WKPreferencesSetUInt32ValueForKeyForTesting): (WKPreferencesSetStringValueForKeyForTesting): * Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm: (WebKit::WebPreferences::platformInitializeStore): Adopt new macro names. (WebKit::setDebugUInt32ValueIfInUserDefaults): Deleted because no persisted preferences use uint32_t values. * Source/WebKit/UIProcess/WebPreferences.cpp: Instead of calling special updateBoolValueForFeatureKey functions for experimental or internal-debug features, update the main set/updateValueForKey methods to take an "ephemeral?" flag which determines whether the update should be persisted into user defaults. (WebKit::WebPreferences::setBoolValueForKey): (WebKit::WebPreferences::setDoubleValueForKey): (WebKit::WebPreferences::setUInt32ValueForKey): (WebKit::WebPreferences::setStringValueForKey): (WebKit::WebPreferences::updateStringValueForKey): (WebKit::WebPreferences::updateBoolValueForKey): (WebKit::WebPreferences::updateUInt32ValueForKey): (WebKit::WebPreferences::updateDoubleValueForKey): (WebKit::WebPreferences::updateFloatValueForKey): (WebKit::WebPreferences::updateBoolValueForInternalDebugFeatureKey): Deleted. (WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey): Deleted. * Source/WebKit/UIProcess/WebPreferences.h: Ditto above changes. * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: Update file references. * Source/WebKitLegacy/PlatformMac.cmake: Update GeneratePreferences.rb invocation. * Source/WebKitLegacy/PlatformWin.cmake: Ditto. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: Use statuses. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: Use statuses. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb: Support automatic static_casting. * Source/WebKitLegacy/mac/Scripts/generate-preferences.sh: Update GeneratePreferences.rb invocation. * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h: Add include statement needed for static_casting. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_packet/remote_estimate.h: An added import revealed a macro name collision in unified sources on some versions of macOS. Fix by #undef-ing the unneeded macro. In TestWebKitAPI, many API tests set features by searching +[WKPreferences _experimentalFeatures] and +[WKPreferences _internalDebugFeatures] for a matching key. This is frustratingly brittle, and because many features are being removed from the "experimental" UI, these search sites must be updated. * Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: * Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: (TestWebKitAPI::TEST): * Tools/DumpRenderTree/DerivedSources-input.xcfilelist: Update file references. * Tools/DumpRenderTree/DerivedSources.make: Update GeneratePreferences.rb invocation. * Tools/WebKitTestRunner/DerivedSources-input.xcfilelist: Ditto. * Tools/WebKitTestRunner/DerivedSources.make: Ditto. Update some layout test baselines, and modify some tests to enable a feature flag that they depend on which was previously in Experimental Features (and therefore on by default). Going forward, features in the "testable" status or one of the developer-facing statuses ("developer", "preview", "stable") are enabled during layout testing. * LayoutTests/css-custom-properties-api/initialValue.html: * LayoutTests/fast/css-custom-paint/properties.html: * LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html: * LayoutTests/fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html: * LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html: * LayoutTests/highlight/highlight-world-leak.html: * LayoutTests/http/tests/clear-site-data/bfcache.html: * LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html: * LayoutTests/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html: * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html: * LayoutTests/media/vp9.html: * LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-default.html: * LayoutTests/webrtc/video-av1.html: * LayoutTests/webrtc/vp9-vtb.html: Canonical link: https://commits.webkit.org/258448 at main From noreply at github.com Wed Jan 4 14:27:01 2023 From: noreply at github.com (Ryan Haddad) Date: Wed, 04 Jan 2023 14:27:01 -0800 Subject: [webkit-changes] [WebKit/WebKit] dac9d8: Add JC Alvarado to contributors.json Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dac9d8635b73ece1b6c917d019accd1921e78745 https://github.com/WebKit/WebKit/commit/dac9d8635b73ece1b6c917d019accd1921e78745 Author: Ryan Haddad Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M metadata/contributors.json Log Message: ----------- Add JC Alvarado to contributors.json https://bugs.webkit.org/show_bug.cgi?id=250090 rdar://103882126 Reviewed by David Kilzer. * metadata/contributors.json: Canonical link: https://commits.webkit.org/258449 at main From noreply at github.com Wed Jan 4 14:34:04 2023 From: noreply at github.com (Commit Queue) Date: Wed, 04 Jan 2023 14:34:04 -0800 Subject: [webkit-changes] [WebKit/WebKit] cc929d: REGRESSION (246550@main): WKFoundTextRange leaks a... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc929d954b702158123dc651efe17215bf781808 https://github.com/WebKit/WebKit/commit/cc929d954b702158123dc651efe17215bf781808 Author: David Kilzer Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: ----------- REGRESSION (246550 at main): WKFoundTextRange leaks an NSString https://bugs.webkit.org/show_bug.cgi?id=250078 Reviewed by Chris Dumez. Fix leak caused by missing -dealloc method. Found by clang static analyzer. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKFoundTextRange dealloc]): Add. - Release _frameIdentifier to fix the leak. Canonical link: https://commits.webkit.org/258450 at main From noreply at github.com Wed Jan 4 14:40:55 2023 From: noreply at github.com (Richard Robinson) Date: Wed, 04 Jan 2023 14:40:55 -0800 Subject: [webkit-changes] [WebKit/WebKit] 196914: Build failure: WebCore/PAL/pal/spi/cocoa/PassKitSP... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 196914de45204a3f1932534db4532aaad701898b https://github.com/WebKit/WebKit/commit/196914de45204a3f1932534db4532aaad701898b Author: Richard Robinson Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm Log Message: ----------- Build failure: WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:147:9: fatal error: 'PassKitMacHelper/PKPaymentAuthorizationViewController_Private.h' file not found https://bugs.webkit.org/show_bug.cgi?id=250086 rdar://103832563 Reviewed by Megan Gardner. Build fix. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm: * Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h: * Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments): (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Canonical link: https://commits.webkit.org/258451 at main From noreply at github.com Wed Jan 4 14:47:42 2023 From: noreply at github.com (Alan Coon) Date: Wed, 04 Jan 2023 14:47:42 -0800 Subject: [webkit-changes] [WebKit/WebKit] e7d4ea: Versioning. Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: e7d4ea5a0354d0493219e3c48fc1fe4330ef5309 https://github.com/WebKit/WebKit/commit/e7d4ea5a0354d0493219e3c48fc1fe4330ef5309 Author: Alan Coon Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7615.1.16.3 Canonical link: https://commits.webkit.org/257979.12 at safari-7615.1.16-branch From noreply at github.com Wed Jan 4 14:49:12 2023 From: noreply at github.com (Per Arne Vollan) Date: Wed, 04 Jan 2023 14:49:12 -0800 Subject: [webkit-changes] [WebKit/WebKit] 073a2d: Cherry-pick 8c5dd8c31d25. rdar://problem/103764832 Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: 073a2dd2ff00eb9b617ba11847f14d92f907c927 https://github.com/WebKit/WebKit/commit/073a2dd2ff00eb9b617ba11847f14d92f907c927 Author: Per Arne Vollan Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/Shared/Sandbox/common.sb Log Message: ----------- Cherry-pick 8c5dd8c31d25. rdar://problem/103764832 Initially allow syscall mach in sandbox v3 https://bugs.webkit.org/show_bug.cgi?id=250051 rdar://103764832 Reviewed by Brent Fulgham. Initially allow syscall mach in sandbox v3, since it was allowed in v1. Individual sandboxes will deny mach syscalls. * Source/WebKit/Shared/Sandbox/common.sb: Canonical link: https://commits.webkit.org/258411 at main Canonical link: https://commits.webkit.org/257979.13 at safari-7615.1.16-branch From noreply at github.com Wed Jan 4 14:50:44 2023 From: noreply at github.com (Alan Coon) Date: Wed, 04 Jan 2023 14:50:44 -0800 Subject: [webkit-changes] [WebKit/WebKit] Message-ID: Branch: refs/tags/WebKit-7615.1.16.3 Home: https://github.com/WebKit/WebKit From noreply at github.com Wed Jan 4 15:01:42 2023 From: noreply at github.com (Tim Horton) Date: Wed, 04 Jan 2023 15:01:42 -0800 Subject: [webkit-changes] [WebKit/WebKit] 5e0958: Minimum effective device width changes made during... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e095859bb52ed952a47f2f09b3a1b25445304a0 https://github.com/WebKit/WebKit/commit/5e095859bb52ed952a47f2f09b3a1b25445304a0 Author: Tim Horton Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm Log Message: ----------- Minimum effective device width changes made during live-ish resize take effect immediately https://bugs.webkit.org/show_bug.cgi?id=250097 rdar://103884357 Reviewed by Wenson Hsieh and Dean Jackson. While in live-ish resize, layout parameter changes are supposed to be deferred until the resize completes. However, eb491a86 missed deferring minimumEffectiveDeviceWidth changes. Expose _shouldDeferGeometryUpdates internally and use that to defer mEDW changes. Also ensure that we actually dispatch mEDW changes once the resize completes, even if the view layout size didn't change. Add a test that ensures that this all works. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setMinimumEffectiveDeviceWidth:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _dispatchSetViewLayoutSize:]): (-[WKWebView _didStopDeferringGeometryUpdates]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm: (TEST): Canonical link: https://commits.webkit.org/258452 at main From noreply at github.com Wed Jan 4 15:14:26 2023 From: noreply at github.com (Said Abou-Hallawa) Date: Wed, 04 Jan 2023 15:14:26 -0800 Subject: [webkit-changes] [WebKit/WebKit] f9b389: [GPU Process] [FormControls] Add ControlPart for M... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9b389be95cc3dc8143bbedd82fd530a1f2bcaaf https://github.com/WebKit/WebKit/commit/f9b389be95cc3dc8143bbedd82fd530a1f2bcaaf Author: Said Abou-Hallawa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/controls/ControlFactory.h A Source/WebCore/platform/graphics/controls/MenuListPart.h M Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlMac.h M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm A Source/WebCore/platform/graphics/mac/controls/MenuListMac.h A Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp Log Message: ----------- [GPU Process] [FormControls] Add ControlPart for MenuList https://bugs.webkit.org/show_bug.cgi?id=249978 rdar://103795005 Reviewed by Aditya Keerthi. This ControlPart will handle drawing the MenuList form control (i.e. ). For macOS, AppKit will be used to draw the platform control. * Source/WebCore/Headers.cmake: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/controls/ControlFactory.h: * Source/WebCore/platform/graphics/controls/MenuListPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm: (WebCore::ButtonControlMac::updateCellStates): * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm: (WebCore::ControlFactoryMac::checkboxCell const): (WebCore::ControlFactoryMac::radioCell const): (WebCore::ControlFactoryMac::levelIndicatorCell const): (WebCore::ControlFactoryMac::popUpButtonCell const): (WebCore::ControlFactoryMac::createPlatformMenuList): * Source/WebCore/platform/graphics/mac/controls/ControlMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlMac.mm: (WebCore::ControlMac::updateCheckedState): (WebCore::ControlMac::updateEnabledState): (WebCore::ControlMac::updateFocusedState): (WebCore::ControlMac::updatePressedState): * Source/WebCore/platform/graphics/mac/controls/MenuListMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm: Added. (WebCore::MenuListMac::MenuListMac): (WebCore::MenuListMac::cellSize const): (WebCore::MenuListMac::cellOutsets const): (WebCore::MenuListMac::updateCellStates): (WebCore::MenuListMac::rectForBounds const): (WebCore::MenuListMac::draw): * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::createControlPart const): * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::canPaint const): (WebCore::RenderThemeMac::canCreateControlPartForRenderer const): (WebCore::RenderThemeMac::paintMenuList): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::decode): Canonical link: https://commits.webkit.org/258453 at main From noreply at github.com Wed Jan 4 15:20:34 2023 From: noreply at github.com (Ryosuke Niwa) Date: Wed, 04 Jan 2023 15:20:34 -0800 Subject: [webkit-changes] [WebKit/WebKit] 91d6b0: [Live Range Selection] editing/execCommand/apply-i... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91d6b05b3aafd86d011f5b02cdb8386aff076a8c https://github.com/WebKit/WebKit/commit/91d6b05b3aafd86d011f5b02cdb8386aff076a8c Author: Ryosuke Niwa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html Log Message: ----------- [Live Range Selection] editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html fails https://bugs.webkit.org/show_bug.cgi?id=250089 Reviewed by Wenson Hsieh. The failure was caused by an invalid call to setBaseAndExtent with null as end container. Fixed the test by specifying input element for both start & end. * LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html: Canonical link: https://commits.webkit.org/258454 at main From noreply at github.com Wed Jan 4 16:07:45 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 16:07:45 -0800 Subject: [webkit-changes] [WebKit/WebKit] 919ed0: [JSC] Add SensitiveToNaN flag to B3 Kind Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 919ed00f75d8752cddfdacb59d286f1fc168a307 https://github.com/WebKit/WebKit/commit/919ed00f75d8752cddfdacb59d286f1fc168a307 Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M JSTests/wasm/spec-tests/float_exprs.wast.js M Source/JavaScriptCore/b3/B3Kind.cpp M Source/JavaScriptCore/b3/B3Kind.h M Source/JavaScriptCore/b3/B3ReduceStrength.cpp M Source/JavaScriptCore/b3/B3Value.h M Source/JavaScriptCore/wasm/generateWasmB3IRGeneratorInlinesHeader.py Log Message: ----------- [JSC] Add SensitiveToNaN flag to B3 Kind https://bugs.webkit.org/show_bug.cgi?id=249991 rdar://103807651 Reviewed by Saam Barati. This patch adds SensitiveToNaN flag to B3 Kind. This means "The B3 Value is sensitive to NaN bit pattern", and it supresses some of strength reduction which can be observable as a NaN bit pattern difference. >From JS, this flag is always false since JS does not care about NaN bit pattern. On the other hand, Wasm cares. In B3 Wasm IR generator, we put this flag to Wasm generated B3 Values. This makes float spec-tests pass by 100%. * JSTests/wasm/spec-tests/float_exprs.wast.js: * Source/JavaScriptCore/b3/B3Kind.cpp: (JSC::B3::Kind::dump const): * Source/JavaScriptCore/b3/B3Kind.h: (JSC::B3::Kind::Kind): (JSC::B3::Kind::hasSensitiveToNaN): (JSC::B3::Kind::hasSensitiveToNaN const): (JSC::B3::Kind::sensitiveToNaN const): (JSC::B3::Kind::setSensitiveToNaN): (JSC::B3::Kind::operator== const): (JSC::B3::Kind::hash const): (JSC::B3::sensitiveToNaN): * Source/JavaScriptCore/b3/B3ReduceStrength.cpp: * Source/JavaScriptCore/b3/B3Value.h: * Source/JavaScriptCore/wasm/generateWasmB3IRGeneratorInlinesHeader.py: (CodeGenerator.generateB3OpCode): (CodeGenerator): (CodeGenerator.generateConstCode): (CodeGenerator.generateOpcode): (CodeGenerator.makeResult): (CodeGenerator.generate): (temp): (generateB3OpCode): Deleted. (generateConstCode): Deleted. Canonical link: https://commits.webkit.org/258455 at main From noreply at github.com Wed Jan 4 16:09:24 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 16:09:24 -0800 Subject: [webkit-changes] [WebKit/WebKit] 25d391: Shrink isValidNameNonASCII by using U16_NEXT only ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25d3919907b85d9829ff1a940b29f72fa3332365 https://github.com/WebKit/WebKit/commit/25d3919907b85d9829ff1a940b29f72fa3332365 Author: Ahmad Saleem Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/dom/Document.cpp Log Message: ----------- Shrink isValidNameNonASCII by using U16_NEXT only once Shrink isValidNameNonASCII by using U16_NEXT only once https://bugs.webkit.org/show_bug.cgi?id=249913 Reviewed by Ryosuke Niwa. Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=182236 This patch is to optimize the usage of "U16_NEXT" macro to once rather than twice leading to shrinkage in symbols across various compilers (e.g., Clang). * Source/WebCore/dom/Document.cpp: (isValidNameNonASCII): Optimize to use "U16_NEXT" once Canonical link: https://commits.webkit.org/258456 at main From noreply at github.com Wed Jan 4 16:30:34 2023 From: noreply at github.com (MyahCobbs) Date: Wed, 04 Jan 2023 16:30:34 -0800 Subject: [webkit-changes] [WebKit/WebKit] 962d6c: Versioning. Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: 962d6c0c7b605ac4c006f0b913ab2947b99df779 https://github.com/WebKit/WebKit/commit/962d6c0c7b605ac4c006f0b913ab2947b99df779 Author: Myah Cobbs Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7615.1.16.4 Canonical link: https://commits.webkit.org/257979.14 at safari-7615.1.16-branch From noreply at github.com Wed Jan 4 16:32:57 2023 From: noreply at github.com (Richard Robinson) Date: Wed, 04 Jan 2023 16:32:57 -0800 Subject: [webkit-changes] [WebKit/WebKit] e5eefd: Cherry-pick 196914de4520. rdar://problem/103832563 Message-ID: Branch: refs/heads/safari-7615.1.16-branch Home: https://github.com/WebKit/WebKit Commit: e5eefd2ed790c26c9a8622cd30f279e71be47875 https://github.com/WebKit/WebKit/commit/e5eefd2ed790c26c9a8622cd30f279e71be47875 Author: Richard Robinson Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm Log Message: ----------- Cherry-pick 196914de4520. rdar://problem/103832563 Build failure: WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:147:9: fatal error: 'PassKitMacHelper/PKPaymentAuthorizationViewController_Private.h' file not found https://bugs.webkit.org/show_bug.cgi?id=250086 rdar://103832563 Reviewed by Megan Gardner. Build fix. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm: * Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h: * Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments): (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Canonical link: https://commits.webkit.org/258451 at main Canonical link: https://commits.webkit.org/257979.15 at safari-7615.1.16-branch From noreply at github.com Wed Jan 4 16:35:06 2023 From: noreply at github.com (mwyrzykowski) Date: Wed, 04 Jan 2023 16:35:06 -0800 Subject: [webkit-changes] [WebKit/WebKit] f11d85: Depth / stencil read only Message-ID: Branch: refs/heads/eng/WebGPU-Support-GPURenderPassDepthStencilAttachment-depthReadOnly Home: https://github.com/WebKit/WebKit Commit: f11d85c6a2dc7289bece17cccbe52a769d9a4673 https://github.com/WebKit/WebKit/commit/f11d85c6a2dc7289bece17cccbe52a769d9a4673 Author: Mike Wyrzykowski Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/RenderPipeline.h M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: ----------- Depth / stencil read only Need a short description (OOPS!). Need the bug URL (OOPS!). Include a Radar link (OOPS!). Reviewed by NOBODY (OOPS!). Explanation of why this fixes the bug (OOPS!). * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::beginRenderPass): * Source/WebGPU/WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::create): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): (WebGPU::RenderPassEncoder::setPipeline): * Source/WebGPU/WebGPU/RenderPipeline.h: (WebGPU::RenderPipeline::create): (WebGPU::RenderPipeline::depthStencilState const): Deleted. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): (WebGPU::RenderPipeline::RenderPipeline): (WebGPU::RenderPipeline::depthStencilState const): From noreply at github.com Wed Jan 4 16:35:53 2023 From: noreply at github.com (Sammy Gill) Date: Wed, 04 Jan 2023 16:35:53 -0800 Subject: [webkit-changes] [WebKit/WebKit] 6bd29f: Initial implementation margin-trim for block conta... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bd29f7cff747f7bb1c9965e4b08e52099f204ee https://github.com/WebKit/WebKit/commit/6bd29f7cff747f7bb1c9965e4b08e52099f204ee Author: Sammy Gill Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-non-adjoining-item-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-non-adjoining-item.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-end-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-end.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-start-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-start.html A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block.html M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h Log Message: ----------- Initial implementation margin-trim for block containers (without floats and margin collapsing). https://bugs.webkit.org/show_bug.cgi?id=249206 rdar://103285722 Reviewed by Alan Baradlay. Adds the initial logic for margin-trim support in block containers when there are no floats or collapsing margins. Support for both of these will be done in their own patches. A virtual method named shouldTrimChildMargin was added to help determine if a box's block start or block end margin should be trimmed. RenderBlockFlows defines its own version which checks a couple of things: 1.) That the box passed in is a block level box 2.) Whether the passed in MarginTrimType is set for the margin trim property and if the child is either the first in flow child box (for BlockStart) or the last in flow child box (for BlockEnd). Spec reference: https://drafts.csswg.org/css-box-4/#margin-trim-block * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-end-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-block-start-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-non-adjoining-item-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-non-adjoining-item.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-end-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-end.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-start-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block-start.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-replaced-block.html: Added. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::shouldTrimChildMargin const): * Source/WebCore/rendering/RenderBlockFlow.h: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeBlockDirectionMargins const): (WebCore::RenderBox::constrainBlockMarginInAvailableSpaceOrTrim const): * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::shouldTrimChildMargin const): Canonical link: https://commits.webkit.org/258457 at main From noreply at github.com Wed Jan 4 16:50:13 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 16:50:13 -0800 Subject: [webkit-changes] [WebKit/WebKit] 5b9714: [JSC] Remove Wasm FastTLS Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b971463eaad3a705207799ef68ab8dcb3ee9277 https://github.com/WebKit/WebKit/commit/5b971463eaad3a705207799ef68ab8dcb3ee9277 Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/JavaScriptCore/assembler/JITOperationList.cpp M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/llint/LLIntExceptions.cpp M Source/JavaScriptCore/llint/LLIntThunks.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/llint/WebAssembly.asm M Source/JavaScriptCore/runtime/Gate.h M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmContext.h M Source/JavaScriptCore/wasm/WasmContextInlines.h M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp M Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.h M Source/JavaScriptCore/wasm/js/JSToWasm.cpp M Source/JavaScriptCore/wasm/js/WasmToJS.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp M Tools/Scripts/run-jsc-stress-tests Log Message: ----------- [JSC] Remove Wasm FastTLS https://bugs.webkit.org/show_bug.cgi?id=249993 rdar://103809090 Reviewed by Saam Barati. This was originally introduced to make Wasm Position-Independent-Code (PIC). However, this is no longer meaningful. 1. At that time, we are embedding VM's pointer directly into Wasm's Module code. But this is no longer happening. So, without FastTLS, Wasm Module is already PIC. 2. Original patch was considering about serializing Wasm code into IndexedDB, but that proposal was now completely abandoned. 3. In super hot leaf function in OMG, FastTLS is unnecessarily emitting code to load instance while pinned-register version can eliminate this. So, pinned register version gets better code generation. 4. This makes OSS and Internal wasm call etc. the same since both just uses pinned registers. It also reduces # of variants of stress tests. This patch removes Wasm FastTLS and always use pinned registers. * Source/JavaScriptCore/assembler/JITOperationList.cpp: (JSC::llintOperations): * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::loadWasmContextInstance): (JSC::AssemblyHelpers::storeWasmContextInstance): (JSC::AssemblyHelpers::loadWasmContextInstanceNeedsMacroScratchRegister): (JSC::AssemblyHelpers::storeWasmContextInstanceNeedsMacroScratchRegister): * Source/JavaScriptCore/llint/LLIntExceptions.cpp: (JSC::LLInt::handleWasmCatch): (JSC::LLInt::handleWasmCatchAll): * Source/JavaScriptCore/llint/LLIntThunks.cpp: (JSC::LLInt::wasmFunctionEntryThunk): (JSC::LLInt::wasmFunctionEntryThunkSIMD): (JSC::LLInt::handleWasmCatchThunk): (JSC::LLInt::handleWasmCatchAllThunk): * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/runtime/Gate.h: * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::restoreWasmContextInstance): (JSC::Wasm::ExpressionType>::AirIRGeneratorBase): (JSC::Wasm::ExpressionType>::finalizeEntrypoints): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::restoreWasmContextInstance): (JSC::Wasm::B3IRGenerator::B3IRGenerator): * Source/JavaScriptCore/wasm/WasmContext.h: (JSC::Wasm::Context::pointerToInstance): * Source/JavaScriptCore/wasm/WasmContextInlines.h: (JSC::Wasm::Context::load const): (JSC::Wasm::Context::store): (JSC::Wasm::Context::tryLoadInstanceFromTLS): (JSC::Wasm::Context::useFastTLS): Deleted. * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::trapHandler): * Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::addCatchToUnreachable): (JSC::Wasm::LLIntGenerator::addCatchAllToUnreachable): (JSC::Wasm::LLIntGenerator::addCall): (JSC::Wasm::LLIntGenerator::addCallIndirect): (JSC::Wasm::LLIntGenerator::addCallRef): * Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): * Source/JavaScriptCore/wasm/WasmSlowPaths.h: * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::marshallJSResult): (JSC::Wasm::createJSToWasmWrapper): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::WebAssemblyFunction::jsCallEntrypointSlow): * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/258458 at main From noreply at github.com Wed Jan 4 16:53:53 2023 From: noreply at github.com (Chris Dumez) Date: Wed, 04 Jan 2023 16:53:53 -0800 Subject: [webkit-changes] [WebKit/WebKit] 6c1084: Import gamepad WPT tests from upstream Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c1084bf9558426dbb87059b80975d81c8a20e73 https://github.com/WebKit/WebKit/commit/6c1084bf9558426dbb87059b80975d81c8a20e73 Author: Chris Dumez Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/gamepad/META.yml A LayoutTests/imported/w3c/web-platform-tests/gamepad/feature-policy-gamepad.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-default-feature-policy.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-default-feature-policy.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-secure-context-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-secure-context.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-supported-by-feature-policy-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-supported-by-feature-policy.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window.js A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window.js A LayoutTests/imported/w3c/web-platform-tests/gamepad/not-fully-active.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/gamepad/not-fully-active.https.html A LayoutTests/imported/w3c/web-platform-tests/gamepad/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/interfaces/gamepad-extensions.idl M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/win/TestExpectations M LayoutTests/platform/wincairo/TestExpectations Log Message: ----------- Import gamepad WPT tests from upstream https://bugs.webkit.org/show_bug.cgi?id=250082 Reviewed by Tim Nguyen. Import gamepad WPT tests from upstream bd8dccefee3fa91fecefc6. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/gamepad/META.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/feature-policy-gamepad.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-default-feature-policy.https.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-default-feature-policy.https.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-secure-context-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-secure-context.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-supported-by-feature-policy-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/gamepad-supported-by-feature-policy.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window.js: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness.https.window.js: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/not-fully-active.https-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/not-fully-active.https.html: Added. * LayoutTests/imported/w3c/web-platform-tests/gamepad/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/interfaces/gamepad-extensions.idl: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/win/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/258459 at main From noreply at github.com Wed Jan 4 16:56:51 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 16:56:51 -0800 Subject: [webkit-changes] [WebKit/WebKit] 65807a: [JSC] Embed globals into Wasm::Instance directly Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65807af2d4b48ae08d50fe973c6896507ebda5fb https://github.com/WebKit/WebKit/commit/65807af2d4b48ae08d50fe973c6896507ebda5fb Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmInstance.cpp M Source/JavaScriptCore/wasm/WasmInstance.h M Source/JavaScriptCore/wasm/WasmModuleInformation.h Log Message: ----------- [JSC] Embed globals into Wasm::Instance directly https://bugs.webkit.org/show_bug.cgi?id=250027 rdar://103836165 Reviewed by Saam Barati. This patch embeds globals into Wasm::Instance instead of separately holding it. By doing so, we can remove one-level indirect load for GetGlobal / SetGlobal in BBQ and OMG tiers. To keep LLInt efficiencly, we keep m_globals pointer which points to Wasm::Instance's globals array. * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::getGlobal): (JSC::Wasm::ExpressionType>::setGlobal): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::getGlobal): (JSC::Wasm::B3IRGenerator::setGlobal): * Source/JavaScriptCore/wasm/WasmInstance.cpp: (JSC::Wasm::Instance::Instance): (JSC::Wasm::Instance::create): (JSC::Wasm::Instance::extraMemoryAllocated const): (JSC::Wasm::Instance::setGlobal): (JSC::Wasm::Instance::linkGlobal): (): Deleted. (JSC::Wasm::Instance::~Instance): Deleted. * Source/JavaScriptCore/wasm/WasmInstance.h: (JSC::Wasm::Instance::loadI32Global const): (JSC::Wasm::Instance::loadI64Global const): (JSC::Wasm::Instance::setGlobal): (JSC::Wasm::Instance::loadV128Global const): (JSC::Wasm::Instance::getGlobalBinding): (JSC::Wasm::Instance::offsetOfGlobalPtr): (JSC::Wasm::Instance::allocationSize): * Source/JavaScriptCore/wasm/WasmModuleInformation.h: (JSC::Wasm::ModuleInformation::globalCount const): Canonical link: https://commits.webkit.org/258460 at main From noreply at github.com Wed Jan 4 17:04:28 2023 From: noreply at github.com (Richard Robinson) Date: Wed, 04 Jan 2023 17:04:28 -0800 Subject: [webkit-changes] [WebKit/WebKit] 767b13: Cherry-pick 196914de4520. rdar://problem/103832563 Message-ID: Branch: refs/heads/safari-7615.1.17-branch Home: https://github.com/WebKit/WebKit Commit: 767b1321bd1176b6a90d894797b902bfa190473f https://github.com/WebKit/WebKit/commit/767b1321bd1176b6a90d894797b902bfa190473f Author: Richard Robinson Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm Log Message: ----------- Cherry-pick 196914de4520. rdar://problem/103832563 Build failure: WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:147:9: fatal error: 'PassKitMacHelper/PKPaymentAuthorizationViewController_Private.h' file not found https://bugs.webkit.org/show_bug.cgi?id=250086 rdar://103832563 Reviewed by Megan Gardner. Build fix. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h: * Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm: * Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h: * Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments): (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Canonical link: https://commits.webkit.org/258451 at main Canonical link: https://commits.webkit.org/258382.2 at safari-7615.1.17-branch From noreply at github.com Wed Jan 4 17:08:44 2023 From: noreply at github.com (Alan Coon) Date: Wed, 04 Jan 2023 17:08:44 -0800 Subject: [webkit-changes] [WebKit/WebKit] Message-ID: Branch: refs/heads/safari-7615.1.16.1-branch Home: https://github.com/WebKit/WebKit From noreply at github.com Wed Jan 4 17:11:21 2023 From: noreply at github.com (Alan Coon) Date: Wed, 04 Jan 2023 17:11:21 -0800 Subject: [webkit-changes] [WebKit/WebKit] fab1a2: Versioning. Message-ID: Branch: refs/heads/safari-7615.1.16.1-branch Home: https://github.com/WebKit/WebKit Commit: fab1a2f17d085ddae4cbce562c196e639ff1fa6a https://github.com/WebKit/WebKit/commit/fab1a2f17d085ddae4cbce562c196e639ff1fa6a Author: Alan Coon Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7615.1.16.1.1 Canonical link: https://commits.webkit.org/257979.10 at safari-7615.1.16.1-branch From noreply at github.com Wed Jan 4 17:14:15 2023 From: noreply at github.com (Per Arne Vollan) Date: Wed, 04 Jan 2023 17:14:15 -0800 Subject: [webkit-changes] [WebKit/WebKit] 4aead9: Cherry-pick 8c5dd8c31d25. rdar://problem/103764832 Message-ID: Branch: refs/heads/safari-7615.1.16.1-branch Home: https://github.com/WebKit/WebKit Commit: 4aead986769f72773686c872d5a78c04375f889b https://github.com/WebKit/WebKit/commit/4aead986769f72773686c872d5a78c04375f889b Author: Per Arne Vollan Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/Shared/Sandbox/common.sb Log Message: ----------- Cherry-pick 8c5dd8c31d25. rdar://problem/103764832 Initially allow syscall mach in sandbox v3 https://bugs.webkit.org/show_bug.cgi?id=250051 rdar://103764832 Reviewed by Brent Fulgham. Initially allow syscall mach in sandbox v3, since it was allowed in v1. Individual sandboxes will deny mach syscalls. * Source/WebKit/Shared/Sandbox/common.sb: Canonical link: https://commits.webkit.org/258411 at main Canonical link: https://commits.webkit.org/257979.11 at safari-7615.1.16.1-branch From noreply at github.com Wed Jan 4 17:14:40 2023 From: noreply at github.com (Ryosuke Niwa) Date: Wed, 04 Jan 2023 17:14:40 -0800 Subject: [webkit-changes] [WebKit/WebKit] 6bb0f9: [Live Range Selection] editing/selection/ios/clear... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bb0f971c893cecfc0c6722f0f444501d88cd8de https://github.com/WebKit/WebKit/commit/6bb0f971c893cecfc0c6722f0f444501d88cd8de Author: Ryosuke Niwa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html Log Message: ----------- [Live Range Selection] editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html fails https://bugs.webkit.org/show_bug.cgi?id=250092 Reviewed by Wenson Hsieh. The failure was caused by the test using an invalid offset to setBaseAndExtent. Use a valid offset instead. * LayoutTests/editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html: Canonical link: https://commits.webkit.org/258461 at main From noreply at github.com Wed Jan 4 17:17:33 2023 From: noreply at github.com (Said Abou-Hallawa) Date: Wed, 04 Jan 2023 17:17:33 -0800 Subject: [webkit-changes] [WebKit/WebKit] d9e61b: [GPU Process] [FormControls] Add ControlParts for ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9e61bbb56beb116a6f42f89a97f6ed0adbbb8c0 https://github.com/WebKit/WebKit/commit/d9e61bbb56beb116a6f42f89a97f6ed0adbbb8c0 Author: Said Abou-Hallawa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/spi/mac/NSSearchFieldCellSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/ControlStates.h M Source/WebCore/platform/graphics/controls/ControlFactory.h A Source/WebCore/platform/graphics/controls/SearchFieldCancelButtonPart.h A Source/WebCore/platform/graphics/controls/SearchFieldPart.h M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm A Source/WebCore/platform/graphics/mac/controls/SearchControlMac.h A Source/WebCore/platform/graphics/mac/controls/SearchControlMac.mm A Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.h A Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm A Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.h A Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm M Source/WebCore/platform/graphics/mac/controls/TextFieldMac.mm M Source/WebCore/platform/mac/ThemeMac.mm M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp Log Message: ----------- [GPU Process] [FormControls] Add ControlParts for SearchField and SearchFieldCancelButton https://bugs.webkit.org/show_bug.cgi?id=249890 rdar://103703733 Reviewed by Aditya Keerthi. These ControlParts will handle drawing the SearchField form control and its cancel button (i.e. ``). For macOS, AppKit will be used to draw the platform controls. * Source/WebCore/Headers.cmake: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/mac/NSSearchFieldCellSPI.h: Added. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/ControlStates.h: * Source/WebCore/platform/graphics/controls/ControlFactory.h: * Source/WebCore/platform/graphics/controls/SearchFieldCancelButtonPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/controls/SearchFieldPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm: (WebCore::ControlFactoryMac::searchFieldCell const): (WebCore::ControlFactoryMac::createPlatformSearchField): (WebCore::ControlFactoryMac::createPlatformSearchFieldCancelButton): * Source/WebCore/platform/graphics/mac/controls/ControlMac.h: * Source/WebCore/platform/graphics/mac/controls/ControlMac.mm: (WebCore::ControlMac::updateEnabledState): (WebCore::ControlMac::updateFocusedState): (WebCore::ControlMac::updatePressedState): * Source/WebCore/platform/graphics/mac/controls/SearchControlMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/SearchControlMac.mm: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. (WebCore::SearchControlMac::SearchControlMac): (WebCore::SearchControlMac::updateCellStates): * Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm: Added. (WebCore::SearchFieldCancelButtonMac::SearchFieldCancelButtonMac): (WebCore::SearchFieldCancelButtonMac::cellSize const): (WebCore::SearchFieldCancelButtonMac::rectForBounds const): (WebCore::SearchFieldCancelButtonMac::updateCellStates): (WebCore::SearchFieldCancelButtonMac::draw): * Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h. * Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm: Copied from Source/WebCore/platform/graphics/mac/controls/ControlMac.h. (WebCore::SearchFieldMac::SearchFieldMac): (WebCore::SearchFieldMac::draw): * Source/WebCore/platform/mac/ThemeMac.mm: (WebCore::ThemeMac::ensuredView): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::createControlPart const): (WebCore::RenderTheme::extractControlStyleStatesForRenderer const): (WebCore::RenderTheme::extractControlStyleForRenderer const): (WebCore::RenderTheme::extractControlStatesForRenderer const): (WebCore::RenderTheme::isWindowActive const): (WebCore::RenderTheme::isDefault const): (WebCore::RenderTheme::isActive const): Deleted. * Source/WebCore/rendering/RenderTheme.h: * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::canPaint const): (WebCore::RenderThemeMac::canCreateControlPartForRenderer const): (WebCore::RenderThemeMac::updatePressedState): (WebCore::RenderThemeMac::paintSearchField): Deleted. (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::decode): Canonical link: https://commits.webkit.org/258462 at main From noreply at github.com Wed Jan 4 17:19:16 2023 From: noreply at github.com (Tim Chevalier) Date: Wed, 04 Jan 2023 17:19:16 -0800 Subject: [webkit-changes] [WebKit/WebKit] 24d6d5: Re-land [Wasm-GC] Implement packed types in arrays Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24d6d56cfb68eb45f2336bde3133bfefb40d8356 https://github.com/WebKit/WebKit/commit/24d6d56cfb68eb45f2336bde3133bfefb40d8356 Author: Tim Chevalier Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M JSTests/wasm/gc/arrays.js A JSTests/wasm/gc/packed-arrays.js M JSTests/wasm/wasm.json M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/WasmSectionParser.h M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.h M Source/JavaScriptCore/wasm/generateWasm.py M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp M Source/JavaScriptCore/wasm/wasm.json Log Message: ----------- Re-land [Wasm-GC] Implement packed types in arrays https://bugs.webkit.org/show_bug.cgi?id=247576 Reviewed by Justin Michaud. This patch implements support for packed types (i8, i16) in Wasm GC arrays. Packed types are represented with new entries in wasm.json and are only allowed for use in StorageTypes, which are a new kind of type used for struct and array type definition fields. Packed structs are not yet allowed with this patch. Relanded patch fixes an invalid move in the Air generator for non-x86 platforms. It also refactors StorageType use slightly and also eliminates redundant LLInt opcodes. * JSTests/wasm/gc/arrays.js: (testArrayDeclaration): * JSTests/wasm/gc/packed-arrays.js: Added. (module): (check): (testArrayGetPacked): (testArrayGetUWithNewCanonPacked): (testArrayGetSWithNewCanonPacked): (testTypeMismatch64): (testTypeMismatchArrayGet): (testPackedTypeOutOfContext): (testSetGetTruncate): (testArraySet): (testArrayGetUnreachable): * JSTests/wasm/wasm.json: * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::addArrayNewDefault): (JSC::Wasm::ExpressionType>::addArrayGet): (JSC::Wasm::ExpressionType>::addStructGet): (JSC::Wasm::ExpressionType>::addStructSet): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::emitStructSet): (JSC::Wasm::B3IRGenerator::pushArrayNew): (JSC::Wasm::B3IRGenerator::addArrayNew): (JSC::Wasm::B3IRGenerator::addArrayNewDefault): (JSC::Wasm::B3IRGenerator::addArrayGet): (JSC::Wasm::B3IRGenerator::addStructGet): * Source/JavaScriptCore/wasm/WasmFormat.h: (JSC::Wasm::isRefType): (JSC::Wasm::isRefWithRecursiveReference): (JSC::Wasm::isSubtype): (JSC::Wasm::isDefaultableType): * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseExpression): (JSC::Wasm::FunctionParser::parseUnreachableExpression): * Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::addArrayGet): * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parsePackedType): (JSC::Wasm::SectionParser::parseStorageType): (JSC::Wasm::SectionParser::parseStructType): (JSC::Wasm::SectionParser::parseArrayType): * Source/JavaScriptCore/wasm/WasmSectionParser.h: * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): * Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp: (JSC::Wasm::StructType::dump const): (JSC::Wasm::StructType::StructType): (JSC::Wasm::ArrayType::dump const): (JSC::Wasm::StorageType::dump const): (JSC::Wasm::computeStructTypeHash): (JSC::Wasm::computeArrayTypeHash): (JSC::Wasm::TypeDefinition::replacePlaceholders const): * Source/JavaScriptCore/wasm/WasmTypeDefinition.h: (JSC::Wasm::StorageType::is const): (JSC::Wasm::StorageType::as const): (JSC::Wasm::StorageType::StorageType): (JSC::Wasm::StorageType::unpacked const): (JSC::Wasm::StorageType::elementSize const): (JSC::Wasm::StorageType::operator== const): (JSC::Wasm::StorageType::operator!= const): (JSC::Wasm::StorageType::typeCode const): (JSC::Wasm::StorageType::index const): (JSC::Wasm::makeString): (JSC::Wasm::typeSizeInBytes): * Source/JavaScriptCore/wasm/generateWasm.py: (Wasm.__init__): * Source/JavaScriptCore/wasm/generateWasmOpsHeader.py: (cppMacro): (cppMacroPacked): (packedTypeMacroizer): * Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp: (JSC::JSWebAssemblyArray::JSWebAssemblyArray): (JSC::JSWebAssemblyArray::~JSWebAssemblyArray): (JSC::JSWebAssemblyArray::visitChildrenImpl): * Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h: * Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp: (JSC::JSWebAssemblyStruct::get const): (JSC::JSWebAssemblyStruct::set): * Source/JavaScriptCore/wasm/wasm.json: Canonical link: https://commits.webkit.org/258463 at main From noreply at github.com Wed Jan 4 17:35:00 2023 From: noreply at github.com (Alex Christensen) Date: Wed, 04 Jan 2023 17:35:00 -0800 Subject: [webkit-changes] [WebKit/WebKit] b9fee2: Begin preparing DrawingAreaProxy to work with mult... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9fee27e7af0001a0bf015e69540d40a68691165 https://github.com/WebKit/WebKit/commit/b9fee27e7af0001a0bf015e69540d40a68691165 Author: Alex Christensen Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h M Source/WebKit/UIProcess/DrawingAreaProxy.cpp M Source/WebKit/UIProcess/DrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h M Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/UIProcess/playstation/PageClientImpl.cpp M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h M Source/WebKit/UIProcess/win/PageClientImpl.cpp Log Message: ----------- Begin preparing DrawingAreaProxy to work with multiple web processes with site isolation https://bugs.webkit.org/show_bug.cgi?id=250093 rdar://103881608 Reviewed by Tim Horton. With site isolation, DrawingAreaProxy can no longer be a message sender because message senders can only send to one process. Instead, we use other methods to send the message. Many of them just call m_webPageProxy.send with m_identifier, and we get the same behavior as before in the non-site-isolated case and we can fix the necessary send calls to send to the correct process in a coming PR. Using m_webPageProxy.process() would be a problem if we did anything with ProvisionalPageProxy's DrawingAreaProxy, but we currently don't. ProvisionalPageProxy only uses it to call WebPageProxy::creationParameters which just sends the drawing area's type and identifier to the new process. There is potential for some future refactoring to clean that up, but it's not too important. Receiving messages works as it did before, except instead of registering as a message receiver for one process and unregistering from one process in the destructor, we keep a Vector of processes we have registered in. This also keeps the same behavior while allowing for development of the use of multiple processes. * Source/WebKit/UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::~DrawingAreaProxy): (WebKit::DrawingAreaProxy::startReceivingMessages): (WebKit::DrawingAreaProxy::viewExposedRectChangedTimerFired): (WebKit::DrawingAreaProxy::messageSenderConnection const): Deleted. (WebKit::DrawingAreaProxy::sendMessage): Deleted. (WebKit::DrawingAreaProxy::sendMessageWithAsyncReply): Deleted. * Source/WebKit/UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::waitForDidUpdateActivityState): (WebKit::DrawingAreaProxy::page const): (WebKit::DrawingAreaProxy::process): Deleted. (WebKit::DrawingAreaProxy::process const): Deleted. (): Deleted. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy): (WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy): (WebKit::RemoteLayerTreeDrawingAreaProxy::deviceScaleFactorDidChange): (WebKit::RemoteLayerTreeDrawingAreaProxy::sendUpdateGeometry): (WebKit::RemoteLayerTreeDrawingAreaProxy::acceleratedAnimationDidStart): (WebKit::RemoteLayerTreeDrawingAreaProxy::acceleratedAnimationDidEnd): (WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay): (WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState): (WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::exisingDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::ensureDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::adjustTransientZoom): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::commitTransientZoom): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::colorSpaceDidChange): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDrawingArea): (WebKit::WebPageProxy::waitForDidUpdateActivityState): * Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: * Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: (WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange): (WebKit::TiledCoreAnimationDrawingAreaProxy::colorSpaceDidChange): (WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateActivityState): (WebKit::TiledCoreAnimationDrawingAreaProxy::createFence): (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry): (WebKit::TiledCoreAnimationDrawingAreaProxy::adjustTransientZoom): (WebKit::TiledCoreAnimationDrawingAreaProxy::commitTransientZoom): (WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchAfterEnsuringDrawing): Canonical link: https://commits.webkit.org/258464 at main From noreply at github.com Wed Jan 4 17:45:00 2023 From: noreply at github.com (Ahmad Saleem) Date: Wed, 04 Jan 2023 17:45:00 -0800 Subject: [webkit-changes] [WebKit/WebKit] f1fd9e: Potential Assertion Fix - Fix loop condition in Bi... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1fd9e9795a69fedff6f67401a3f77d93b81959e https://github.com/WebKit/WebKit/commit/f1fd9e9795a69fedff6f67401a3f77d93b81959e Author: Ahmad Saleem Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt A LayoutTests/fast/text/bidi-replace-runs-crash.html M Source/WebCore/platform/text/BidiRunList.h Log Message: ----------- Potential Assertion Fix - Fix loop condition in BidiRunList::replaceRunWithRuns Potential Assertion Fix - Fix loop condition in BidiRunList::replaceRunWithRuns https://bugs.webkit.org/show_bug.cgi?id=249968 Reviewed by Alan Baradlay. Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=179068 This patch is to potentially fix an assertion on debug builds by fixing a loop condition in BidiRunList::replaceRunWithRuns to check if next run exists before accessing it. * Source/WebCore/platform/text/BidiRunList.h: (BidiRunList::replaceRunwithRuns): update 'while' loop * LayoutTests/fast/text/bidi-replace-runs-crash.html: Add Test Case * LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/258465 at main From noreply at github.com Wed Jan 4 18:00:57 2023 From: noreply at github.com (Ryosuke Niwa) Date: Wed, 04 Jan 2023 18:00:57 -0800 Subject: [webkit-changes] [WebKit/WebKit] d0a82d: [Live Range Selection] LayoutTests/fast/events/ios... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0a82d3bd607a2f115de3084725749bc75015955 https://github.com/WebKit/WebKit/commit/d0a82d3bd607a2f115de3084725749bc75015955 Author: Ryosuke Niwa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/fast/events/ios/autocorrect-with-range-selection.html Log Message: ----------- [Live Range Selection] LayoutTests/fast/events/ios/autocorrect-with-range-selection.html fails https://bugs.webkit.org/show_bug.cgi?id=250095 Reviewed by Wenson Hsieh. The failure was caused by the use of an invalid offset. Use a valid offset instead. * LayoutTests/fast/events/ios/autocorrect-with-range-selection.html: Canonical link: https://commits.webkit.org/258466 at main From noreply at github.com Wed Jan 4 18:14:11 2023 From: noreply at github.com (Matthew Finkel) Date: Wed, 04 Jan 2023 18:14:11 -0800 Subject: [webkit-changes] [WebKit/WebKit] 7cf248: [cocoa] Respect NetworkConnectionIntegrity's FailC... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cf248ec73b4f4a701ab6ac0a3f8213fb2fd117f https://github.com/WebKit/WebKit/commit/7cf248ec73b4f4a701ab6ac0a3f8213fb2fd117f Author: Matthew Finkel Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: ----------- [cocoa] Respect NetworkConnectionIntegrity's FailClosed Policy https://bugs.webkit.org/show_bug.cgi?id=249660 rdar://problem/103562719 Reviewed by Wenson Hsieh. Set the appropriate flag on the URLRequest when it's requested. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Canonical link: https://commits.webkit.org/258467 at main From noreply at github.com Wed Jan 4 18:57:15 2023 From: noreply at github.com (Wenson Hsieh) Date: Wed, 04 Jan 2023 18:57:15 -0800 Subject: [webkit-changes] [WebKit/WebKit] b904d8: Unreviewed, fix Apple internal builds after 258467... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b904d8ac17fff03be6469d9832b452107642b025 https://github.com/WebKit/WebKit/commit/b904d8ac17fff03be6469d9832b452107642b025 Author: Wenson Hsieh Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: ----------- Unreviewed, fix Apple internal builds after 258467 at main https://bugs.webkit.org/show_bug.cgi?id=250117 rdar://103562719 Put the declaration and usage of this new SPI behind an internally-defined build-time flag. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Canonical link: https://commits.webkit.org/258468 at main From noreply at github.com Wed Jan 4 20:00:20 2023 From: noreply at github.com (AndresGonzalezApple) Date: Wed, 04 Jan 2023 20:00:20 -0800 Subject: [webkit-changes] [WebKit/WebKit] c7cf17: AX: Conversion of PDFView coordinates to screen co... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7cf1700de117cb251a91dd38ba9bed65516b3f7 https://github.com/WebKit/WebKit/commit/c7cf1700de117cb251a91dd38ba9bed65516b3f7 Author: Andres Gonzalez Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm Log Message: ----------- AX: Conversion of PDFView coordinates to screen coordinates for accessibility should happen on the main thread. https://bugs.webkit.org/show_bug.cgi?id=250099 Reviewed by Chris Fleizach. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]): (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]): Instead of dispatching to the main thread, the above two methods call directly PDFPlugin::convertFromPDFViewToScreen that in turn dispatches the conversion to the main thread. (WebKit::PDFPlugin::convertFromPDFViewToScreen const): (WebKit::PDFPlugin::boundsOnScreen const): These two PDFPlugin methods now dispatch the conversion to the main thread. Canonical link: https://commits.webkit.org/258469 at main From noreply at github.com Wed Jan 4 20:16:56 2023 From: noreply at github.com (Sihui) Date: Wed, 04 Jan 2023 20:16:56 -0800 Subject: [webkit-changes] [WebKit/WebKit] 84e59d: Stop using Safari paths for SafariForWebKitDevelop... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84e59dc75f5e8c15934d1d3d2f91b33e89e60ba0 https://github.com/WebKit/WebKit/commit/84e59dc75f5e8c15934d1d3d2f91b33e89e60ba0 Author: Sihui Liu Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Log Message: ----------- Stop using Safari paths for SafariForWebKitDevelopment https://bugs.webkit.org/show_bug.cgi?id=250063 rdar://102422209 Reviewed by Chris Dumez. SafariForWebKitDevelopment is used for testing local builds of WebKit, which can contain untrusted code, so it should not touch Safari files / directories in data vaults (e.g. ~/Library/Safari). * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::applicationOrProcessIdentifier): (WebKit::defaultWebsiteDataStoreRootDirectory): (WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation): (WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): (WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Canonical link: https://commits.webkit.org/258470 at main From noreply at github.com Wed Jan 4 20:31:03 2023 From: noreply at github.com (Commit Queue) Date: Wed, 04 Jan 2023 20:31:03 -0800 Subject: [webkit-changes] [WebKit/WebKit] fe1655: _WKAuthenticatorAttestationResponse and _WKAuthent... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe1655421cc54053541f73893479da9f25418daa https://github.com/WebKit/WebKit/commit/fe1655421cc54053541f73893479da9f25418daa Author: David Kilzer Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.h M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.mm M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.h M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.mm Log Message: ----------- _WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain/copy their instance variables https://bugs.webkit.org/show_bug.cgi?id=250080 Reviewed by Brent Fulgham. Update @property declarations to retain instance variables rather than storing them as unsafe-unretained, update init methods to properly retain/copy the instance variables, and add -dealloc methods to release instance variables. * Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.h: - Update @property declarations to store strong references. * Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.mm: (-[_WKAuthenticatorAttestationResponse initWithClientDataJSON:rawId:extensions:attestationObject:attachment:transports:]): (-[_WKAuthenticatorAttestationResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attestationObject:attachment:transports:]): - Retain or copy instance variables to match @property declarations. (-[_WKAuthenticatorAttestationResponse dealloc]): Add. - Release retained/copied instance variables to prevent leaks. * Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.h: - Update @property declarations to store strong references. * Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.mm: (-[_WKAuthenticatorResponse initWithClientDataJSON:rawId:extensions:attachment:]): (-[_WKAuthenticatorResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attachment:]): - Retain or copy instance variables to match @property declarations. - Use WTFMove() to avoid ref churn of rvalue parameter. (-[_WKAuthenticatorResponse dealloc]): Add. - Release retained/copied instance variables to prevent leaks. Canonical link: https://commits.webkit.org/258471 at main From noreply at github.com Wed Jan 4 21:00:26 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 21:00:26 -0800 Subject: [webkit-changes] [WebKit/WebKit] 025094: [JSC] Update wasm spec tests Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 025094ea04c5307a9567f85ce62b5cba6477909b https://github.com/WebKit/WebKit/commit/025094ea04c5307a9567f85ce62b5cba6477909b Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M JSTests/wasm.yaml R JSTests/wasm/multi-value-spec-tests/block.wast.js R JSTests/wasm/multi-value-spec-tests/br.wast.js R JSTests/wasm/multi-value-spec-tests/br_if.wast.js R JSTests/wasm/multi-value-spec-tests/call.wast.js R JSTests/wasm/multi-value-spec-tests/call_indirect.wast.js R JSTests/wasm/multi-value-spec-tests/func.wast.js R JSTests/wasm/multi-value-spec-tests/if.wast.js R JSTests/wasm/multi-value-spec-tests/loop.wast.js R JSTests/wasm/multi-value-spec-tests/type.wast.js R JSTests/wasm/ref-spec-harness.js R JSTests/wasm/ref-spec-harness/async_index.js R JSTests/wasm/ref-spec-harness/sync_index.js R JSTests/wasm/ref-spec-harness/wasm-constants.js R JSTests/wasm/ref-spec-harness/wasm-module-builder.js R JSTests/wasm/ref-spec-harness/wast.js R JSTests/wasm/references-spec-tests/binary-leb128.wast.js R JSTests/wasm/references-spec-tests/binary.wast.js R JSTests/wasm/references-spec-tests/br_table.wast.js R JSTests/wasm/references-spec-tests/bulk.wast.js R JSTests/wasm/references-spec-tests/call_indirect.wast.js R JSTests/wasm/references-spec-tests/custom.wast.js R JSTests/wasm/references-spec-tests/data.wast.js R JSTests/wasm/references-spec-tests/elem.wast.js R JSTests/wasm/references-spec-tests/exports.wast.js R JSTests/wasm/references-spec-tests/global.wast.js R JSTests/wasm/references-spec-tests/imports.wast.js R JSTests/wasm/references-spec-tests/linking.wast.js R JSTests/wasm/references-spec-tests/memory_copy.wast.js R JSTests/wasm/references-spec-tests/memory_fill.wast.js R JSTests/wasm/references-spec-tests/memory_grow.wast.js R JSTests/wasm/references-spec-tests/memory_init.wast.js R JSTests/wasm/references-spec-tests/ref_func.wast.js R JSTests/wasm/references-spec-tests/ref_is_null.wast.js R JSTests/wasm/references-spec-tests/ref_null.wast.js R JSTests/wasm/references-spec-tests/select.wast.js R JSTests/wasm/references-spec-tests/table-sub.wast.js R JSTests/wasm/references-spec-tests/table.wast.js R JSTests/wasm/references-spec-tests/table_copy.wast.js R JSTests/wasm/references-spec-tests/table_fill.wast.js R JSTests/wasm/references-spec-tests/table_get.wast.js R JSTests/wasm/references-spec-tests/table_grow.wast.js R JSTests/wasm/references-spec-tests/table_init.wast.js R JSTests/wasm/references-spec-tests/table_set.wast.js R JSTests/wasm/references-spec-tests/table_size.wast.js R JSTests/wasm/references-spec-tests/unreached-invalid.wast.js A JSTests/wasm/simd-spec-tests/simd_address.wast.js A JSTests/wasm/simd-spec-tests/simd_align.wast.js A JSTests/wasm/simd-spec-tests/simd_bit_shift.wast.js A JSTests/wasm/simd-spec-tests/simd_bitwise.wast.js A JSTests/wasm/simd-spec-tests/simd_boolean.wast.js A JSTests/wasm/simd-spec-tests/simd_const.wast.js A JSTests/wasm/simd-spec-tests/simd_conversions.wast.js A JSTests/wasm/simd-spec-tests/simd_f32x4.wast.js A JSTests/wasm/simd-spec-tests/simd_f32x4_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_f32x4_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_f32x4_pmin_pmax.wast.js A JSTests/wasm/simd-spec-tests/simd_f32x4_rounding.wast.js A JSTests/wasm/simd-spec-tests/simd_f64x2.wast.js A JSTests/wasm/simd-spec-tests/simd_f64x2_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_f64x2_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_f64x2_pmin_pmax.wast.js A JSTests/wasm/simd-spec-tests/simd_f64x2_rounding.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_arith2.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_extadd_pairwise_i8x16.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_extmul_i8x16.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_q15mulr_sat_s.wast.js A JSTests/wasm/simd-spec-tests/simd_i16x8_sat_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_arith2.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_dot_i16x8.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_extadd_pairwise_i16x8.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_extmul_i16x8.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_trunc_sat_f32x4.wast.js A JSTests/wasm/simd-spec-tests/simd_i32x4_trunc_sat_f64x2.wast.js A JSTests/wasm/simd-spec-tests/simd_i64x2_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_i64x2_arith2.wast.js A JSTests/wasm/simd-spec-tests/simd_i64x2_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_i64x2_extmul_i32x4.wast.js A JSTests/wasm/simd-spec-tests/simd_i8x16_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_i8x16_arith2.wast.js A JSTests/wasm/simd-spec-tests/simd_i8x16_cmp.wast.js A JSTests/wasm/simd-spec-tests/simd_i8x16_sat_arith.wast.js A JSTests/wasm/simd-spec-tests/simd_int_to_int_extend.wast.js A JSTests/wasm/simd-spec-tests/simd_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_load.wast.js A JSTests/wasm/simd-spec-tests/simd_load16_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_load32_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_load64_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_load8_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_load_extend.wast.js A JSTests/wasm/simd-spec-tests/simd_load_splat.wast.js A JSTests/wasm/simd-spec-tests/simd_load_zero.wast.js A JSTests/wasm/simd-spec-tests/simd_splat.wast.js A JSTests/wasm/simd-spec-tests/simd_store.wast.js A JSTests/wasm/simd-spec-tests/simd_store16_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_store32_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_store64_lane.wast.js A JSTests/wasm/simd-spec-tests/simd_store8_lane.wast.js M JSTests/wasm/spec-harness/async_index.js M JSTests/wasm/spec-harness/sync_index.js M JSTests/wasm/spec-tests/address.wast.js M JSTests/wasm/spec-tests/align.wast.js M JSTests/wasm/spec-tests/binary-leb128.wast.js M JSTests/wasm/spec-tests/binary.wast.js M JSTests/wasm/spec-tests/block.wast.js M JSTests/wasm/spec-tests/br.wast.js M JSTests/wasm/spec-tests/br_if.wast.js M JSTests/wasm/spec-tests/br_table.wast.js A JSTests/wasm/spec-tests/bulk.wast.js M JSTests/wasm/spec-tests/call.wast.js M JSTests/wasm/spec-tests/call_indirect.wast.js M JSTests/wasm/spec-tests/comments.wast.js M JSTests/wasm/spec-tests/const.wast.js M JSTests/wasm/spec-tests/conversions.wast.js M JSTests/wasm/spec-tests/custom.wast.js M JSTests/wasm/spec-tests/data.wast.js M JSTests/wasm/spec-tests/elem.wast.js M JSTests/wasm/spec-tests/endianness.wast.js M JSTests/wasm/spec-tests/exports.wast.js M JSTests/wasm/spec-tests/f32.wast.js M JSTests/wasm/spec-tests/f32_bitwise.wast.js M JSTests/wasm/spec-tests/f32_cmp.wast.js M JSTests/wasm/spec-tests/f64.wast.js M JSTests/wasm/spec-tests/f64_bitwise.wast.js M JSTests/wasm/spec-tests/f64_cmp.wast.js M JSTests/wasm/spec-tests/fac.wast.js M JSTests/wasm/spec-tests/float_exprs.wast.js M JSTests/wasm/spec-tests/float_literals.wast.js M JSTests/wasm/spec-tests/float_memory.wast.js M JSTests/wasm/spec-tests/float_misc.wast.js M JSTests/wasm/spec-tests/func.wast.js M JSTests/wasm/spec-tests/global.wast.js M JSTests/wasm/spec-tests/i32.wast.js M JSTests/wasm/spec-tests/i64.wast.js M JSTests/wasm/spec-tests/if.wast.js M JSTests/wasm/spec-tests/imports.wast.js M JSTests/wasm/spec-tests/int_exprs.wast.js M JSTests/wasm/spec-tests/int_literals.wast.js M JSTests/wasm/spec-tests/linking.wast.js M JSTests/wasm/spec-tests/local_get.wast.js M JSTests/wasm/spec-tests/local_set.wast.js M JSTests/wasm/spec-tests/local_tee.wast.js M JSTests/wasm/spec-tests/loop.wast.js M JSTests/wasm/spec-tests/memory.wast.js A JSTests/wasm/spec-tests/memory_copy.wast.js A JSTests/wasm/spec-tests/memory_fill.wast.js M JSTests/wasm/spec-tests/memory_grow.wast.js A JSTests/wasm/spec-tests/memory_init.wast.js M JSTests/wasm/spec-tests/memory_redundancy.wast.js M JSTests/wasm/spec-tests/memory_trap.wast.js A JSTests/wasm/spec-tests/ref_func.wast.js A JSTests/wasm/spec-tests/ref_is_null.wast.js A JSTests/wasm/spec-tests/ref_null.wast.js M JSTests/wasm/spec-tests/return.wast.js M JSTests/wasm/spec-tests/select.wast.js R JSTests/wasm/spec-tests/simd_address.wast.js R JSTests/wasm/spec-tests/simd_align.wast.js R JSTests/wasm/spec-tests/simd_bit_shift.wast.js R JSTests/wasm/spec-tests/simd_bitwise.wast.js R JSTests/wasm/spec-tests/simd_boolean.wast.js R JSTests/wasm/spec-tests/simd_const.wast.js R JSTests/wasm/spec-tests/simd_conversions.wast.js R JSTests/wasm/spec-tests/simd_f32x4.wast.js R JSTests/wasm/spec-tests/simd_f32x4_arith.wast.js R JSTests/wasm/spec-tests/simd_f32x4_cmp.wast.js R JSTests/wasm/spec-tests/simd_f32x4_pmin_pmax.wast.js R JSTests/wasm/spec-tests/simd_f32x4_rounding.wast.js R JSTests/wasm/spec-tests/simd_f64x2.wast.js R JSTests/wasm/spec-tests/simd_f64x2_arith.wast.js R JSTests/wasm/spec-tests/simd_f64x2_cmp.wast.js R JSTests/wasm/spec-tests/simd_f64x2_pmin_pmax.wast.js R JSTests/wasm/spec-tests/simd_f64x2_rounding.wast.js R JSTests/wasm/spec-tests/simd_i16x8_arith.wast.js R JSTests/wasm/spec-tests/simd_i16x8_arith2.wast.js R JSTests/wasm/spec-tests/simd_i16x8_cmp.wast.js R JSTests/wasm/spec-tests/simd_i16x8_extadd_pairwise_i8x16.wast.js R JSTests/wasm/spec-tests/simd_i16x8_extmul_i8x16.wast.js R JSTests/wasm/spec-tests/simd_i16x8_q15mulr_sat_s.wast.js R JSTests/wasm/spec-tests/simd_i16x8_sat_arith.wast.js R JSTests/wasm/spec-tests/simd_i32x4_arith.wast.js R JSTests/wasm/spec-tests/simd_i32x4_arith2.wast.js R JSTests/wasm/spec-tests/simd_i32x4_cmp.wast.js R JSTests/wasm/spec-tests/simd_i32x4_dot_i16x8.wast.js R JSTests/wasm/spec-tests/simd_i32x4_extadd_pairwise_i16x8.wast.js R JSTests/wasm/spec-tests/simd_i32x4_extmul_i16x8.wast.js R JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f32x4.wast.js R JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f64x2.wast.js R JSTests/wasm/spec-tests/simd_i64x2_arith.wast.js R JSTests/wasm/spec-tests/simd_i64x2_arith2.wast.js R JSTests/wasm/spec-tests/simd_i64x2_cmp.wast.js R JSTests/wasm/spec-tests/simd_i64x2_extmul_i32x4.wast.js R JSTests/wasm/spec-tests/simd_i8x16_arith.wast.js R JSTests/wasm/spec-tests/simd_i8x16_arith2.wast.js R JSTests/wasm/spec-tests/simd_i8x16_cmp.wast.js R JSTests/wasm/spec-tests/simd_i8x16_sat_arith.wast.js R JSTests/wasm/spec-tests/simd_int_to_int_extend.wast.js R JSTests/wasm/spec-tests/simd_lane.wast.js R JSTests/wasm/spec-tests/simd_load.wast.js R JSTests/wasm/spec-tests/simd_load16_lane.wast.js R JSTests/wasm/spec-tests/simd_load32_lane.wast.js R JSTests/wasm/spec-tests/simd_load64_lane.wast.js R JSTests/wasm/spec-tests/simd_load8_lane.wast.js R JSTests/wasm/spec-tests/simd_load_extend.wast.js R JSTests/wasm/spec-tests/simd_load_splat.wast.js R JSTests/wasm/spec-tests/simd_load_zero.wast.js R JSTests/wasm/spec-tests/simd_splat.wast.js R JSTests/wasm/spec-tests/simd_store.wast.js R JSTests/wasm/spec-tests/simd_store16_lane.wast.js R JSTests/wasm/spec-tests/simd_store32_lane.wast.js R JSTests/wasm/spec-tests/simd_store64_lane.wast.js R JSTests/wasm/spec-tests/simd_store8_lane.wast.js M JSTests/wasm/spec-tests/stack.wast.js M JSTests/wasm/spec-tests/switch.wast.js A JSTests/wasm/spec-tests/table-sub.wast.js M JSTests/wasm/spec-tests/table.wast.js A JSTests/wasm/spec-tests/table_copy.wast.js A JSTests/wasm/spec-tests/table_fill.wast.js A JSTests/wasm/spec-tests/table_get.wast.js A JSTests/wasm/spec-tests/table_grow.wast.js A JSTests/wasm/spec-tests/table_init.wast.js A JSTests/wasm/spec-tests/table_set.wast.js A JSTests/wasm/spec-tests/table_size.wast.js A JSTests/wasm/spec-tests/tokens.wast.js M JSTests/wasm/spec-tests/traps.wast.js M JSTests/wasm/spec-tests/unreachable.wast.js M JSTests/wasm/spec-tests/unreached-invalid.wast.js A JSTests/wasm/spec-tests/unreached-valid.wast.js A JSTests/wasm/threads-spec-harness.js A JSTests/wasm/threads-spec-harness/async_index.js A JSTests/wasm/threads-spec-harness/sync_index.js A JSTests/wasm/threads-spec-harness/wasm-constants.js A JSTests/wasm/threads-spec-harness/wasm-module-builder.js A JSTests/wasm/threads-spec-harness/wast.js M Tools/Scripts/run-jsc-stress-tests Log Message: ----------- [JSC] Update wasm spec tests https://bugs.webkit.org/show_bug.cgi?id=250118 rdar://103898235 Reviewed by Mark Lam. This patch updates wasm spec tests to the latest one. And do clean up. 1. SIMD tests should not be placed under spec-tests since it is not included in the wasm's official spec tests yet. This directory must be in-sync with that tests, and adding other tests to this directory makes syncing harder. We move them to simd-spec-tests directory. 2. Since offical spec test harnes gets incompatible with the other threads spec test harness etc., we separate harness for them. 3. Remove references-spec-tests / multi-value-spec-tests since it is now merged into official spec tests. So spec-tests/ includes them. * JSTests/wasm.yaml: * JSTests/wasm/multi-value-spec-harness.js: Added. (import.string_appeared_here.then): (test): (promise_test): (let.assert_unreached): (let.console.log): * JSTests/wasm/multi-value-spec-harness/async_index.js: Copied from JSTests/wasm/spec-harness/async_index.js. (let.testNum): (uniqueTest): (assertThrows): (binary): (module): (assert_invalid): (instance): (exports): (reinitializeRegistry.get promise_test): (reinitializeRegistry): (catch): (assert_exhaustion): (get const): * JSTests/wasm/multi-value-spec-harness/sync_index.js: Copied from JSTests/wasm/spec-harness/sync_index.js. (let.testNum): (assertThrows): (_assert): (ValueResult): (ErrorResult): (Result.prototype.isError): (reinitializeRegistry.let.handler.get return): (binary): (module): * JSTests/wasm/multi-value-spec-harness/wasm-constants.js: Added. (hostref): (bytes): (bytesWithHeader): (makeSig): (makeSig_v_x): (makeSig_v_xx): (makeSig_r_v): (makeSig_r_x): (makeSig_r_xx): (assertTraps): (assertWasmThrows): * JSTests/wasm/multi-value-spec-harness/wasm-module-builder.js: Added. (Binary.prototype.emit_u8): (Binary.prototype.emit_u16): (Binary.prototype.emit_u32): (Binary.prototype.emit_u32v): (Binary.prototype.emit_bytes): (Binary.prototype.emit_string): (Binary.prototype.emit_header): (Binary.prototype.emit_section): (Binary): (WasmFunctionBuilder): (WasmFunctionBuilder.prototype.exportAs): (WasmFunctionBuilder.prototype.exportFunc): (WasmFunctionBuilder.prototype.addBody): (WasmFunctionBuilder.prototype.addLocals): (WasmFunctionBuilder.prototype.end): (WasmGlobalBuilder): (WasmGlobalBuilder.prototype.exportAs): (WasmModuleBuilder): (WasmModuleBuilder.prototype.addStart): (WasmModuleBuilder.prototype.addMemory): (WasmModuleBuilder.prototype.addExplicitSection): (WasmModuleBuilder.prototype.stringToBytes): (WasmModuleBuilder.prototype.addCustomSection): (WasmModuleBuilder.prototype.addType): (WasmModuleBuilder.prototype.addGlobal): (WasmModuleBuilder.prototype.addFunction): (WasmModuleBuilder.prototype.addImport): (WasmModuleBuilder.prototype.addImportedGlobal): (WasmModuleBuilder.prototype.addImportedMemory): (WasmModuleBuilder.prototype.addImportedTable): (WasmModuleBuilder.prototype.addExport): (WasmModuleBuilder.prototype.addExportOfKind): (WasmModuleBuilder.prototype.addDataSegment): (WasmModuleBuilder.prototype.exportMemoryAs): (WasmModuleBuilder.prototype.addFunctionTableInit): (WasmModuleBuilder.prototype.appendToTable): (WasmModuleBuilder.prototype.setFunctionTableLength): (WasmModuleBuilder.prototype.toArray): (WasmModuleBuilder.prototype.toBuffer): (WasmModuleBuilder.prototype.instantiate): * JSTests/wasm/multi-value-spec-harness/wast.js: Added. (normalize): (require.else._registry.name): (require): (add_hex_char): (add_char): (string_with): (list_of_opt): (break_bytes.f): (break_bytes): (f): (decls): (func_type): (limits): (global_type): (testop): (relop): (unop): (binop): (cvtop): (oper): (mem_size): (extension): (memop): (storeop): (var): (constop): (instr.else.switch.case.0.f): (instr.else.switch.case.1.f.1): (instr.else.switch.case.2.f.2): (instr): (func_with_name): (func): (start): (table): (memory): (segment): (elems): (data): (typedef): (import_kind): (import): (export_kind): (export): (var_opt): (is_func_import): (is_table_import): (is_memory_import): (is_global_import): (f.1): (f.2): (f.3): (module_with_var_opt): (module_): (literal): (definition): (access): (action): (script): (_registry.string_appeared_here): (init): (make_matrix): (copy): (append): (sub): (fill): (blit): (iter): (map): (iteri): (mapi): (to_list): (list_length): (of_list): (fold_left): (fold_right): (maxson): (trickle): (bubble): (trickleup): (sort): (merge): (isortto): (sortto): (stable_sort): (import_type): (export_type): (dims.n): (dims.d.i): (dims): (map_file): (create): (of_array): (slice_left): (slice_right): (slice_left_1): (slice_right_1): (slice_left_2): (slice_right_2): (array1_of_genarray): (array2_of_genarray): (array3_of_genarray): (reshape_1): (reshape_2): (reshape_3): (reshape): (__): (contents): (to_bytes): (nth): (length): (clear): (reset): (resize): (add_substring): (add_subbytes): (add_string): (add_bytes): (add_buffer): (add_channel): (output_buffer): (closing): (advance_to_closing): (advance_to_non_alpha): (find_ident): (add_substitute): (make): (to_string): (of_string): (sub_string): (extend): (blit_string): (concat): (cat): (is_space): (trim): (escaped): (uppercase): (lowercase): (apply1): (capitalize): (uncapitalize): (index_rec): (index): (index_from): (rindex_rec): (rindex): (rindex_from): (contains_from): (contains): (rcontains_from): (caml_array_sub): (len): (caml_array_concat): (caml_make_vect): (caml_array_blit): (get if): (caml_set_oo_id): (get_id): (caml_int32_float_of_bits): (caml_int32_bits_of_float): (caml_classify_float): (caml_modf_float): (caml_ldexp_float): (caml_frexp_float): (caml_copysign_float): (caml_expm1_float): (caml_hypot_float): (caml_log10_float): (caml_failwith): (parse_digit): (int_of_string_base): (parse_sign_and_base): (caml_int_of_string.aux): (caml_int_of_string): (caml_int64_of_string.aux): (caml_int64_of_string): (int_of_base): (parse_format): (finish_formatting): (caml_format_int): (caml_int64_format): (caml_format_float): (float_of_string): (div): (mod_): (caml_bswap16): (caml_int32_bswap): (imul): (neg_signed): (not): (eq): (neg): (lsl_): (lsr_): (asr_): (is_zero): (mul): (swap): (xor): (or_): (and_): (ge): (lt): (gt): (le): (to_float): (of_float): (div_mod): (compare): (of_int32): (to_int32): (to_hex.aux): (to_hex): (discard_sign): (float_of_bits): (bits_of_float.to_nat): (bits_of_float): (get64): (erase_rel): (concat_fmtty): (concat_fmt): (create_char_set): (add_in_char_set): (rev_char_set): (is_in_char_set): (prec_of_prec_opt): (param_format_of_ignored_format): (buffer_check_size): (buffer_add_char): (buffer_add_string): (buffer_contents): (char_of_iconv): (char_of_fconv): (char_of_counter): (print_char): (set while.set var): (set while.set else): (set var): (set else): (set print_char): (set if): (bprint_padty): (bprint_ignored_flag): (bprint_pad_opt): (bprint_padding): (bprint_precision): (bprint_iconv_flag): (bprint_int_fmt): (bprint_altint_fmt): (bprint_fconv_flag): (bprint_float_fmt): (string_of_formatting_lit): (string_of_formatting_gen): (bprint_char_literal): (bprint_string_literal): (bprint_fmtty): (int_of_custom_arity): (bprint_fmt): (string_of_fmt): (symm): (fmtty_rel_det): (trans): (fmtty_of_formatting_gen): (fmtty_of_fmt): (fmtty_of_custom): (fmtty_of_padding_fmtty): (fmtty_of_precision_fmtty): (type_padding): (type_padprec): (type_ignored_param_one): (type_format_gen): (type_ignored_format_substitution): (type_format): (recast): (fix_padding): (fix_int_precision): (string_to_caml_string): (format_of_iconv): (format_of_aconv): (format_of_fconv): (convert_int): (convert_int32): (convert_nativeint): (convert_int64): (else.is_valid): (convert_float): (format_caml_char): (string_of_fmtty): (else.switch.): (else.switch.k.prime): (else.switch.else.): (else.switch.else.k.prime.1): (make_printf): (make_from_fmtty): (make_invalid_arg): (make_string_padding): (make_int_padding_precision): (make_custom): (output_acc): (bufput_acc): (strput_acc): (failwith_message.k): (failwith_message): (open_box_of_string.else.invalid_box): (open_box_of_string.else.parse_spaces): (open_box_of_string.else.parse_lword): (open_box_of_string.else.parse_int): (open_box_of_string): (make_padding_fmt_ebb): (make_precision_fmt_ebb): (make_padprec_fmt_ebb): (invalid_format_message): (invalid_format_without): (expected_character): (compute_int_conv): (incompatible_flag): (parse_positive): (parse_conv): (parse_after_precision): (else.parse_literal): (parse_after_padding): (parse_literal): (parse_after_at): (add_literal): (parse_spaces): (parse_integer): (compute_float_conv): (search_subformat_end): (check_no_0): (opt_of_pad): (get_prec_opt): (else.switch.case.99.char_format): (else.switch.scan_format): (parse_conversion): (set_flag): (parse_flags): (is_int_base): (counter_of_char): (add_range): (fail_single_percent): (parse_char_set_after_char): (parse_char_set_content): (parse_char_set_start): (parse_char_set): (check_open_box): (parse_tag): (fmt_ebb_of_string): (format_of_string_fmtty): (format_of_string_format): (caret): (caml_ml_open_descriptor_in): (caml_ml_open_descriptor_out): (caml_ml_flush): (node_std_output): (caml_ml_output_char): (caml_ml_input): (caml_ml_input_char): (caml_ml_out_channels_list): (fail): (caml_lex_array): (caml_lex_engine): (caml_lex_run_mem): (caml_lex_run_tag): (caml_new_lex_engine): (caml_obj_dup): (caml_obj_truncate): (caml_lazy_make_forward): (caml_update_dummy): (caml_int_compare): (caml_compare): (caml_equal): (caml_notequal): (caml_greaterequal): (caml_lessequal): (else.aux): (caml_get_public_method): (caml_parse_engine): (caml_set_parser_trace): (js_string_of_char): (caml_string_get): (caml_create_string): (caml_string_compare): (caml_fill_string): (caml_blit_string): (caml_blit_bytes): (bytes_of_string): (bytes_to_string): (caml_string_of_char_array): (caml_is_printable): (caml_string_get16): (caml_string_get32): (repeat): (chr): (app): (js): (curry_1): (_1): (js1): (__1): (curry_2): (_2): (js2): (__2): (curry_3): (_3): (js3): (__3): (curry_4): (_4): (js4): (__4): (curry_5): (_5): (js5): (__5): (curry_6): (_6): (js6): (__6): (curry_7): (_7): (js7): (__7): (curry_8): (_8): (js8): (__8): (stream): (eos): (skip): (read): (peek): (string_of_byte): (position): (region): (error): (guard): (get 1): (get expect): (get illegal): (at): (u32): (u64): (get require): (vuN): (get var): (vsN): (vu32): (vs32): (vs64): (f32): (f64): (len32): (string): (opt): (vec): (sized): (value_type): (elem_type): (stack_type): (table_type): (memory_type): (mutability.get if): (mutability): (instr.get if): (instr_block): (const): (id): (section): (type_section): (import_kind.get if): (import_section): (func_section): (table_section): (memory_section): (global): (global_section): (export_kind.get if): (export_section): (start_section): (local): (code): (code_section): (table_segment): (elem_section): (memory_segment): (data_section): (partial_arg.1): (custom): (custom_section): (iterate): (decode): (patch): (encode.u8): (encode.u16): (encode.u32): (encode.vu64): (encode.vs64): (encode.vu32): (encode.len): (encode.bool): (encode.string): (encode.vec): (encode.gap32): (encode.patch_gap32): (encode.value_type): (encode.stack_type): (encode.func_type): (encode.limits): (encode.table_type): (encode.memory_type): (encode.global_type): (encode.memop): (encode): (encode.instr): (encode.const): (encode.section): (encode.type_section): (encode.import): (encode.import_section): (encode.func): (encode.func_section): (encode.table): (encode.table_section): (encode.memory): (encode.memory_section): (encode.global): (encode.global_section): (encode.export_kind): (encode.export): (encode.export_section): (encode.start_section): (encode.combine): (encode.compress): (encode.local): (encode.code): (encode.code_section): (encode.segment): (encode.table_segment): (encode.elem_section): (encode.memory_segment): (encode.module_): (Make.warn): (Make.error): (Make): (print_nan_significand_digits): (Make.of_bits): (Make.to_bits): (Make.is_nan): (Make.canonicalize_nan): (Make.determine_binary_nan): (Make.determine_unary_nan): (Make.binary): (Make.unary): (Make.add): (Make.sub): (Make.mul): (Make.div): (Make.sqrt): (Make.ceil): (Make.floor): (Make.trunc): (Make.nearest): (Make.min): (Make.max): (Make.abs): (Make.neg): (Make.copysign): (Make.eq): (Make.ne): (Make.lt): (Make.gt): (Make.le): (Make.ge): (Make.of_signless_string): (Make.of_string): (Make.to_string): (add_queue): (peek_queue): (take_queue): (pp_enqueue): (pp_clear_queue): (pp_output_string): (break_new_line): (break_same_line): (pp_force_break_line): (switch.add_tab): (else.switch.find): (format_pp_token): (advance_left): (enqueue_advance): (enqueue_string_as): (set_size): (scan_push): (pp_open_box_gen): (pp_close_box): (pp_open_tag): (pp_close_tag): (pp_set_print_tags): (pp_set_mark_tags): (pp_get_print_tags): (pp_get_mark_tags): (pp_set_tags): (pp_get_formatter_tag_functions): (pp_set_formatter_tag_functions): (pp_rinit): (pp_flush_queue): (pp_print_as_size): (pp_print_string): (pp_print_int): (pp_print_float): (pp_print_bool): (pp_open_hbox): (pp_open_vbox): (pp_open_hvbox): (pp_open_hovbox): (pp_open_box): (pp_print_newline): (pp_print_flush): (pp_force_newline): (pp_print_if_newline): (pp_print_break): (pp_print_space): (pp_print_cut): (pp_open_tbox): (pp_close_tbox): (pp_print_tbreak): (pp_print_tab): (pp_set_tab): (pp_print_list): (flush): (pp_print_text): (pp_set_max_boxes): (pp_get_max_boxes): (pp_over_max_boxes): (pp_get_ellipsis_text): (pp_limit): (pp_set_max_indent): (pp_get_max_indent): (pp_set_margin): (pp_get_margin): (pp_set_formatter_out_functions): (pp_get_formatter_out_functions): (pp_set_formatter_output_functions): (pp_get_formatter_output_functions): (pp_set_all_formatter_output_functions): (pp_get_all_formatter_output_functions): (display_newline): (display_blanks): (state.16): (state.17): (state.18): (state.19): (pp_set_formatter_out_channel): (default_pp_mark_open_tag): (default_pp_mark_close_tag): (default_pp_print_open_tag): (default_pp_print_close_tag): (pp_make_formatter): (ppf.18): (ppf.19): (make_formatter): (formatter_of_out_channel): (formatter_of_buffer): (flush_str_formatter): (flush_buf_formatter): (open_hbox): (open_vbox): (open_hvbox): (open_hovbox): (open_box): (close_box): (open_tag): (close_tag): (print_as): (print_string): (print_int): (print_float): (print_bool): (print_cut): (print_space): (force_newline): (print_flush): (print_newline): (print_if_newline): (open_tbox): (close_tbox): (print_tbreak): (set_tab): (print_tab): (set_margin): (get_margin): (set_max_indent): (get_max_indent): (set_max_boxes): (get_max_boxes): (over_max_boxes): (set_ellipsis_text): (get_ellipsis_text): (set_formatter_out_channel): (set_formatter_out_functions): (get_formatter_out_functions): (set_formatter_output_functions): (get_formatter_output_functions): (set_all_formatter_output_functions): (get_all_formatter_output_functions): (set_formatter_tag_functions): (get_formatter_tag_functions): (set_print_tags): (get_print_tags): (set_mark_tags): (get_mark_tags): (set_tags): (compute_tag): (output_formatting_lit): (kfprintf): (ikfprintf): (fprintf): (ifprintf): (printf): (eprintf): (k.prime): (ksprintf): (sprintf): (asprintf.k.prime): (asprintf): (k): (bprintf): (succ): (pred): (abs): (lognot): (Make.cmp_u): (Make.divrem_u): (Make.div_s): (Make.div_u): (Make.rem_s): (Make.rem_u): (Make.shift): (Make.shl): (Make.shr_s): (Make.shr_u): (Make.clamp_rotate_count): (Make.rotl): (Make.rotr): (Make.loop): (Make.clz): (Make.ctz): (Make.popcnt): (Make.eqz): (Make.lt_u): (Make.le_u): (Make.gt_u): (Make.ge_u): (Make.of_int_u): (Make.to_string_u): (Make.require): (Make.dec_digit): (Make.hex_digit): (Make.parse_int): (Make.of_string_s): (Make.of_string_u): (convert_pos): (error_nest): (text): (intop): (floatop): (numop): (memsz): (ext): (token.else.switch): (token.else.switch.): (token): (__ocaml_lex_comment_rec): (engine): (new_engine): (from_function): (from_channel): (from_string): (lexeme): (sub_lexeme): (sub_lexeme_opt): (sub_lexeme_char): (sub_lexeme_char_opt): (lexeme_char): (lexeme_start): (lexeme_end): (lexeme_start_p): (lexeme_end_p): (new_line): (flush_input): (take): (drop): (last): (split_last): (index_of): (index_of_int32): (dim): (set 1): (get 2): (log2): (is_power_of_two): (loop): (breakup): (hd): (tl): (rev_append): (rev): (flatten): (rev_map): (map2): (rev_map2): (iter2): (fold_left2): (fold_right2): (for_all): (exists): (for_all2): (exists2): (mem): (memq): (assoc): (assq): (mem_assoc): (mem_assq): (remove_assoc): (remove_assq): (find): (find_all): (partition): (split): (combine): (chop): (rev_sort): (sort_uniq): (Make.height): (Make.create): (Make.singleton): (Make.bal): (Make.is_empty): (Make.find): (Make.mem): (Make.min_binding): (Make.max_binding): (Make.remove_min_binding): (Make.remove): (Make.iter): (Make.map): (Make.mapi): (Make.fold): (Make.for_all): (Make.exists): (Make.add_min_binding): (Make.add_max_binding): (Make.join): (Make.concat): (Make.concat_or_join): (Make.split): (Make.merge): (Make.filter): (Make.partition): (Make.cons_enum): (Make.compare): (Make.equal): (Make.cardinal): (Make.bindings_aux): (Make.bindings): (double_field): (set_double_field): (marshal): (unmarshal): (extension_slot): (extension_name): (extension_id): (i32_const): (i64_const): (f32_const): (f64_const): (block): (br): (br_if): (br_table): (if_): (call): (call_indirect): (get_local): (set_local): (tee_local): (get_global): (set_global): (i32_load): (i64_load): (f32_load): (f64_load): (i32_load8_s): (i32_load8_u): (i32_load16_s): (i32_load16_u): (i64_load8_s): (i64_load8_u): (i64_load16_s): (i64_load16_u): (i64_load32_s): (i64_load32_u): (i32_store): (i64_store): (f32_store): (f64_store): (i32_store8): (i32_store16): (i64_store8): (i64_store16): (i64_store32): (parse): (string_to): (string_to_script): (string_to_module): (parse_error): (position_to_pos): (positions_to_region): (ati): (nat): (nat32): (empty_context): (enter_func): (type_): (lookup): (label): (anon_type): (bind): (bind_func): (bind_local): (bind_global): (bind_table): (bind_memory): (anon): (anon_func): (anon_locals): (anon_global): (anon_table): (anon_memory): (anon_label): (explicit_sig): (inline_type): (yyact): (script1): (module1): (grow_stacks): (clear_parser): (current_lookahead_fun): (catch.else.current_lookahead_fun.0): (yyparse): (peek_val): (symbol_start_pos): (symbol_end_pos): (rhs_start_pos): (rhs_end_pos): (symbol_start): (symbol_end): (rhs_start): (rhs_end): (is_current_lookahead): (failwith): (invalid_arg): (min): (max): (lnot): (char_of_int): (string_of_bool): (bool_of_string): (string_of_int): (valid_float_lexem): (string_of_float): (open_out_gen): (open_out): (open_out_bin): (flush_all): (output_bytes): (output_string): (output): (output_substring): (output_value): (close_out): (close_out_noerr): (open_in_gen): (open_in): (open_in_bin): (input): (else.r): (unsafe_really_input): (really_input): (really_input_string): (input_line.build_result): (input_line.n): (input_line.scan): (input_line): (close_in_noerr): (print_bytes): (print_endline): (prerr_char): (prerr_string): (prerr_bytes): (prerr_int): (prerr_float): (prerr_endline): (prerr_newline): (read_line): (read_int): (read_float): (string_of_format): (at_exit.exit_function.0): (at_exit): (do_at_exit): (exit): (output_binary_int): (seek_out): (pos_out): (out_channel_length): (set_binary_mode_out): (input_binary_int): (input_value): (seek_in): (pos_in): (in_channel_length): (close_in): (set_binary_mode_in): (LargeFile_000): (LargeFile_001): (LargeFile_002): (LargeFile_003): (LargeFile_004): (LargeFile_005): (kbprintf): (plus): (pp): (print): (string_of_pos): (string_of_region): (escaped.needs_escape): (set_signal): (catch_break): (size): (string_of_value_type): (string_of_value_types): (string_of_elem_type): (string_of_limits): (string_of_table_type): (string_of_global_type): (string_of_stack_type): (string_of_func_type): (type_of): (default_value): (value_of_bool): (string_of_values): (to_value): (of_value): (g): (binary): (bytes): * JSTests/wasm/simd-spec-tests/simd_address.wast.js: Renamed from JSTests/wasm/spec-tests/simd_address.wast.js. * JSTests/wasm/simd-spec-tests/simd_align.wast.js: Renamed from JSTests/wasm/spec-tests/simd_align.wast.js. * JSTests/wasm/simd-spec-tests/simd_bit_shift.wast.js: Renamed from JSTests/wasm/spec-tests/simd_bit_shift.wast.js. * JSTests/wasm/simd-spec-tests/simd_bitwise.wast.js: Renamed from JSTests/wasm/spec-tests/simd_bitwise.wast.js. * JSTests/wasm/simd-spec-tests/simd_boolean.wast.js: Renamed from JSTests/wasm/spec-tests/simd_boolean.wast.js. * JSTests/wasm/simd-spec-tests/simd_const.wast.js: Renamed from JSTests/wasm/spec-tests/simd_const.wast.js. * JSTests/wasm/simd-spec-tests/simd_conversions.wast.js: Renamed from JSTests/wasm/spec-tests/simd_conversions.wast.js. * JSTests/wasm/simd-spec-tests/simd_f32x4.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f32x4.wast.js. * JSTests/wasm/simd-spec-tests/simd_f32x4_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f32x4_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_f32x4_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f32x4_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_f32x4_pmin_pmax.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f32x4_pmin_pmax.wast.js. * JSTests/wasm/simd-spec-tests/simd_f32x4_rounding.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f32x4_rounding.wast.js. * JSTests/wasm/simd-spec-tests/simd_f64x2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f64x2.wast.js. * JSTests/wasm/simd-spec-tests/simd_f64x2_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f64x2_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_f64x2_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f64x2_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_f64x2_pmin_pmax.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f64x2_pmin_pmax.wast.js. * JSTests/wasm/simd-spec-tests/simd_f64x2_rounding.wast.js: Renamed from JSTests/wasm/spec-tests/simd_f64x2_rounding.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_arith2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_arith2.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_extadd_pairwise_i8x16.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_extadd_pairwise_i8x16.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_extmul_i8x16.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_extmul_i8x16.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_q15mulr_sat_s.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_q15mulr_sat_s.wast.js. * JSTests/wasm/simd-spec-tests/simd_i16x8_sat_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i16x8_sat_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_arith2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_arith2.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_dot_i16x8.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_dot_i16x8.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_extadd_pairwise_i16x8.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_extadd_pairwise_i16x8.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_extmul_i16x8.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_extmul_i16x8.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_trunc_sat_f32x4.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f32x4.wast.js. * JSTests/wasm/simd-spec-tests/simd_i32x4_trunc_sat_f64x2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i32x4_trunc_sat_f64x2.wast.js. * JSTests/wasm/simd-spec-tests/simd_i64x2_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i64x2_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_i64x2_arith2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i64x2_arith2.wast.js. * JSTests/wasm/simd-spec-tests/simd_i64x2_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i64x2_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_i64x2_extmul_i32x4.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i64x2_extmul_i32x4.wast.js. * JSTests/wasm/simd-spec-tests/simd_i8x16_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i8x16_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_i8x16_arith2.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i8x16_arith2.wast.js. * JSTests/wasm/simd-spec-tests/simd_i8x16_cmp.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i8x16_cmp.wast.js. * JSTests/wasm/simd-spec-tests/simd_i8x16_sat_arith.wast.js: Renamed from JSTests/wasm/spec-tests/simd_i8x16_sat_arith.wast.js. * JSTests/wasm/simd-spec-tests/simd_int_to_int_extend.wast.js: Renamed from JSTests/wasm/spec-tests/simd_int_to_int_extend.wast.js. * JSTests/wasm/simd-spec-tests/simd_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_load.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load.wast.js. * JSTests/wasm/simd-spec-tests/simd_load16_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load16_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_load32_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load32_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_load64_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load64_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_load8_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load8_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_load_extend.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load_extend.wast.js. * JSTests/wasm/simd-spec-tests/simd_load_splat.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load_splat.wast.js. * JSTests/wasm/simd-spec-tests/simd_load_zero.wast.js: Renamed from JSTests/wasm/spec-tests/simd_load_zero.wast.js. * JSTests/wasm/simd-spec-tests/simd_splat.wast.js: Renamed from JSTests/wasm/spec-tests/simd_splat.wast.js. * JSTests/wasm/simd-spec-tests/simd_store.wast.js: Renamed from JSTests/wasm/spec-tests/simd_store.wast.js. * JSTests/wasm/simd-spec-tests/simd_store16_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_store16_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_store32_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_store32_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_store64_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_store64_lane.wast.js. * JSTests/wasm/simd-spec-tests/simd_store8_lane.wast.js: Renamed from JSTests/wasm/spec-tests/simd_store8_lane.wast.js. * JSTests/wasm/spec-harness/async_index.js: (externref): (is_externref): (is_funcref): (eq_externref): (eq_funcref): (exports): (then.): (reinitializeRegistry.get promise_test): (reinitializeRegistry): (get const): * JSTests/wasm/spec-harness/sync_index.js: (externref): (is_externref): (is_funcref): (eq_externref): (eq_funcref): * JSTests/wasm/spec-tests/address.wast.js: * JSTests/wasm/spec-tests/align.wast.js: * JSTests/wasm/spec-tests/binary-leb128.wast.js: * JSTests/wasm/spec-tests/binary.wast.js: * JSTests/wasm/spec-tests/block.wast.js: * JSTests/wasm/spec-tests/br.wast.js: * JSTests/wasm/spec-tests/br_if.wast.js: * JSTests/wasm/spec-tests/br_table.wast.js: * JSTests/wasm/spec-tests/bulk.wast.js: Added. * JSTests/wasm/spec-tests/call.wast.js: * JSTests/wasm/spec-tests/call_indirect.wast.js: * JSTests/wasm/spec-tests/comments.wast.js: * JSTests/wasm/spec-tests/const.wast.js: * JSTests/wasm/spec-tests/conversions.wast.js: * JSTests/wasm/spec-tests/custom.wast.js: * JSTests/wasm/spec-tests/data.wast.js: * JSTests/wasm/spec-tests/elem.wast.js: * JSTests/wasm/spec-tests/endianness.wast.js: * JSTests/wasm/spec-tests/exports.wast.js: * JSTests/wasm/spec-tests/f32.wast.js: * JSTests/wasm/spec-tests/f32_bitwise.wast.js: * JSTests/wasm/spec-tests/f32_cmp.wast.js: * JSTests/wasm/spec-tests/f64.wast.js: * JSTests/wasm/spec-tests/f64_bitwise.wast.js: * JSTests/wasm/spec-tests/f64_cmp.wast.js: * JSTests/wasm/spec-tests/fac.wast.js: * JSTests/wasm/spec-tests/float_exprs.wast.js: * JSTests/wasm/spec-tests/float_literals.wast.js: * JSTests/wasm/spec-tests/float_memory.wast.js: * JSTests/wasm/spec-tests/float_misc.wast.js: * JSTests/wasm/spec-tests/func.wast.js: * JSTests/wasm/spec-tests/global.wast.js: * JSTests/wasm/spec-tests/i32.wast.js: * JSTests/wasm/spec-tests/i64.wast.js: * JSTests/wasm/spec-tests/if.wast.js: * JSTests/wasm/spec-tests/imports.wast.js: * JSTests/wasm/spec-tests/int_exprs.wast.js: * JSTests/wasm/spec-tests/int_literals.wast.js: * JSTests/wasm/spec-tests/linking.wast.js: * JSTests/wasm/spec-tests/local_get.wast.js: * JSTests/wasm/spec-tests/local_set.wast.js: * JSTests/wasm/spec-tests/local_tee.wast.js: * JSTests/wasm/spec-tests/loop.wast.js: * JSTests/wasm/spec-tests/memory.wast.js: * JSTests/wasm/spec-tests/memory_copy.wast.js: Added. * JSTests/wasm/spec-tests/memory_fill.wast.js: Added. * JSTests/wasm/spec-tests/memory_grow.wast.js: * JSTests/wasm/spec-tests/memory_init.wast.js: Added. * JSTests/wasm/spec-tests/memory_redundancy.wast.js: * JSTests/wasm/spec-tests/memory_trap.wast.js: * JSTests/wasm/spec-tests/ref_func.wast.js: Added. * JSTests/wasm/spec-tests/ref_is_null.wast.js: Added. * JSTests/wasm/spec-tests/ref_null.wast.js: Added. * JSTests/wasm/spec-tests/return.wast.js: * JSTests/wasm/spec-tests/select.wast.js: * JSTests/wasm/spec-tests/stack.wast.js: * JSTests/wasm/spec-tests/switch.wast.js: * JSTests/wasm/spec-tests/table-sub.wast.js: Added. * JSTests/wasm/spec-tests/table.wast.js: * JSTests/wasm/spec-tests/table_copy.wast.js: Added. * JSTests/wasm/spec-tests/table_fill.wast.js: Added. * JSTests/wasm/spec-tests/table_get.wast.js: Added. * JSTests/wasm/spec-tests/table_grow.wast.js: Added. * JSTests/wasm/spec-tests/table_init.wast.js: Added. * JSTests/wasm/spec-tests/table_set.wast.js: Added. * JSTests/wasm/spec-tests/table_size.wast.js: Added. * JSTests/wasm/spec-tests/tokens.wast.js: Added. * JSTests/wasm/spec-tests/traps.wast.js: * JSTests/wasm/spec-tests/unreachable.wast.js: * JSTests/wasm/spec-tests/unreached-invalid.wast.js: * JSTests/wasm/spec-tests/unreached-valid.wast.js: Added. * JSTests/wasm/threads-spec-harness.js: Added. (import.string_appeared_here.then): (test): (promise_test): (let.assert_unreached): (let.console.log): * JSTests/wasm/threads-spec-harness/async_index.js: Copied from JSTests/wasm/spec-harness/async_index.js. (let.testNum): (uniqueTest): (assertThrows): (binary): (module): (assert_invalid): (instance): (exports): (reinitializeRegistry.get promise_test): (reinitializeRegistry): (catch): (assert_exhaustion): (get const): * JSTests/wasm/threads-spec-harness/sync_index.js: Copied from JSTests/wasm/spec-harness/sync_index.js. (let.testNum): (assertThrows): (_assert): (ValueResult): (ErrorResult): (Result.prototype.isError): (reinitializeRegistry.let.handler.get return): (binary): (module): * JSTests/wasm/threads-spec-harness/wasm-constants.js: Added. (hostref): (bytes): (bytesWithHeader): (makeSig): (makeSig_v_x): (makeSig_v_xx): (makeSig_r_v): (makeSig_r_x): (makeSig_r_xx): (assertTraps): (assertWasmThrows): * JSTests/wasm/threads-spec-harness/wasm-module-builder.js: Added. (Binary.prototype.emit_u8): (Binary.prototype.emit_u16): (Binary.prototype.emit_u32): (Binary.prototype.emit_u32v): (Binary.prototype.emit_bytes): (Binary.prototype.emit_string): (Binary.prototype.emit_header): (Binary.prototype.emit_section): (Binary): (WasmFunctionBuilder): (WasmFunctionBuilder.prototype.exportAs): (WasmFunctionBuilder.prototype.exportFunc): (WasmFunctionBuilder.prototype.addBody): (WasmFunctionBuilder.prototype.addLocals): (WasmFunctionBuilder.prototype.end): (WasmGlobalBuilder): (WasmGlobalBuilder.prototype.exportAs): (WasmModuleBuilder): (WasmModuleBuilder.prototype.addStart): (WasmModuleBuilder.prototype.addMemory): (WasmModuleBuilder.prototype.addExplicitSection): (WasmModuleBuilder.prototype.stringToBytes): (WasmModuleBuilder.prototype.addCustomSection): (WasmModuleBuilder.prototype.addType): (WasmModuleBuilder.prototype.addGlobal): (WasmModuleBuilder.prototype.addFunction): (WasmModuleBuilder.prototype.addImport): (WasmModuleBuilder.prototype.addImportedGlobal): (WasmModuleBuilder.prototype.addImportedMemory): (WasmModuleBuilder.prototype.addImportedTable): (WasmModuleBuilder.prototype.addExport): (WasmModuleBuilder.prototype.addExportOfKind): (WasmModuleBuilder.prototype.addDataSegment): (WasmModuleBuilder.prototype.exportMemoryAs): (WasmModuleBuilder.prototype.addFunctionTableInit): (WasmModuleBuilder.prototype.appendToTable): (WasmModuleBuilder.prototype.setFunctionTableLength): (WasmModuleBuilder.prototype.toArray): (WasmModuleBuilder.prototype.toBuffer): (WasmModuleBuilder.prototype.instantiate): * JSTests/wasm/threads-spec-harness/wast.js: Added. (normalize): (require.else._registry.name): (require): (add_hex_char): (add_char): (string_with): (list_of_opt): (break_bytes.f): (break_bytes): (f): (decls): (func_type): (limits): (global_type): (testop): (relop): (unop): (binop): (cvtop): (oper): (mem_size): (extension): (memop): (storeop): (var): (constop): (instr.else.switch.case.0.f): (instr.else.switch.case.1.f.1): (instr.else.switch.case.2.f.2): (instr): (func_with_name): (func): (start): (table): (memory): (segment): (elems): (data): (typedef): (import_kind): (import): (export_kind): (export): (var_opt): (is_func_import): (is_table_import): (is_memory_import): (is_global_import): (f.1): (f.2): (f.3): (module_with_var_opt): (module_): (literal): (definition): (access): (action): (script): (_registry.string_appeared_here): (init): (make_matrix): (copy): (append): (sub): (fill): (blit): (iter): (map): (iteri): (mapi): (to_list): (list_length): (of_list): (fold_left): (fold_right): (maxson): (trickle): (bubble): (trickleup): (sort): (merge): (isortto): (sortto): (stable_sort): (import_type): (export_type): (dims.n): (dims.d.i): (dims): (map_file): (create): (of_array): (slice_left): (slice_right): (slice_left_1): (slice_right_1): (slice_left_2): (slice_right_2): (array1_of_genarray): (array2_of_genarray): (array3_of_genarray): (reshape_1): (reshape_2): (reshape_3): (reshape): (__): (contents): (to_bytes): (nth): (length): (clear): (reset): (resize): (add_substring): (add_subbytes): (add_string): (add_bytes): (add_buffer): (add_channel): (output_buffer): (closing): (advance_to_closing): (advance_to_non_alpha): (find_ident): (add_substitute): (make): (to_string): (of_string): (sub_string): (extend): (blit_string): (concat): (cat): (is_space): (trim): (escaped): (uppercase): (lowercase): (apply1): (capitalize): (uncapitalize): (index_rec): (index): (index_from): (rindex_rec): (rindex): (rindex_from): (contains_from): (contains): (rcontains_from): (caml_array_sub): (len): (caml_array_concat): (caml_make_vect): (caml_array_blit): (get if): (caml_set_oo_id): (get_id): (caml_int32_float_of_bits): (caml_int32_bits_of_float): (caml_classify_float): (caml_modf_float): (caml_ldexp_float): (caml_frexp_float): (caml_copysign_float): (caml_expm1_float): (caml_hypot_float): (caml_log10_float): (caml_failwith): (parse_digit): (int_of_string_base): (parse_sign_and_base): (caml_int_of_string.aux): (caml_int_of_string): (caml_int64_of_string.aux): (caml_int64_of_string): (int_of_base): (parse_format): (finish_formatting): (caml_format_int): (caml_int64_format): (caml_format_float): (float_of_string): (div): (mod_): (caml_bswap16): (caml_int32_bswap): (imul): (neg_signed): (not): (eq): (neg): (lsl_): (lsr_): (asr_): (is_zero): (mul): (swap): (xor): (or_): (and_): (ge): (lt): (gt): (le): (to_float): (of_float): (div_mod): (compare): (of_int32): (to_int32): (to_hex.aux): (to_hex): (discard_sign): (float_of_bits): (bits_of_float.to_nat): (bits_of_float): (get64): (erase_rel): (concat_fmtty): (concat_fmt): (create_char_set): (add_in_char_set): (rev_char_set): (is_in_char_set): (prec_of_prec_opt): (param_format_of_ignored_format): (buffer_check_size): (buffer_add_char): (buffer_add_string): (buffer_contents): (char_of_iconv): (char_of_fconv): (char_of_counter): (print_char): (set while.set var): (set while.set else): (set var): (set else): (set print_char): (set if): (bprint_padty): (bprint_ignored_flag): (bprint_pad_opt): (bprint_padding): (bprint_precision): (bprint_iconv_flag): (bprint_int_fmt): (bprint_altint_fmt): (bprint_fconv_flag): (bprint_float_fmt): (string_of_formatting_lit): (string_of_formatting_gen): (bprint_char_literal): (bprint_string_literal): (bprint_fmtty): (int_of_custom_arity): (bprint_fmt): (string_of_fmt): (symm): (fmtty_rel_det): (trans): (fmtty_of_formatting_gen): (fmtty_of_fmt): (fmtty_of_custom): (fmtty_of_padding_fmtty): (fmtty_of_precision_fmtty): (type_padding): (type_padprec): (type_ignored_param_one): (type_format_gen): (type_ignored_format_substitution): (type_format): (recast): (fix_padding): (fix_int_precision): (string_to_caml_string): (format_of_iconv): (format_of_aconv): (format_of_fconv): (convert_int): (convert_int32): (convert_nativeint): (convert_int64): (else.is_valid): (convert_float): (format_caml_char): (string_of_fmtty): (else.switch.): (else.switch.k.prime): (else.switch.else.): (else.switch.else.k.prime.1): (make_printf): (make_from_fmtty): (make_invalid_arg): (make_string_padding): (make_int_padding_precision): (make_custom): (output_acc): (bufput_acc): (strput_acc): (failwith_message.k): (failwith_message): (open_box_of_string.else.invalid_box): (open_box_of_string.else.parse_spaces): (open_box_of_string.else.parse_lword): (open_box_of_string.else.parse_int): (open_box_of_string): (make_padding_fmt_ebb): (make_precision_fmt_ebb): (make_padprec_fmt_ebb): (invalid_format_message): (invalid_format_without): (expected_character): (compute_int_conv): (incompatible_flag): (parse_positive): (parse_conv): (parse_after_precision): (else.parse_literal): (parse_after_padding): (parse_literal): (parse_after_at): (add_literal): (parse_spaces): (parse_integer): (compute_float_conv): (search_subformat_end): (check_no_0): (opt_of_pad): (get_prec_opt): (else.switch.case.99.char_format): (else.switch.scan_format): (parse_conversion): (set_flag): (parse_flags): (is_int_base): (counter_of_char): (add_range): (fail_single_percent): (parse_char_set_after_char): (parse_char_set_content): (parse_char_set_start): (parse_char_set): (check_open_box): (parse_tag): (fmt_ebb_of_string): (format_of_string_fmtty): (format_of_string_format): (caret): (caml_ml_open_descriptor_in): (caml_ml_open_descriptor_out): (caml_ml_flush): (node_std_output): (caml_ml_output_char): (caml_ml_input): (caml_ml_input_char): (caml_ml_out_channels_list): (fail): (caml_lex_array): (caml_lex_engine): (caml_lex_run_mem): (caml_lex_run_tag): (caml_new_lex_engine): (caml_obj_dup): (caml_obj_truncate): (caml_lazy_make_forward): (caml_update_dummy): (caml_int_compare): (caml_compare): (caml_equal): (caml_notequal): (caml_greaterequal): (caml_lessequal): (else.aux): (caml_get_public_method): (caml_parse_engine): (caml_set_parser_trace): (js_string_of_char): (caml_string_get): (caml_create_string): (caml_string_compare): (caml_fill_string): (caml_blit_string): (caml_blit_bytes): (bytes_of_string): (bytes_to_string): (caml_string_of_char_array): (caml_is_printable): (caml_string_get16): (caml_string_get32): (repeat): (chr): (app): (js): (curry_1): (_1): (js1): (__1): (curry_2): (_2): (js2): (__2): (curry_3): (_3): (js3): (__3): (curry_4): (_4): (js4): (__4): (curry_5): (_5): (js5): (__5): (curry_6): (_6): (js6): (__6): (curry_7): (_7): (js7): (__7): (curry_8): (_8): (js8): (__8): (stream): (eos): (skip): (read): (peek): (string_of_byte): (position): (region): (error): (guard): (get 1): (get expect): (get illegal): (at): (u32): (u64): (get require): (vuN): (get var): (vsN): (vu32): (vs32): (vs64): (f32): (f64): (len32): (string): (opt): (vec): (sized): (value_type): (elem_type): (stack_type): (table_type): (memory_type): (mutability.get if): (mutability): (instr.get if): (instr_block): (const): (id): (section): (type_section): (import_kind.get if): (import_section): (func_section): (table_section): (memory_section): (global): (global_section): (export_kind.get if): (export_section): (start_section): (local): (code): (code_section): (table_segment): (elem_section): (memory_segment): (data_section): (partial_arg.1): (custom): (custom_section): (iterate): (decode): (patch): (encode.u8): (encode.u16): (encode.u32): (encode.vu64): (encode.vs64): (encode.vu32): (encode.len): (encode.bool): (encode.string): (encode.vec): (encode.gap32): (encode.patch_gap32): (encode.value_type): (encode.stack_type): (encode.func_type): (encode.limits): (encode.table_type): (encode.memory_type): (encode.global_type): (encode.memop): (encode): (encode.instr): (encode.const): (encode.section): (encode.type_section): (encode.import): (encode.import_section): (encode.func): (encode.func_section): (encode.table): (encode.table_section): (encode.memory): (encode.memory_section): (encode.global): (encode.global_section): (encode.export_kind): (encode.export): (encode.export_section): (encode.start_section): (encode.combine): (encode.compress): (encode.local): (encode.code): (encode.code_section): (encode.segment): (encode.table_segment): (encode.elem_section): (encode.memory_segment): (encode.module_): (Make.warn): (Make.error): (Make): (print_nan_significand_digits): (Make.of_bits): (Make.to_bits): (Make.is_nan): (Make.canonicalize_nan): (Make.determine_binary_nan): (Make.determine_unary_nan): (Make.binary): (Make.unary): (Make.add): (Make.sub): (Make.mul): (Make.div): (Make.sqrt): (Make.ceil): (Make.floor): (Make.trunc): (Make.nearest): (Make.min): (Make.max): (Make.abs): (Make.neg): (Make.copysign): (Make.eq): (Make.ne): (Make.lt): (Make.gt): (Make.le): (Make.ge): (Make.of_signless_string): (Make.of_string): (Make.to_string): (add_queue): (peek_queue): (take_queue): (pp_enqueue): (pp_clear_queue): (pp_output_string): (break_new_line): (break_same_line): (pp_force_break_line): (switch.add_tab): (else.switch.find): (format_pp_token): (advance_left): (enqueue_advance): (enqueue_string_as): (set_size): (scan_push): (pp_open_box_gen): (pp_close_box): (pp_open_tag): (pp_close_tag): (pp_set_print_tags): (pp_set_mark_tags): (pp_get_print_tags): (pp_get_mark_tags): (pp_set_tags): (pp_get_formatter_tag_functions): (pp_set_formatter_tag_functions): (pp_rinit): (pp_flush_queue): (pp_print_as_size): (pp_print_string): (pp_print_int): (pp_print_float): (pp_print_bool): (pp_open_hbox): (pp_open_vbox): (pp_open_hvbox): (pp_open_hovbox): (pp_open_box): (pp_print_newline): (pp_print_flush): (pp_force_newline): (pp_print_if_newline): (pp_print_break): (pp_print_space): (pp_print_cut): (pp_open_tbox): (pp_close_tbox): (pp_print_tbreak): (pp_print_tab): (pp_set_tab): (pp_print_list): (flush): (pp_print_text): (pp_set_max_boxes): (pp_get_max_boxes): (pp_over_max_boxes): (pp_get_ellipsis_text): (pp_limit): (pp_set_max_indent): (pp_get_max_indent): (pp_set_margin): (pp_get_margin): (pp_set_formatter_out_functions): (pp_get_formatter_out_functions): (pp_set_formatter_output_functions): (pp_get_formatter_output_functions): (pp_set_all_formatter_output_functions): (pp_get_all_formatter_output_functions): (display_newline): (display_blanks): (state.16): (state.17): (state.18): (state.19): (pp_set_formatter_out_channel): (default_pp_mark_open_tag): (default_pp_mark_close_tag): (default_pp_print_open_tag): (default_pp_print_close_tag): (pp_make_formatter): (ppf.18): (ppf.19): (make_formatter): (formatter_of_out_channel): (formatter_of_buffer): (flush_str_formatter): (flush_buf_formatter): (open_hbox): (open_vbox): (open_hvbox): (open_hovbox): (open_box): (close_box): (open_tag): (close_tag): (print_as): (print_string): (print_int): (print_float): (print_bool): (print_cut): (print_space): (force_newline): (print_flush): (print_newline): (print_if_newline): (open_tbox): (close_tbox): (print_tbreak): (set_tab): (print_tab): (set_margin): (get_margin): (set_max_indent): (get_max_indent): (set_max_boxes): (get_max_boxes): (over_max_boxes): (set_ellipsis_text): (get_ellipsis_text): (set_formatter_out_channel): (set_formatter_out_functions): (get_formatter_out_functions): (set_formatter_output_functions): (get_formatter_output_functions): (set_all_formatter_output_functions): (get_all_formatter_output_functions): (set_formatter_tag_functions): (get_formatter_tag_functions): (set_print_tags): (get_print_tags): (set_mark_tags): (get_mark_tags): (set_tags): (compute_tag): (output_formatting_lit): (kfprintf): (ikfprintf): (fprintf): (ifprintf): (printf): (eprintf): (k.prime): (ksprintf): (sprintf): (asprintf.k.prime): (asprintf): (k): (bprintf): (succ): (pred): (abs): (lognot): (Make.cmp_u): (Make.divrem_u): (Make.div_s): (Make.div_u): (Make.rem_s): (Make.rem_u): (Make.shift): (Make.shl): (Make.shr_s): (Make.shr_u): (Make.clamp_rotate_count): (Make.rotl): (Make.rotr): (Make.loop): (Make.clz): (Make.ctz): (Make.popcnt): (Make.eqz): (Make.lt_u): (Make.le_u): (Make.gt_u): (Make.ge_u): (Make.of_int_u): (Make.to_string_u): (Make.require): (Make.dec_digit): (Make.hex_digit): (Make.parse_int): (Make.of_string_s): (Make.of_string_u): (convert_pos): (error_nest): (text): (intop): (floatop): (numop): (memsz): (ext): (token.else.switch): (token.else.switch.): (token): (__ocaml_lex_comment_rec): (engine): (new_engine): (from_function): (from_channel): (from_string): (lexeme): (sub_lexeme): (sub_lexeme_opt): (sub_lexeme_char): (sub_lexeme_char_opt): (lexeme_char): (lexeme_start): (lexeme_end): (lexeme_start_p): (lexeme_end_p): (new_line): (flush_input): (take): (drop): (last): (split_last): (index_of): (index_of_int32): (dim): (set 1): (get 2): (log2): (is_power_of_two): (loop): (breakup): (hd): (tl): (rev_append): (rev): (flatten): (rev_map): (map2): (rev_map2): (iter2): (fold_left2): (fold_right2): (for_all): (exists): (for_all2): (exists2): (mem): (memq): (assoc): (assq): (mem_assoc): (mem_assq): (remove_assoc): (remove_assq): (find): (find_all): (partition): (split): (combine): (chop): (rev_sort): (sort_uniq): (Make.height): (Make.create): (Make.singleton): (Make.bal): (Make.is_empty): (Make.find): (Make.mem): (Make.min_binding): (Make.max_binding): (Make.remove_min_binding): (Make.remove): (Make.iter): (Make.map): (Make.mapi): (Make.fold): (Make.for_all): (Make.exists): (Make.add_min_binding): (Make.add_max_binding): (Make.join): (Make.concat): (Make.concat_or_join): (Make.split): (Make.merge): (Make.filter): (Make.partition): (Make.cons_enum): (Make.compare): (Make.equal): (Make.cardinal): (Make.bindings_aux): (Make.bindings): (double_field): (set_double_field): (marshal): (unmarshal): (extension_slot): (extension_name): (extension_id): (i32_const): (i64_const): (f32_const): (f64_const): (block): (br): (br_if): (br_table): (if_): (call): (call_indirect): (get_local): (set_local): (tee_local): (get_global): (set_global): (i32_load): (i64_load): (f32_load): (f64_load): (i32_load8_s): (i32_load8_u): (i32_load16_s): (i32_load16_u): (i64_load8_s): (i64_load8_u): (i64_load16_s): (i64_load16_u): (i64_load32_s): (i64_load32_u): (i32_store): (i64_store): (f32_store): (f64_store): (i32_store8): (i32_store16): (i64_store8): (i64_store16): (i64_store32): (parse): (string_to): (string_to_script): (string_to_module): (parse_error): (position_to_pos): (positions_to_region): (ati): (nat): (nat32): (empty_context): (enter_func): (type_): (lookup): (label): (anon_type): (bind): (bind_func): (bind_local): (bind_global): (bind_table): (bind_memory): (anon): (anon_func): (anon_locals): (anon_global): (anon_table): (anon_memory): (anon_label): (explicit_sig): (inline_type): (yyact): (script1): (module1): (grow_stacks): (clear_parser): (current_lookahead_fun): (catch.else.current_lookahead_fun.0): (yyparse): (peek_val): (symbol_start_pos): (symbol_end_pos): (rhs_start_pos): (rhs_end_pos): (symbol_start): (symbol_end): (rhs_start): (rhs_end): (is_current_lookahead): (failwith): (invalid_arg): (min): (max): (lnot): (char_of_int): (string_of_bool): (bool_of_string): (string_of_int): (valid_float_lexem): (string_of_float): (open_out_gen): (open_out): (open_out_bin): (flush_all): (output_bytes): (output_string): (output): (output_substring): (output_value): (close_out): (close_out_noerr): (open_in_gen): (open_in): (open_in_bin): (input): (else.r): (unsafe_really_input): (really_input): (really_input_string): (input_line.build_result): (input_line.n): (input_line.scan): (input_line): (close_in_noerr): (print_bytes): (print_endline): (prerr_char): (prerr_string): (prerr_bytes): (prerr_int): (prerr_float): (prerr_endline): (prerr_newline): (read_line): (read_int): (read_float): (string_of_format): (at_exit.exit_function.0): (at_exit): (do_at_exit): (exit): (output_binary_int): (seek_out): (pos_out): (out_channel_length): (set_binary_mode_out): (input_binary_int): (input_value): (seek_in): (pos_in): (in_channel_length): (close_in): (set_binary_mode_in): (LargeFile_000): (LargeFile_001): (LargeFile_002): (LargeFile_003): (LargeFile_004): (LargeFile_005): (kbprintf): (plus): (pp): (print): (string_of_pos): (string_of_region): (escaped.needs_escape): (set_signal): (catch_break): (size): (string_of_value_type): (string_of_value_types): (string_of_elem_type): (string_of_limits): (string_of_table_type): (string_of_global_type): (string_of_stack_type): (string_of_func_type): (type_of): (default_value): (value_of_bool): (string_of_values): (to_value): (of_value): (g): (binary): (bytes): * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/258472 at main From noreply at github.com Wed Jan 4 21:10:45 2023 From: noreply at github.com (Sihui) Date: Wed, 04 Jan 2023 21:10:45 -0800 Subject: [webkit-changes] [WebKit/WebKit] acd30c: Make all FileSystemSyncAccessHandle methods sync Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acd30cd156726cd87885b18b46e6c7444e3e4eda https://github.com/WebKit/WebKit/commit/acd30cd156726cd87885b18b46e6c7444e3e4eda Author: Sihui Liu Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker-expected.txt M LayoutTests/storage/filesystemaccess/resources/sync-access-handle-basics.js M LayoutTests/storage/filesystemaccess/resources/sync-access-handle-close.js M LayoutTests/storage/filesystemaccess/resources/sync-access-handle-read-write.js M LayoutTests/storage/filesystemaccess/sync-access-handle-close-worker-expected.txt M LayoutTests/storage/filesystemaccess/sync-access-handle-read-write-worker-expected.txt M Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.h M Source/WebCore/Modules/filesystemaccess/FileSystemStorageConnection.h M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.idl M Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp M Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h Log Message: ----------- Make all FileSystemSyncAccessHandle methods sync https://bugs.webkit.org/show_bug.cgi?id=247071 rdar://problem/101620396 Reviewed by Youenn Fablet. To match latest spec: https://fs.spec.whatwg.org/#api-filesystemsyncaccesshandle. Chrome has already shipped it. * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-flush.https.tentative.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-getSize.https.tentative.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemSyncAccessHandle-truncate.https.tentative.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker-expected.txt: * LayoutTests/storage/filesystemaccess/resources/sync-access-handle-basics.js: * LayoutTests/storage/filesystemaccess/resources/sync-access-handle-close.js: (testFunction): (testFunctions): (async testMultipleHandles): (async test): (testSyncFunction): Deleted. (async testAsyncFunction): Deleted. (async testFunctions): Deleted. * LayoutTests/storage/filesystemaccess/resources/sync-access-handle-read-write.js: (async test): * LayoutTests/storage/filesystemaccess/sync-access-handle-close-worker-expected.txt: * LayoutTests/storage/filesystemaccess/sync-access-handle-read-write-worker-expected.txt: * Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp: (WebCore::FileSystemFileHandle::createSyncAccessHandle): (WebCore::FileSystemFileHandle::closeSyncAccessHandle): * Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.h: * Source/WebCore/Modules/filesystemaccess/FileSystemStorageConnection.h: * Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp: (WebCore::FileSystemSyncAccessHandle::~FileSystemSyncAccessHandle): (WebCore::FileSystemSyncAccessHandle::truncate): (WebCore::FileSystemSyncAccessHandle::getSize): (WebCore::FileSystemSyncAccessHandle::flush): (WebCore::FileSystemSyncAccessHandle::close): (WebCore::FileSystemSyncAccessHandle::closeInternal): (WebCore::FileSystemSyncAccessHandle::read): (WebCore::FileSystemSyncAccessHandle::write): (WebCore::FileSystemSyncAccessHandle::stop): (WebCore::FileSystemSyncAccessHandle::invalidate): (WebCore::FileSystemSyncAccessHandle::isClosingOrClosed const): Deleted. (WebCore::FileSystemSyncAccessHandle::closeFile): Deleted. (WebCore::FileSystemSyncAccessHandle::didCloseFile): Deleted. (WebCore::FileSystemSyncAccessHandle::closeBackend): Deleted. (WebCore::FileSystemSyncAccessHandle::didCloseBackend): Deleted. (WebCore::FileSystemSyncAccessHandle::completePromise): Deleted. * Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h: * Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.idl: * Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp: (WebCore::WorkerFileSystemStorageConnection::closeSyncAccessHandle): * Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.h: * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::closeSyncAccessHandle): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h: * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp: (WebKit::WebFileSystemStorageConnection::closeSyncAccessHandle): * Source/WebKit/WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h: Canonical link: https://commits.webkit.org/258473 at main From noreply at github.com Wed Jan 4 21:13:34 2023 From: noreply at github.com (Simon Fraser) Date: Wed, 04 Jan 2023 21:13:34 -0800 Subject: [webkit-changes] [WebKit/WebKit] cce698: eventSender.monitorWheelEvents({ }) is interpreted... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cce6984b0a67352ec38c934715f0ec306f5a0cd6 https://github.com/WebKit/WebKit/commit/cce6984b0a67352ec38c934715f0ec306f5a0cd6 Author: Simon Fraser Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Tools/DumpRenderTree/mac/EventSendingController.mm M Tools/TestRunnerShared/Bindings/JSBasics.cpp M Tools/TestRunnerShared/Bindings/JSBasics.h Log Message: ----------- eventSender.monitorWheelEvents({ }) is interpreted as eventSender.monitorWheelEvents({ resetLatching: false }) https://bugs.webkit.org/show_bug.cgi?id=250110 rdar://103891736 Reviewed by Wenson Hsieh and Brent Fulgham. booleanProperty(), numericProperty() and objectProperty() would fetch the named property from the given object, but fail to test whether it was the undefined value. `booleanProperty()` would then coerce it to boolean, returning `false` when in fact it should have returned the default value. `numericProperty()` and `objectProperty()` had a similar issue. In DumpRenderTree, this issue occurs in a related way in `-monitorWheelEventsWithOptions:`; for some reason, `-[WebScriptOject valueForKey:]` deliberately triggers an exception when accessing a non-existent key, so catch that exception. * Tools/DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController monitorWheelEventsWithOptions:]): * Tools/TestRunnerShared/Bindings/JSBasics.cpp: (WTR::isValidValue): (WTR::booleanProperty): (WTR::numericProperty): (WTR::objectProperty): * Tools/TestRunnerShared/Bindings/JSBasics.h: Canonical link: https://commits.webkit.org/258474 at main From noreply at github.com Wed Jan 4 21:45:59 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 21:45:59 -0800 Subject: [webkit-changes] [WebKit/WebKit] 0c58dc: [JSC] Add runtime configuration for AirOpcode table Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c58dc81eb53ab2476c1880e291f9964f9ab652e https://github.com/WebKit/WebKit/commit/0c58dc81eb53ab2476c1880e291f9964f9ab652e Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/JavaScriptCore/assembler/ARM64Assembler.h M Source/JavaScriptCore/assembler/ARM64EAssembler.h M Source/JavaScriptCore/assembler/CPU.cpp M Source/JavaScriptCore/assembler/CPU.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/testmasm.cpp M Source/JavaScriptCore/b3/B3Common.cpp M Source/JavaScriptCore/b3/B3LowerMacros.cpp M Source/JavaScriptCore/b3/B3LowerToAir.cpp M Source/JavaScriptCore/b3/air/AirArg.h M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp M Source/JavaScriptCore/b3/air/AirCode.cpp M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/b3/air/opcode_generator.rb M Source/JavaScriptCore/b3/air/testair.cpp M Source/JavaScriptCore/b3/testb3_8.cpp M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/WTF/wtf/PlatformHave.h Log Message: ----------- [JSC] Add runtime configuration for AirOpcode table https://bugs.webkit.org/show_bug.cgi?id=249889 rdar://103702357 Reviewed by Mark Lam. This patch adds arm64_lse and x86_64_avx configurations to AirOpcode table. They are runtime checks: ARM64 LSE is an extension to ARM64, and AVX is an extension to X86_64. AirOpcode table previously only supports compile-time flags. Now, this can generate checks with runtime conditions so that JIT code can select better instructions at runtime. This allows us to integrate 3-operands AVX instructions into X86_64 Air lowering. And this allows ARM64 JIT (not ARM64E) to use LSE (LargeSystemExtension, ARM's term) atomics instructions. * Source/JavaScriptCore/assembler/CPU.cpp: (JSC::isARM64_LSE): (JSC::isX86_64_AVX): * Source/JavaScriptCore/assembler/CPU.h: (JSC::isARM64_LSE): (JSC::isX86_64_AVX): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp: (JSC::MacroAssemblerARM64::collectCPUFeatures): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::atomicXchgAdd8): (JSC::MacroAssemblerARM64::atomicXchgAdd16): (JSC::MacroAssemblerARM64::atomicXchgAdd32): (JSC::MacroAssemblerARM64::atomicXchgAdd64): (JSC::MacroAssemblerARM64::atomicXchgXor8): (JSC::MacroAssemblerARM64::atomicXchgXor16): (JSC::MacroAssemblerARM64::atomicXchgXor32): (JSC::MacroAssemblerARM64::atomicXchgXor64): (JSC::MacroAssemblerARM64::atomicXchgOr8): (JSC::MacroAssemblerARM64::atomicXchgOr16): (JSC::MacroAssemblerARM64::atomicXchgOr32): (JSC::MacroAssemblerARM64::atomicXchgOr64): (JSC::MacroAssemblerARM64::atomicXchgClear8): (JSC::MacroAssemblerARM64::atomicXchgClear16): (JSC::MacroAssemblerARM64::atomicXchgClear32): (JSC::MacroAssemblerARM64::atomicXchgClear64): (JSC::MacroAssemblerARM64::atomicXchg8): (JSC::MacroAssemblerARM64::atomicXchg16): (JSC::MacroAssemblerARM64::atomicXchg32): (JSC::MacroAssemblerARM64::atomicXchg64): (JSC::MacroAssemblerARM64::atomicStrongCAS8): (JSC::MacroAssemblerARM64::atomicStrongCAS16): (JSC::MacroAssemblerARM64::atomicStrongCAS32): (JSC::MacroAssemblerARM64::atomicStrongCAS64): (JSC::MacroAssemblerARM64::supportsLSE): * Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h: (JSC::MacroAssemblerARM64E::ret): (JSC::MacroAssemblerARM64E::atomicXchgAdd8): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgAdd16): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgAdd32): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgAdd64): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgXor8): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgXor16): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgXor32): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgXor64): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgOr8): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgOr16): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgOr32): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgOr64): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgClear8): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgClear16): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgClear32): Deleted. (JSC::MacroAssemblerARM64E::atomicXchgClear64): Deleted. (JSC::MacroAssemblerARM64E::atomicXchg8): Deleted. (JSC::MacroAssemblerARM64E::atomicXchg16): Deleted. (JSC::MacroAssemblerARM64E::atomicXchg32): Deleted. (JSC::MacroAssemblerARM64E::atomicXchg64): Deleted. (JSC::MacroAssemblerARM64E::atomicStrongCAS8): Deleted. (JSC::MacroAssemblerARM64E::atomicStrongCAS16): Deleted. (JSC::MacroAssemblerARM64E::atomicStrongCAS32): Deleted. (JSC::MacroAssemblerARM64E::atomicStrongCAS64): Deleted. * Source/JavaScriptCore/b3/B3LowerMacros.cpp: * Source/JavaScriptCore/b3/B3LowerToAir.cpp: * Source/JavaScriptCore/b3/air/AirCode.cpp: (JSC::B3::Air::defaultPrologueGenerator): * Source/JavaScriptCore/b3/air/AirOpcode.opcodes: * Source/JavaScriptCore/b3/air/opcode_generator.rb: * Source/JavaScriptCore/b3/testb3_8.cpp: (testAtomicWeakCAS): (testAtomicStrongCAS): (testAtomicXchg): * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/258475 at main From noreply at github.com Wed Jan 4 21:52:24 2023 From: noreply at github.com (Ryosuke Niwa) Date: Wed, 04 Jan 2023 21:52:24 -0800 Subject: [webkit-changes] [WebKit/WebKit] b011a6: [Live Range Selection] text recognition tests fail Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b011a6f10fc0dfcb20bff7cf7bc2b1e53f21d5a7 https://github.com/WebKit/WebKit/commit/b011a6f10fc0dfcb20bff7cf7bc2b1e53f21d5a7 Author: Ryosuke Niwa Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html M LayoutTests/fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2-expected.html M LayoutTests/fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html M LayoutTests/fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html Log Message: ----------- [Live Range Selection] text recognition tests fail https://bugs.webkit.org/show_bug.cgi?id=250114 Reviewed by Wenson Hsieh. These tests rely on setBaseAndExtent being able to select contents inside a UA shadow tree, which is no longer true once live range selection is enabled. Use internals.setSelectionWithoutValidation instead. * LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html: * LayoutTests/fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2-expected.html: * LayoutTests/fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html: * LayoutTests/fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html: Canonical link: https://commits.webkit.org/258476 at main From noreply at github.com Wed Jan 4 22:56:29 2023 From: noreply at github.com (Yusuke Suzuki) Date: Wed, 04 Jan 2023 22:56:29 -0800 Subject: [webkit-changes] [WebKit/WebKit] 43198e: [JSC] Wasm Callee should be directly embedded Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43198e5fb9b6e728db732fc9024cc83935370599 https://github.com/WebKit/WebKit/commit/43198e5fb9b6e728db732fc9024cc83935370599 Author: Yusuke Suzuki Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/JavaScriptCore/interpreter/CalleeBits.h M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/llint/WebAssembly.asm M Source/JavaScriptCore/wasm/WasmAirIRGenerator.h M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmB3IRGenerator.h M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmBBQPlan.h M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp M Source/JavaScriptCore/wasm/js/JSToWasm.cpp M Source/JavaScriptCore/wasm/js/JSToWasm.h M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/WTFConfig.h Log Message: ----------- [JSC] Wasm Callee should be directly embedded https://bugs.webkit.org/show_bug.cgi?id=250015 rdar://103821380 Reviewed by Saam Barati. This patch changes Wasm compilers to embed Wasm::Callee bits directly. Since callee can be created while compiling (since this is not a cell), we can just create it and directly embed it during compilation instead of repatching later. This makes compiler simpler and allows compilers to embed pointer with fewer instructions based on its value. Also, this patch changes the CalleeBits::boxWasm encoding a bit: which now decreases lowestAccessibleAddress from the given pointer. This is OK since this is just a C++ pointer (so conservative GC is not affected with this change). By doing this, we can make Wasm::Callee within 32bit in most cases. This allows callee direct embedding to use fewer instructions to embed this in the code. * Source/JavaScriptCore/interpreter/CalleeBits.h: (JSC::CalleeBits::boxWasm): (JSC::CalleeBits::asWasmCallee const): * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/wasm/WasmAirIRGenerator.h: * Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp: (JSC::Wasm::AirIRGenerator32::AirIRGenerator32): (JSC::Wasm::parseAndCompileAir): * Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp: (JSC::Wasm::AirIRGenerator64::AirIRGenerator64): (JSC::Wasm::parseAndCompileAir): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::AirIRGeneratorBase): (JSC::Wasm::parseAndCompileAirImpl): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): (JSC::Wasm::B3IRGenerator::origin): (JSC::Wasm::parseAndCompileB3): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.h: * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::prepareImpl): (JSC::Wasm::BBQPlan::work): (JSC::Wasm::BBQPlan::compileFunction): (JSC::Wasm::BBQPlan::didCompleteCompilation): (JSC::Wasm::BBQPlan::initializeCallees): * Source/JavaScriptCore/wasm/WasmBBQPlan.h: * Source/JavaScriptCore/wasm/WasmCallee.cpp: (JSC::Wasm::Callee::Callee): (JSC::Wasm::JITCallee::JITCallee): * Source/JavaScriptCore/wasm/WasmCallee.h: (JSC::Wasm::JITCallee::setEntrypoint): (JSC::Wasm::OptimizingJITCallee::OptimizingJITCallee): (JSC::Wasm::OptimizingJITCallee::setEntrypoint): * Source/JavaScriptCore/wasm/WasmFormat.h: * Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * Source/JavaScriptCore/wasm/WasmOMGPlan.cpp: (JSC::Wasm::OMGPlan::work): * Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp: (JSC::Wasm::OSREntryPlan::work): * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::createJSToWasmWrapper): * Source/JavaScriptCore/wasm/js/JSToWasm.h: Canonical link: https://commits.webkit.org/258477 at main From noreply at github.com Wed Jan 4 23:09:24 2023 From: noreply at github.com (Chris Fleizach) Date: Wed, 04 Jan 2023 23:09:24 -0800 Subject: [webkit-changes] [WebKit/WebKit] f78fd4: AX: `aria-activedescendant` doesn't work with a st... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f78fd4847fdb47a9159a81e971c8b2af61d8d197 https://github.com/WebKit/WebKit/commit/f78fd4847fdb47a9159a81e971c8b2af61d8d197 Author: Chris Fleizach Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: A LayoutTests/accessibility/mac/active-descendant-with-aria-controls-expected.txt A LayoutTests/accessibility/mac/active-descendant-with-aria-controls.html A LayoutTests/accessibility/mac/relationships-in-frames-expected.txt A LayoutTests/accessibility/mac/relationships-in-frames.html M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: ----------- AX: `aria-activedescendant` doesn't work with a standard "listbox" pattern https://bugs.webkit.org/show_bug.cgi?id=224582 rdar://76670072 Reviewed by Andres Gonzalez. There were a few things preventing this from working. 1) Relationships in frames were broken after the change to cache relationships in a central map. 2) activeDescendant wasn't checking if the right frame was focused. 3) activeDescendant needed to handle the aria-controls case in order to pick the right target for a notification. 4) A VoiceOver side fix also was required: rdar://103609280 * LayoutTests/accessibility/mac/active-descendant-with-aria-controls-expected.txt: Added. * LayoutTests/accessibility/mac/active-descendant-with-aria-controls.html: Added. * LayoutTests/accessibility/mac/relationships-in-frames-expected.txt: Added. * LayoutTests/accessibility/mac/relationships-in-frames.html: Added. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::updateRelationsForTree): Canonical link: https://commits.webkit.org/258478 at main From noreply at github.com Thu Jan 5 01:37:21 2023 From: noreply at github.com (youennf) Date: Thu, 05 Jan 2023 01:37:21 -0800 Subject: [webkit-changes] [WebKit/WebKit] 281800: Painting an in-process VideoFrame in a remotely-ba... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2818008f7934a4e77dea44d03713df75892c7bd3 https://github.com/WebKit/WebKit/commit/2818008f7934a4e77dea44d03713df75892c7bd3 Author: Youenn Fablet Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h Log Message: ----------- Painting an in-process VideoFrame in a remotely-backed canvas does not work https://bugs.webkit.org/show_bug.cgi?id=250002 rdar://problem/103812253 Reviewed by Eric Carlson. In-process rendering of a VideoFrame in a canvas is based on VideoFrame::paintInContext using a PixelBufferConformerCV. This does not work in WebProcess once sandbox is tigthened/using remote rendering tree. To fix this, we reuse the existing RemoteDisplayListRecorder infrastructure. We use a SharedVideoFrameWriter/SharedVideoFrameReader in RemoteDisplayListRecorderProxy/RemoteDisplayListRecorder. We enable ARGB since VideoFrameCV uses this type. Covered by WPT webcodecs tests with remote rendering tree enabled. * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp: (WebCore::BifurcatedGraphicsContext::drawNativeImage): * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::drawNativeImage): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::drawNativeImage): (WebCore::DisplayList::Recorder::paintVideoFrame): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::recordPaintFrameForMedia): (WebCore::DisplayList::RecorderImpl::recordPaintVideoFrame): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawNativeImage): (WebKit::RemoteDisplayListRecorder::paintVideoFrame): (WebKit::RemoteDisplayListRecorder::setSharedVideoFrameSemaphore): (WebKit::RemoteDisplayListRecorder::setSharedVideoFrameMemory): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::recordPaintVideoFrame): (WebKit::RemoteDisplayListRecorderProxy::disconnect): * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h: * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp: * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h: Canonical link: https://commits.webkit.org/258479 at main From noreply at github.com Thu Jan 5 07:03:13 2023 From: noreply at github.com (AndresGonzalezApple) Date: Thu, 05 Jan 2023 07:03:13 -0800 Subject: [webkit-changes] [WebKit/WebKit] da43d7: AX: Add AXID identification to both AXObjectCache ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da43d74457350003e9b23494e90b0c98d5d5c4f2 https://github.com/WebKit/WebKit/commit/da43d74457350003e9b23494e90b0c98d5d5c4f2 Author: Andres Gonzalez Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h A Source/WebCore/accessibility/AXTreeStore.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp Log Message: ----------- AX: Add AXID identification to both AXObjectCache and AXIsolatedTree so that instances of these classes can be retrieved by ID. https://bugs.webkit.org/show_bug.cgi?id=249480 Reviewed by Chris Fleizach. Added a base template class named AXTreeStore for both AXObjectCache and AXIsolatedTree that implements a map-based storage for instances. The keys in the map are the objects IDs which are assigned on construction. This is necessary to retrieve an instance based on its ID. Retrieving an AXObjectCache or AXIsolatedTree instance is needed for the TextMarker refactoring in https://bugs.webkit.org/show_bug.cgi?id=230558. Canonical link: https://commits.webkit.org/258480 at main From noreply at github.com Thu Jan 5 08:04:05 2023 From: noreply at github.com (Alan Baradlay) Date: Thu, 05 Jan 2023 08:04:05 -0800 Subject: [webkit-changes] [WebKit/WebKit] 9cc33f: [IFC] Move horizontal alignment offset computation... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9cc33f113f0fdb5987c5c3622ad9dbca1e5d8482 https://github.com/WebKit/WebKit/commit/9cc33f113f0fdb5987c5c3622ad9dbca1e5d8482 Author: Alan Baradlay Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp Log Message: ----------- [IFC] Move horizontal alignment offset computation to LineBuilder https://bugs.webkit.org/show_bug.cgi?id=250077 Reviewed by Antti Koivisto. This patch is in preparation for fixing webkit.org/b/249974 (Incorrect ellipsis placement with text-align: center). In order to compute the (real) available space for the ellipsis (and whether the trailing content needs truncation), we need to know the alignment offset. E.g. when the content is right aligned, the available space for the ellipsis is 0 even when the line still has some space left. | right aligned text| <- available space is clearly > 0, though it's in front of the content. | right aligned t...| <- this is where the ellipsis should be placed (by truncating "text" run) * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::build): (WebCore::Layout::horizontalAlignmentOffset): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::layoutInlineContent): (WebCore::Layout::LineBuilder::close): (WebCore::Layout::LineBuilder::inlineBaseDirectionForLineContent const): (WebCore::Layout::LineBuilder::horizontalAlignmentOffset const): (WebCore::Layout::LineBuilder::inlineBaseDirectionForLineContent): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp: (WebCore::Layout::InlineDisplayLineBuilder::build const): Canonical link: https://commits.webkit.org/258481 at main From noreply at github.com Thu Jan 5 08:07:01 2023 From: noreply at github.com (Chris Dumez) Date: Thu, 05 Jan 2023 08:07:01 -0800 Subject: [webkit-changes] [WebKit/WebKit] 60f4fa: Land stubs for Gamepad.vibrationActuator API Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60f4fa76729bafa5b2594c42d3eb0996ebe2838e https://github.com/WebKit/WebKit/commit/60f4fa76729bafa5b2594c42d3eb0996ebe2838e Author: Chris Dumez Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/gamepad/idlharness-extensions.https.window-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/gamepad/Gamepad.cpp M Source/WebCore/Modules/gamepad/Gamepad.h M Source/WebCore/Modules/gamepad/Gamepad.idl A Source/WebCore/Modules/gamepad/GamepadEffectParameters.h A Source/WebCore/Modules/gamepad/GamepadEffectParameters.idl A Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp A Source/WebCore/Modules/gamepad/GamepadHapticActuator.h A Source/WebCore/Modules/gamepad/GamepadHapticActuator.idl M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h Log Message: ----------- Land stubs for Gamepad.vibrationActuator API https://bugs.webkit.org/show_bug.cgi?id=250079 Reviewed by Brady Eidson. Land stubs for Gamepad.vibrationActuator API: - https://w3c.github.io/gamepad/extensions.html#gamepadhapticactuator-interface * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/gamepad/Gamepad.cpp: (WebCore::Gamepad::Gamepad): (WebCore::Gamepad::vibrationActuator): * Source/WebCore/Modules/gamepad/Gamepad.h: * Source/WebCore/Modules/gamepad/Gamepad.idl: * Source/WebCore/Modules/gamepad/GamepadEffectParameters.h: Copied from Source/WebCore/Modules/gamepad/Gamepad.idl. * Source/WebCore/Modules/gamepad/GamepadEffectParameters.idl: Copied from Source/WebCore/Modules/gamepad/Gamepad.idl. * Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp: Copied from Source/WebCore/Modules/gamepad/Gamepad.idl. (WebCore::GamepadHapticActuator::create): (WebCore::GamepadHapticActuator::GamepadHapticActuator): (WebCore::GamepadHapticActuator::canPlayEffectType const): (WebCore::GamepadHapticActuator::playEffect): (WebCore::GamepadHapticActuator::reset): * Source/WebCore/Modules/gamepad/GamepadHapticActuator.h: Copied from Source/WebCore/Modules/gamepad/Gamepad.idl. (WebCore::GamepadHapticActuator::type const): * Source/WebCore/Modules/gamepad/GamepadHapticActuator.idl: Copied from Source/WebCore/Modules/gamepad/Gamepad.idl. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: Canonical link: https://commits.webkit.org/258482 at main From noreply at github.com Thu Jan 5 09:16:02 2023 From: noreply at github.com (Simon Fraser) Date: Thu, 05 Jan 2023 09:16:02 -0800 Subject: [webkit-changes] [WebKit/WebKit] 117ebe: Wrap calls to eventSender.monitorWheelEvents() in ... Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 117ebe14e9c273e6be15f47cd04a7867d7145e74 https://github.com/WebKit/WebKit/commit/117ebe14e9c273e6be15f47cd04a7867d7145e74 Author: Simon Fraser Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M LayoutTests/compositing/fixed-with-main-thread-scrolling.html M LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html M LayoutTests/fast/events/wheel/wheel-events-become-non-cancelable.html M LayoutTests/fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html M LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html M LayoutTests/fast/scrolling/latching/iframe-latch-small-deltas.html M LayoutTests/fast/scrolling/latching/iframe_in_iframe.html M LayoutTests/fast/scrolling/latching/latched-scroll-in-passive-region.html M LayoutTests/fast/scrolling/latching/latched-scroll-into-nonfast-region.html M LayoutTests/fast/scrolling/latching/latching-and-wheel-events.html M LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page.html M LayoutTests/fast/scrolling/latching/nested-cross-axis-latch-expiration.html M LayoutTests/fast/scrolling/latching/overflow-hidden-on-one-axis.html M LayoutTests/fast/scrolling/latching/overflow-in-iframe-latching.html M LayoutTests/fast/scrolling/latching/scroll-div-latched-div.html M LayoutTests/fast/scrolling/latching/scroll-div-latched-mainframe.html M LayoutTests/fast/scrolling/latching/scroll-div-no-latching.html M LayoutTests/fast/scrolling/latching/scroll-div-with-nested-nonscrollable-iframe.html M LayoutTests/fast/scrolling/latching/scroll-iframe-fragment.html M LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html M LayoutTests/fast/scrolling/latching/scroll-iframe-latched-iframe.html M LayoutTests/fast/scrolling/latching/scroll-iframe-latched-mainframe.html M LayoutTests/fast/scrolling/latching/scroll-iframe-webkit1-latching-bug.html M LayoutTests/fast/scrolling/latching/scroll-latched-nested-div.html M LayoutTests/fast/scrolling/latching/scroll-nested-iframe.html M LayoutTests/fast/scrolling/latching/scroll-select-bottom-test.html M LayoutTests/fast/scrolling/latching/scroll-select-latched-mainframe.html M LayoutTests/fast/scrolling/latching/scroll-select-latched-select.html M LayoutTests/fast/scrolling/latching/scroll-snap-latching.html M LayoutTests/fast/scrolling/mac/adjust-scroll-snap-during-gesture.html M LayoutTests/fast/scrolling/mac/async-overscroll-behavior-element.html M LayoutTests/fast/scrolling/mac/async-overscroll-behavior-iframe.html M LayoutTests/fast/scrolling/mac/async-overscroll-behavior-unscrollable-element.html M LayoutTests/fast/scrolling/mac/async-overscroll-behavior-unscrollable-iframe.html M LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html M LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html M LayoutTests/fast/scrolling/mac/keyboard-scrolling-with-mouse-scroll.html M LayoutTests/fast/scrolling/mac/rubberband-axis-locking.html M LayoutTests/fast/scrolling/mac/scroll-container-horizontally.html M LayoutTests/fast/scrolling/mac/smooth-scroll-fixed-element.html M LayoutTests/fast/scrolling/mac/smooth-scroll-iframe.html M LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html M LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html M LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html M LayoutTests/fast/scrolling/overflow-scroll-past-max.html M LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html M LayoutTests/fast/scrolling/programmatic-smooth-scroll-after-focus.html M LayoutTests/fast/scrolling/resources/overscroll-behavior-support.js M LayoutTests/fast/scrolling/rtl-point-in-iframe.html M LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-element.html M LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-iframe.html M LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element.html M LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe.html M LayoutTests/resources/ui-helper.js M LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe-overscroll-behavior.html M LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html M LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-in-vertical-overflow.html M LayoutTests/scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html M LayoutTests/scrollingcoordinator/mac/nested-sticky-with-nonsticking-sticky-parent.html M LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/resources/mainframe-scroll-snap-test.js M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-async-iframe.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-async-overflow-stateless.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-async-overflow.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-hidden-scrollbars.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-then-proximity.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-phase-change-relatching.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow.html M LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-scrolling-jumps-to-top.html M LayoutTests/tiled-drawing/scrolling/stateless-scrolling-no-rubber-band.html Log Message: ----------- Wrap calls to eventSender.monitorWheelEvents() in a UIHelper function https://bugs.webkit.org/show_bug.cgi?id=250058 rdar://103857097 Reviewed by Ryosuke Niwa. `eventSender.monitorWheelEvents()` will need to become async, so in preparation (and also to fix scrolling tests with UI-side compositing), hide calls to `eventSender.monitorWheelEvents()` inside a UIHelper function, which also waits for a rendering update. Do other minor cleanup, like using `await UIHelper.waitForScrollCompletion()` where possible. * LayoutTests/compositing/fixed-with-main-thread-scrolling.html: * LayoutTests/fast/events/wheel/platform-wheelevent-in-scrolling-div.html: * LayoutTests/fast/events/wheel/wheel-events-become-non-cancelable.html: * LayoutTests/fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: * LayoutTests/fast/scrolling/arrow-key-scroll-in-rtl-document.html: * LayoutTests/fast/scrolling/latching/iframe-latch-small-deltas.html: * LayoutTests/fast/scrolling/latching/iframe_in_iframe.html: * LayoutTests/fast/scrolling/latching/latched-scroll-in-passive-region.html: * LayoutTests/fast/scrolling/latching/latched-scroll-into-nonfast-region.html: * LayoutTests/fast/scrolling/latching/latching-and-wheel-events.html: * LayoutTests/fast/scrolling/latching/latching-stuck-to-main-page.html: * LayoutTests/fast/scrolling/latching/nested-cross-axis-latch-expiration.html: * LayoutTests/fast/scrolling/latching/overflow-hidden-on-one-axis.html: * LayoutTests/fast/scrolling/latching/overflow-in-iframe-latching.html: * LayoutTests/fast/scrolling/latching/scroll-div-latched-div.html: * LayoutTests/fast/scrolling/latching/scroll-div-latched-mainframe.html: * LayoutTests/fast/scrolling/latching/scroll-div-no-latching.html: * LayoutTests/fast/scrolling/latching/scroll-div-with-nested-nonscrollable-iframe.html: * LayoutTests/fast/scrolling/latching/scroll-iframe-fragment.html: * LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html: * LayoutTests/fast/scrolling/latching/scroll-iframe-latched-iframe.html: * LayoutTests/fast/scrolling/latching/scroll-iframe-latched-mainframe.html: * LayoutTests/fast/scrolling/latching/scroll-iframe-webkit1-latching-bug.html: * LayoutTests/fast/scrolling/latching/scroll-latched-nested-div.html: * LayoutTests/fast/scrolling/latching/scroll-nested-iframe.html: * LayoutTests/fast/scrolling/latching/scroll-select-bottom-test.html: * LayoutTests/fast/scrolling/latching/scroll-select-latched-mainframe.html: * LayoutTests/fast/scrolling/latching/scroll-select-latched-select.html: * LayoutTests/fast/scrolling/latching/scroll-snap-latching.html: * LayoutTests/fast/scrolling/mac/adjust-scroll-snap-during-gesture.html: * LayoutTests/fast/scrolling/mac/async-overscroll-behavior-element.html: * LayoutTests/fast/scrolling/mac/async-overscroll-behavior-iframe.html: * LayoutTests/fast/scrolling/mac/async-overscroll-behavior-unscrollable-element.html: * LayoutTests/fast/scrolling/mac/async-overscroll-behavior-unscrollable-iframe.html: * LayoutTests/fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: * LayoutTests/fast/scrolling/mac/keyboard-scrolling-terminates.html: * LayoutTests/fast/scrolling/mac/keyboard-scrolling-with-mouse-scroll.html: * LayoutTests/fast/scrolling/mac/rubberband-axis-locking.html: * LayoutTests/fast/scrolling/mac/scroll-container-horizontally.html: * LayoutTests/fast/scrolling/mac/smooth-scroll-fixed-element.html: * LayoutTests/fast/scrolling/mac/smooth-scroll-iframe.html: * LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html: * LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html: * LayoutTests/fast/scrolling/mac/vertical-scroll-in-horizontal-scroller.html: * LayoutTests/fast/scrolling/overflow-scroll-past-max.html: * LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html: * LayoutTests/fast/scrolling/programmatic-smooth-scroll-after-focus.html: * LayoutTests/fast/scrolling/resources/overscroll-behavior-support.js: (async mouseWheelScrollAndWait): * LayoutTests/fast/scrolling/rtl-point-in-iframe.html: * LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-element.html: * LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-iframe.html: * LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-element.html: * LayoutTests/fast/scrolling/sync-scroll-overscroll-behavior-unscrollable-iframe.html: * LayoutTests/resources/ui-helper.js: (window.UIHelper.async startMonitoringWheelEvents): (window.UIHelper.async mouseWheelScrollAt): (window.UIHelper.async statelessMouseWheelScrollAt): * LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe-overscroll-behavior.html: * LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html: * LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-in-vertical-overflow.html: * LayoutTests/scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html: * LayoutTests/scrollingcoordinator/mac/nested-sticky-with-nonsticking-sticky-parent.html: * LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/resources/mainframe-scroll-snap-test.js: (async doScrollTest): * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-async-iframe.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-async-overflow-stateless.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-async-overflow.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-hidden-scrollbars.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-then-proximity.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-phase-change-relatching.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow.html: * LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-scrolling-jumps-to-top.html: * LayoutTests/tiled-drawing/scrolling/stateless-scrolling-no-rubber-band.html: Canonical link: https://commits.webkit.org/258483 at main From noreply at github.com Thu Jan 5 09:22:29 2023 From: noreply at github.com (Chirag Shah) Date: Thu, 05 Jan 2023 09:22:29 -0800 Subject: [webkit-changes] [WebKit/WebKit] 096f18: Encode 128 bits for IPC's destination identifier Message-ID: Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 096f18835da5d23891a76c17b4f010f057dcdee2 https://github.com/WebKit/WebKit/commit/096f18835da5d23891a76c17b4f010f057dcdee2 Author: Chirag M Shah Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WTF/wtf/Int128.h M Source/WTF/wtf/ObjectIdentifier.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/Platform/IPC/Connection.cpp M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/Platform/IPC/Decoder.cpp M Source/WebKit/Platform/IPC/Decoder.h M Source/WebKit/Platform/IPC/Encoder.cpp M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/MessageReceiveQueueMap.h M Source/WebKit/Platform/IPC/MessageReceiverMap.cpp M Source/WebKit/Platform/IPC/MessageReceiverMap.h M Source/WebKit/Platform/IPC/MessageSender.h M Source/WebKit/Platform/IPC/ReceiverMatcher.h M Source/WebKit/Platform/IPC/StreamClientConnection.h M Source/WebKit/Platform/IPC/StreamServerConnection.cpp M Source/WebKit/Platform/IPC/StreamServerConnection.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/AuxiliaryProcess.cpp M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: ----------- Encode 128 bits for IPC's destination identifier https://bugs.webkit.org/show_bug.cgi?id=248929 Reviewed by Alex Christensen. This will allow me to fit a FrameIdentifier which is 128 bits. * Source/WTF/wtf/Int128.h: (WTF::DefaultHash::hash): (WTF::DefaultHash::equal): (WTF::DefaultHash::hash): (WTF::DefaultHash::equal): (WTF::HashTraits::constructDeletedValue): (WTF::HashTraits::isDeletedValue): (WTF::HashTraits::constructDeletedValue): (WTF::HashTraits::isDeletedValue): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Source/WTF/wtf/ObjectIdentifier.h: (WTF::makeObjectIdentifier): * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::didReceiveMessage): (WebKit::NetworkProcess::didReceiveSyncMessage): (WebKit::NetworkProcess::findPendingDownloadLocation): * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::WaitForMessageState::WaitForMessageState): (IPC::Connection::SyncMessageState::dispatchMessages): (IPC::Connection::addWorkQueueMessageReceiver): (IPC::Connection::removeWorkQueueMessageReceiver): (IPC::Connection::addMessageReceiver): (IPC::Connection::removeMessageReceiver): (IPC::Connection::createSyncMessageEncoder): (IPC::Connection::waitForMessage): * Source/WebKit/Platform/IPC/Connection.h: (IPC::Connection::sendWithAsyncReply): (IPC::Connection::send): (IPC::Connection::sendSync): (IPC::Connection::waitForAndDispatchImmediately): (IPC::Connection::waitForAsyncReplyAndDispatchImmediately): (IPC::Connection::waitForMessageForTesting): * Source/WebKit/Platform/IPC/Decoder.cpp: (IPC::Decoder::Decoder): * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::destinationID const): * Source/WebKit/Platform/IPC/Encoder.cpp: (IPC::Encoder::Encoder): * Source/WebKit/Platform/IPC/Encoder.h: * Source/WebKit/Platform/IPC/MessageReceiveQueueMap.h: * Source/WebKit/Platform/IPC/MessageReceiverMap.cpp: (IPC::MessageReceiverMap::addMessageReceiver): (IPC::MessageReceiverMap::removeMessageReceiver): * Source/WebKit/Platform/IPC/MessageReceiverMap.h: * Source/WebKit/Platform/IPC/MessageSender.h: (IPC::MessageSender::send): (IPC::MessageSender::sendSync): (IPC::MessageSender::sendWithAsyncReply): * Source/WebKit/Platform/IPC/ReceiverMatcher.h: (IPC::ReceiverMatcher::ReceiverMatcher): (IPC::ReceiverMatcher::createWithZeroAsAnyDestination): (IPC::ReceiverMatcher::matches const): * Source/WebKit/Platform/IPC/StreamClientConnection.h: (IPC::StreamClientConnection::trySendDestinationIDIfNeeded): * Source/WebKit/Platform/IPC/StreamServerConnection.cpp: (IPC::StreamServerConnection::startReceivingMessages): (IPC::StreamServerConnection::stopReceivingMessages): (IPC::StreamServerConnection::processSetStreamDestinationID): * Source/WebKit/Platform/IPC/StreamServerConnection.h: * Source/WebKit/Scripts/webkit/messages.py: (generate_message_handler): * Source/WebKit/Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::addMessageReceiver): (WebKit::AuxiliaryProcess::removeMessageReceiver): * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::addMessageReceiver): (WebKit::AuxiliaryProcessProxy::removeMessageReceiver): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::send): (WebKit::AuxiliaryProcessProxy::sendSync): (WebKit::AuxiliaryProcessProxy::sendWithAsyncReply): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::addMessageReceiver): (WebKit::WebProcessPool::removeMessageReceiver): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::evaluateJavaScriptCallback): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::prepareToSendOutOfStreamMessage): (WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h: * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/258484 at main From noreply at github.com Thu Jan 5 09:39:11 2023 From: noreply at github.com (EWS) Date: Thu, 05 Jan 2023 09:39:11 -0800 Subject: [webkit-changes] [WebKit/WebKit] a4eb84: