[webkit-changes] [WebKit/WebKit] 2e8f9e: [JSC] Consume unused Values

Yusuke Suzuki noreply at github.com
Tue Feb 28 17:51:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e8f9e46e4833f218d462d701ebabb21b530baf1
      https://github.com/WebKit/WebKit/commit/2e8f9e46e4833f218d462d701ebabb21b530baf1
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [JSC] Consume unused Values
https://bugs.webkit.org/show_bug.cgi?id=253125
rdar://106060228

Reviewed by Justin Michaud.

These values are used for checking exception status. And they do not exist on WasmFunctionParser side's stack.
So we should immediately consume these values to release them from temp stack. locationOf will find these values.
And it is possible that they have different types & registers from the expected values' types & registers.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addTableSet):
(JSC::Wasm::BBQJIT::addTableInit):
(JSC::Wasm::BBQJIT::addTableFill):
(JSC::Wasm::BBQJIT::addTableCopy):
(JSC::Wasm::BBQJIT::addMemoryFill):
(JSC::Wasm::BBQJIT::addMemoryCopy):
(JSC::Wasm::BBQJIT::addMemoryInit):
(JSC::Wasm::BBQJIT::clobbersForDivX86):
(JSC::Wasm::BBQJIT::allocateWithHint):
(JSC::Wasm::BBQJIT::bind):
(JSC::Wasm::BBQJIT::evictGPR):
(JSC::Wasm::BBQJIT::ScratchScope::bindGPRToScratch):
(JSC::Wasm::BBQJIT::ScratchScope::unbindGPRFromScratch):
(JSC::Wasm::BBQJIT::ScratchScope::initializedPreservedSet):

Canonical link: https://commits.webkit.org/260979@main




More information about the webkit-changes mailing list