[webkit-changes] [WebKit/WebKit] f24922: [UI-side compositing] Assertion under RemoteLayerT...

Simon Fraser noreply at github.com
Tue Feb 28 16:21:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f249228a3a5dacb7c5ca9edb1a7648207c54aa3b
      https://github.com/WebKit/WebKit/commit/f249228a3a5dacb7c5ca9edb1a7648207c54aa3b
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [UI-side compositing] Assertion under RemoteLayerTreeEventDispatcher::displayLink() running tests
https://bugs.webkit.org/show_bug.cgi?id=253112
rdar://106051454

Reviewed by Tim Horton.

RemoteScrollingCoordinatorProxy owns a RemoteLayerTreeEventDispatcher which needs to get back to
the DrawingAreaProxy to cancel a DisplayLink on cleanup. This means that the RemoteScrollingCoordinatorProxy
needs to be destroyed before the DrawingAreaProxy, so ensure that in WebPageProxy.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDrawingArea):
(WebKit::WebPageProxy::resetState): Call setDrawingArea(nullptr) so we run the same cleanup code.

Canonical link: https://commits.webkit.org/260975@main




More information about the webkit-changes mailing list