[webkit-changes] [WebKit/WebKit] 655c6f: Fix Live Text layout for images with vertical writ...

Richard Robinson noreply at github.com
Tue Feb 28 14:00:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 655c6f748f08e8b475ea137a5d782c6b2915c336
      https://github.com/WebKit/WebKit/commit/655c6f748f08e8b475ea137a5d782c6b2915c336
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    A LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode-expected.txt
    A LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode.html
    M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
    M Source/WebCore/dom/ImageOverlay.cpp
    M Source/WebCore/platform/TextRecognitionResult.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
    M Source/WebKit/Shared/TextRecognitionResult.serialization.in

  Log Message:
  -----------
  Fix Live Text layout for images with vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=253020
rdar://101314828

Reviewed by Wenson Hsieh.

* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode-expected.txt: Added.
* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode.html: Added.
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/platform/TextRecognitionResult.h:
(WebCore::TextRecognitionLineData::TextRecognitionLineData):
* Source/WebCore/testing/Internals.cpp:
(WebCore::makeDataForLine):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::makeTextRecognitionResult):
* Source/WebKit/Shared/TextRecognitionResult.serialization.in:

Canonical link: https://commits.webkit.org/260968@main




More information about the webkit-changes mailing list