[webkit-changes] [WebKit/WebKit] 0a2e32: Fix Gamepad serialization after 260751 at main

Alex Christensen noreply at github.com
Tue Feb 28 13:51:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a2e32ae9a4a3164770706475eee73dad25f2fca
      https://github.com/WebKit/WebKit/commit/0a2e32ae9a4a3164770706475eee73dad25f2fca
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M Source/WebKit/Shared/Gamepad/GamepadData.cpp
    M Source/WebKit/Shared/Gamepad/GamepadData.h
    M Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp
    M Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/Gamepad/WebGamepad.cpp
    M Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.cpp
    M Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  -----------
  Fix Gamepad serialization after 260751 at main
https://bugs.webkit.org/show_bug.cgi?id=253102
rdar://106046830

Reviewed by Brady Eidson.

We didn't serialize m_isNull.  We don't need to, but we do need to remove the nullable state.

* Source/WebKit/Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::GamepadData):
* Source/WebKit/Shared/Gamepad/GamepadData.h:
(WebKit::GamepadData::GamepadData): Deleted.
(WebKit::GamepadData::isNull const): Deleted.
(): Deleted.
* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::snapshotGamepads):
* Source/WebKit/WebProcess/Gamepad/WebGamepad.cpp:
(WebKit::WebGamepad::updateValues):
* Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::setInitialGamepads):

Canonical link: https://commits.webkit.org/260965@main




More information about the webkit-changes mailing list