[webkit-changes] [WebKit/WebKit] 541ca5: Regression(255659 at main) Unable to log into twitch.tv

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 541ca5a79560c6998b3e433980a19d25b0f28fd9
      https://github.com/WebKit/WebKit/commit/541ca5a79560c6998b3e433980a19d25b0f28fd9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    A LayoutTests/fast/screen-orientation/natural-orientation-expected.txt
    A LayoutTests/fast/screen-orientation/natural-orientation.html
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt
    A LayoutTests/platform/ios/fast/screen-orientation/natural-orientation-expected.txt
    M Source/WebCore/page/ScreenOrientation.cpp
    M Source/WebCore/page/ScreenOrientationType.h
    M Source/WebCore/platform/ScreenOrientationProvider.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebScreenOrientationManager.cpp

  Log Message:
  -----------
  Regression(255659 at main) Unable to log into twitch.tv
https://bugs.webkit.org/show_bug.cgi?id=253026
rdar://105891522

Reviewed by Wenson Hsieh and Darin Adler.

The Twitch.tv login was failing because `screen.orientation` was returning
"portrait-primary" on macOS. The natural/default orientation on desktop should
be "landscape-primary" so this was confusing Twitch.

Also update our `screen.angle` logic to take into account the natural
orientation based on:
- https://w3c.github.io/screen-orientation/#dfn-screen-orientation-values-table

I have verified that Chrome on macOS returns "landscape-primary" for the type
and 0 for the angle. Our behavior is now aligned.

* LayoutTests/fast/screen-orientation/natural-orientation-expected.txt: Added.
* LayoutTests/fast/screen-orientation/natural-orientation.html: Added.
* LayoutTests/platform/ios/screen-orientation/natural-orientation-expected.txt: Added.
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ScreenOrientationType.h:
(WebCore::naturalScreenOrientationType):
* Source/WebCore/platform/ScreenOrientationProvider.cpp:
(WebCore::ScreenOrientationProvider::currentOrientation):
* Source/WebKit/WebProcess/WebCoreSupport/WebScreenOrientationManager.cpp:
(WebKit::WebScreenOrientationManager::currentOrientation):

Canonical link: https://commits.webkit.org/260944@main