[webkit-changes] [WebKit/WebKit] 106f26: Introduce AllowTestOnlyIPC in order to block "ForT...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 106f2630430967aba20df89a91f093284a7f4362
      https://github.com/WebKit/WebKit/commit/106f2630430967aba20df89a91f093284a7f4362
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/mediastream/keep-microphone-muted-on-uninterruption.html
    M LayoutTests/fast/mediastream/video-created-while-interrupted.html
    A LayoutTests/ipc/no-test-only-ipc-expected-crash.html
    A LayoutTests/ipc/test-only-ipc-allowed-expected.txt
    A LayoutTests/ipc/test-only-ipc-allowed.html
    M LayoutTests/media/audioSession/audioSessionState.html
    M LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia.html
    M LayoutTests/media/media-source/media-source-istypesupported-vp8-without-vp9.html
    M LayoutTests/media/media-source/media-source-video-renders.html
    M LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html
    M LayoutTests/platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
    M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp
    M Source/WebKit/Shared/GPUProcessConnectionParameters.h
    A Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/WebKitTestRunner/TestOptions.cpp
    M Tools/WebKitTestRunner/TestOptions.h
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  Introduce AllowTestOnlyIPC in order to block "ForTesting" IPC endpoints
https://bugs.webkit.org/show_bug.cgi?id=252829
rdar://105837347

Reviewed by Alex Christensen.

Starts to block unneeded "ForTesting" IPC endpoints by adding a default
deny to those messages and then allowing them only when a preference is
specified. The new preference exposed is AllowTestOnlyIPC.

* LayoutTests/TestExpectations:
* LayoutTests/fast/mediastream/keep-microphone-muted-on-uninterruption.html:
* LayoutTests/fast/mediastream/video-created-while-interrupted.html:
* LayoutTests/ipc/no-test-only-ipc-expected-crash.html: Added.
* LayoutTests/ipc/test-only-ipc-allowed-expected.txt: Added.
* LayoutTests/ipc/test-only-ipc-allowed.html: Added.
* LayoutTests/media/audioSession/audioSessionState.html:
* LayoutTests/media/audioSession/ios/audioSessionState-getUserMedia.html:
* LayoutTests/platform/ios/mediastream/getUserMedia-override-audio-session-interruption.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::setMediaOverridesForTesting):
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::allowTestOnlyIPC const):
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::triggerBeginInterruptionForTesting):
(WebKit::RemoteAudioSessionProxy::triggerEndInterruptionForTesting):
* Source/WebKit/Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const): Deleted.
(WebKit::GPUProcessConnectionParameters::decode): Deleted.
* Source/WebKit/Shared/GPUProcessConnectionParameters.serialization.in: Added.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowTestOnlyIPC]):
(-[WKWebViewConfiguration _setAllowTestOnlyIPC:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createGPUProcessConnection):
(WebKit::WebProcessPool::createWebPage):
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::allowTestOnlyIPC const):
(WebKit::WebProcessProxy::setAllowTestOnlyIPC):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):
* Tools/WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::allowTestOnlyIPC const):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):

Canonical link: https://commits.webkit.org/260935@main