[webkit-changes] [WebKit/WebKit] f14cfb: [web-animations] allow acceleration of CSS propert...

Antoine Quint noreply at github.com
Tue Feb 28 04:33:11 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f14cfb613307745c3ad6dede1b4a63945865e3f2
      https://github.com/WebKit/WebKit/commit/f14cfb613307745c3ad6dede1b4a63945865e3f2
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/animation/CSSPropertyAnimation.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/KeyframeEffectStack.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [web-animations] allow acceleration of CSS property animation to be governed by settings
https://bugs.webkit.org/show_bug.cgi?id=253022

Reviewed by Dean Jackson.

The work on threaded animation resolution will allow us to opt certain CSS properties into
being accelerated. In order to be able to do that when that runtime flag is enabled, we need
to pass Settings to AnimationPropertyWrapperBase::animationIsAccelerated(). To that end, we
add a WeakPtr<Document> member to KeyframeEffect, such that we may access settings for the
various method calls that rely on CSSPropertyAnimation::animationOfPropertyIsAccelerated().

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::AnimationPropertyWrapperBase::animationIsAccelerated const):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
* Source/WebCore/animation/CSSPropertyAnimation.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
(WebCore::KeyframeEffect::computeAcceleratedPropertiesState):
(WebCore::KeyframeEffect::document const):
(WebCore::KeyframeEffect::computeHasImplicitKeyframeForAcceleratedProperty):
(WebCore::KeyframeEffect::computeHasKeyframeComposingAcceleratedProperty):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::didApplyCascade):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computeRenderStyleForProperty):

Canonical link: https://commits.webkit.org/260933@main




More information about the webkit-changes mailing list