[webkit-changes] [WebKit/WebKit] 903910: OffscreenCanvas WebGL doesn't fire the context los...

mattwoodrow noreply at github.com
Mon Feb 27 22:28:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 903910f95dd36fc7cbc660fb96daab4df0372a07
      https://github.com/WebKit/WebKit/commit/903910f95dd36fc7cbc660fb96daab4df0372a07
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/html/CanvasBase.h
    M Source/WebCore/html/CustomPaintCanvas.h
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/HTMLCanvasElement.h
    M Source/WebCore/html/OffscreenCanvas.cpp
    M Source/WebCore/html/OffscreenCanvas.h
    M Source/WebCore/html/OffscreenCanvas.idl
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLSync.cpp

  Log Message:
  -----------
  OffscreenCanvas WebGL doesn't fire the context lost event.
https://bugs.webkit.org/show_bug.cgi?id=250532
<rdar://104198422>

Reviewed by Ryosuke Niwa.

Adds support for dispatching the event to OffscreenCanvas too, and enables the WebGL tests that cover this.

* LayoutTests/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/CustomPaintCanvas.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::queueTaskKeepingObjectAlive):
(WebCore::HTMLCanvasElement::dispatchEvent):
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::create):
(WebCore::OffscreenCanvas::OffscreenCanvas):
(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::queueTaskKeepingObjectAlive):
(WebCore::OffscreenCanvas::dispatchEvent):
* Source/WebCore/html/OffscreenCanvas.h:
* Source/WebCore/html/OffscreenCanvas.idl:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
* Source/WebCore/html/canvas/WebGLSync.cpp:
(WebCore::WebGLSync::scheduleAllowCacheUpdate):

Canonical link: https://commits.webkit.org/260924@main




More information about the webkit-changes mailing list