[webkit-changes] [WebKit/WebKit] 7dd18b: [JSC][32bit] Fix JIT being disabled when compiling...

[Mikhail R. Gadelha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab
      https://github.com/WebKit/WebKit/commit/7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab
  Author: Mikhail R. Gadelha <mikhail at igalia.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/b3/air/AirArg.h
    M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h
    M Source/WTF/wtf/PlatformCPU.h
    M Source/bmalloc/bmalloc/BPlatform.h
    M Source/cmake/OptionsCommon.cmake

  Log Message:
  -----------
  [JSC][32bit] Fix JIT being disabled when compiling JSC on linux with clang
https://bugs.webkit.org/show_bug.cgi?id=234034

Reviewed by Justin Michaud.

JIT was always disabled when building JSC with clang on linux 32 bits
because CMake checked if the compiler defined __thumb2__ and while
gcc does define it by default, clang doesn't.

This patch adds extra compilation flags when compiling JSC with clang
for arm (except on Darwin), so the expected __thumb2__ define is defined
and JIT is enabled.

Also some minor changes:
(1) this patch also adds __ARM_ARCH_8__ and __ARM_ARCH_8A__
to the list that sets BTHUMB_ARCH_VERSION and WTF_THUMB_ARCH_VERSION to
4. These two seem to be used mostly for sanity check.
(2) a small fix in AirArg where clang complains about a missing
typename. gcc seems to accept either.

* Source/JavaScriptCore/b3/air/AirArg.h:
(JSC::B3::Air::Arg::isValidAddrForm):
* Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h:
(JSC::Wasm::parseAndCompileAirImpl):
* Source/WTF/wtf/PlatformCPU.h:
* Source/bmalloc/bmalloc/BPlatform.h:
* Source/cmake/OptionsCommon.cmake:

Canonical link: https://commits.webkit.org/260921@main