[webkit-changes] [WebKit/WebKit] 2c2474: REGRESSION (257937 at main): Hover state UI leaves gr...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c24741506078dc94911bda59d8cc1521fdd4dd3
      https://github.com/WebKit/WebKit/commit/2c24741506078dc94911bda59d8cc1521fdd4dd3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    A LayoutTests/fast/repaint/out-of-flow-inside-relative-inline-expected.txt
    A LayoutTests/fast/repaint/out-of-flow-inside-relative-inline.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  REGRESSION (257937 at main): Hover state UI leaves graphic artifacts on Techmeme.com
https://bugs.webkit.org/show_bug.cgi?id=253014
<rdar://104612196>

Reviewed by Antti Koivisto.

This patch ensures that when the line layout path gets invalidated (and we eagerly destroy geometry information -there's a FIXME on that)
both in-, and out-of-flow content get repainted.
(This is the case when calling repaint on an absolute positioned box nested in a relative positioned inline box
(e.g. <span style="position: relative"><div style="position: absolute"></div></span>
ends up in RenderInline::offsetForInFlowPositionedInline which needs display box geometry information -which we eagerly destroy; see above).

* LayoutTests/fast/repaint/out-of-flow-inside-relative-inline-expected.txt: Added.
* LayoutTests/fast/repaint/out-of-flow-inside-relative-inline.html: Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Canonical link: https://commits.webkit.org/260913@main