[webkit-changes] [WebKit/WebKit] a27ac6: Restore 100, 000 limit in HTMLOptionsCollection.len...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a27ac64f683e8d0a798123758cb4bf5a0bc75cd0
      https://github.com/WebKit/WebKit/commit/a27ac64f683e8d0a798123758cb4bf5a0bc75cd0
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt
    M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt
    M LayoutTests/fast/forms/select-max-length-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large.html
    M Source/WebCore/html/HTMLSelectElement.cpp

  Log Message:
  -----------
  Restore 100,000 limit in HTMLOptionsCollection.length setter

https://bugs.webkit.org/show_bug.cgi?id=252983

Reviewed by Chris Dumez.

This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.

Merge - https://chromium.googlesource.com/chromium/src/+/f27e6ea87ecf211c8b8644813422a9e7f19cd1cc

This patch updates 'maxSelectItems' to new value of 100,000
to reflect update in spec.
Further, it is updated to be only used when new length is
greater than current length.
Additionally, add comments to reflect the details as needed.

Web-Spec: https://html.spec.whatwg.org/#dom-htmloptionscollection-length
Issue: https://github.com/whatwg/html/issues/8337

* Source/WebCore/html/HTMLSelectElement.cpp:
(maxSelectItems): Update constant value
(HTMLSelectElement::setItem): Remove '=' and update comments and console message
(HTMLSelectElement::setLength): Add comment and update console message
* LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/html/select/options-length-too-large-expected.txt: Add Test Case Expectation
* LayoutTests/fast/forms/select-max-length-expected.txt: Rebaselined
* LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Rebaselined
* LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/260896@main