[webkit-changes] [WebKit/WebKit] afe779: REGRESSION(260082 at main): [GStreamer][1.20] YT broken

Philippe Normand noreply at github.com
Mon Feb 27 04:12:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afe779a29470fc44ec35e7aff6aa68a541e651d5
      https://github.com/WebKit/WebKit/commit/afe779a29470fc44ec35e7aff6aa68a541e651d5
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  REGRESSION(260082 at main): [GStreamer][1.20] YT broken
https://bugs.webkit.org/show_bug.cgi?id=252958

Reviewed by Xabier Rodriguez-Calvar.

In 260082 at main we made the MSE source element act as an adaptive stream, triggering a different code
path in urisourcebin, that turned out to be broken in GStreamer versions older than 1.22 and
triggering caps negotiation errors during typefinding in urisourcebin. The commit that fixed this in
GStreamer 1.22 is too big for backporting, so fallback to previous behavior in runtimes older than 1.22.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureElement):
* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkit_media_stream_src_class_init):

Canonical link: https://commits.webkit.org/260875@main




More information about the webkit-changes mailing list