[webkit-changes] [WebKit/WebKit] 074120: Add tests to make sure confirm/prompt work from cr...

Chirag Shah noreply at github.com
Mon Feb 27 00:47:05 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07412048195177731c9cc21937bd440add942d1d
      https://github.com/WebKit/WebKit/commit/07412048195177731c9cc21937bd440add942d1d
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
    M Tools/TestWebKitAPI/cocoa/TestUIDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm

  Log Message:
  -----------
  Add tests to make sure confirm/prompt work from cross-origin iframes
with site isolation.
https://bugs.webkit.org/show_bug.cgi?id=252923
rdar://99897405

Reviewed by Alex Christensen.

alert/confirm/prompt dialogs are expected to work from cross-origin
iframes with site isolation. We already tests that alert works, but this
change adds tests for confirm/prompt as well.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm:
(-[TestUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[TestUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
(-[TestUIDelegate waitForConfirm]):
(-[TestUIDelegate waitForPromptWithDefaultInput:]):
(-[WKWebView _test_waitForConfirm]):
(-[WKWebView _test_waitForPromptWithDefaultInput:]):

Canonical link: https://commits.webkit.org/260867@main




More information about the webkit-changes mailing list