[webkit-changes] [WebKit/WebKit] 05dc42: Adding a SELECT tree to another tree should not re...
Ahmad Saleem
noreply at github.com
Sun Feb 26 14:51:24 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 05dc4285c1167fc8dfa6ca77b98c415c36744392
https://github.com/WebKit/WebKit/commit/05dc4285c1167fc8dfa6ca77b98c415c36744392
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2023-02-26 (Sun, 26 Feb 2023)
Changed paths:
M LayoutTests/fast/forms/select-ask-for-reset-expected.txt
M LayoutTests/fast/forms/select-ask-for-reset.html
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/html/HTMLSelectElement.h
Log Message:
-----------
Adding a SELECT tree to another tree should not reset selection
https://bugs.webkit.org/show_bug.cgi?id=248360
rdar://problem/102935842
Reviewed by Ryosuke Niwa.
This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.
Partial Merge - https://chromium.googlesource.com/chromium/src.git/+/049818ff21a38402b788ee340acadeaaf3b37c79
This patch is to remove function 'insertedIntoAncestor' so the selection
does not reset on adding in SELECT tree.
* Source/WebCore/html/HTMLSelectElement.cpp:
(HTMLSelectElement::insertedIntoAncestor): Remove function
* Source/WebCore/html/HTMLSelectElement.h: Remove 'insertedIntoAncestor'
* LayoutTests/fast/forms/select-ask-for-reset.html: Add Testcase
* LayoutTests/fast/forms/select-ask-for-reset-expected.txt: Add Testcase Expectations
Canonical link: https://commits.webkit.org/260859@main
More information about the webkit-changes
mailing list