[webkit-changes] [WebKit/WebKit] e0b27b: (REGRESSION) Increasing column-count above 2 at ru...

Alan Baradlay noreply at github.com
Sun Feb 26 08:11:51 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0b27b7e1c9b741347a581acc2007229791fed86
      https://github.com/WebKit/WebKit/commit/e0b27b7e1c9b741347a581acc2007229791fed86
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-26 (Sun, 26 Feb 2023)

  Changed paths:
    A LayoutTests/fast/multicol/dynamic-column-count-change-expected.html
    A LayoutTests/fast/multicol/dynamic-column-count-change.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderView.cpp

  Log Message:
  -----------
  (REGRESSION) Increasing column-count above 2 at runtime has no effect
https://bugs.webkit.org/show_bug.cgi?id=219291
<rdar://problem/71808738>

Reviewed by Antti Koivisto.

In order to trigger column layout, we need to dirty the root RenderMultiColumnFlow(RenderMultiColumnSet).

* LayoutTests/fast/multicol/dynamic-column-count-change-expected.html: Added.
* LayoutTests/fast/multicol/dynamic-column-count-change.html: Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::updateStylesForColumnChildren):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange):

Canonical link: https://commits.webkit.org/260849@main




More information about the webkit-changes mailing list