[webkit-changes] [WebKit/WebKit] 710d98: [iOS] Refactor some logic for analyzing paused vid...

Wenson Hsieh noreply at github.com
Fri Feb 24 11:24:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 710d98ca97fb6c4148fa100d5a0c4835ab4394e1
      https://github.com/WebKit/WebKit/commit/710d98ca97fb6c4148fa100d5a0c4835ab4394e1
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-02-24 (Fri, 24 Feb 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h
    M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  [iOS] Refactor some logic for analyzing paused video frames
https://bugs.webkit.org/show_bug.cgi?id=252880

Reviewed by Aditya Keerthi.

Refactor some existing logic for Live Text in paused, fullscreen videos.

* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h:
(WebKit::analysisTypesForFullscreenVideo):
(WebKit::analysisTypesForElementFullscreenVideo):
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::prepareImageAnalysisForOverlayView):

Also rename this helper, to clarify its intended purpose.

(WebKit::setUpAdditionalImageAnalysisBehaviors): Deleted.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView beginTextRecognitionForFullscreenVideo:playerViewController:]):
(-[WKContentView beginTextRecognitionForVideoInElementFullscreen:bounds:]):
(-[WKContentView installImageAnalysisInteraction:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::installImageAnalysisOverlayView):

Canonical link: https://commits.webkit.org/260801@main




More information about the webkit-changes mailing list