[webkit-changes] [WebKit/WebKit] 380e2f: Clarify WebPageProxy wheel event code for UI-side ...

Simon Fraser noreply at github.com
Thu Feb 23 10:39:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 380e2f6bed60dc8af9193a12c8945b8bf1904796
      https://github.com/WebKit/WebKit/commit/380e2f6bed60dc8af9193a12c8945b8bf1904796
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Clarify WebPageProxy wheel event code for UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=252703
rdar://105752960

Reviewed by Tim Horton.

Make use of DrawingAreaProxy::shouldSendWheelEventsToEventDispatcher() to conditionalize
code in WebPageProxy, making it clear that we only call into m_scrollingCoordinatorProxy if we're
not sending events to the EventDispatcher, and that we don't need to send ScrollingAccelerationCurves
to the web process with UI-side compositing.

Also dispatchWheelEventWithoutScrolling() is only used on iOS, so #ifdef it for clarity.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::sendWheelEvent):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/260752@main




More information about the webkit-changes mailing list