[webkit-changes] [WebKit/WebKit] d5d4ad: Fix some bounds issues in API tests

EWS noreply at github.com
Thu Feb 23 08:00:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5d4adedf8268ecf3e454dad02981a9cbcd9b07e
      https://github.com/WebKit/WebKit/commit/d5d4adedf8268ecf3e454dad02981a9cbcd9b07e
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp
    M Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

  Log Message:
  -----------
  Fix some bounds issues in API tests
https://bugs.webkit.org/show_bug.cgi?id=252779
rdar://105784168

Reviewed by Darin Adler.

Asan found some out of bounds operations because of how we wrote our tests.

* Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp:
(TestWebKitAPI::testFixedBitVectorFindBit):
* Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):

Canonical link: https://commits.webkit.org/260746@main




More information about the webkit-changes mailing list