[webkit-changes] [WebKit/WebKit] 5e1b94: [GStreamer][WebRTC] Disabled incoming audio track ...
Philippe Normand
noreply at github.com
Thu Feb 23 05:30:06 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5e1b9418e1ae6ba8954e7f6a916a7882e03ac69e
https://github.com/WebKit/WebKit/commit/5e1b9418e1ae6ba8954e7f6a916a7882e03ac69e
Author: Philippe Normand <philn at igalia.com>
Date: 2023-02-23 (Thu, 23 Feb 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h
Log Message:
-----------
[GStreamer][WebRTC] Disabled incoming audio track breaks webaudio provider
https://bugs.webkit.org/show_bug.cgi?id=252751
Reviewed by Xabier Rodriguez-Calvar.
Disabling an incoming audio track internally means that the mediastreamsrc switches from RTP
payloads to raw audio. The AudioSourceProvider wasn't able to reliably handle this, but switching
its internal pipeline to uridecodebin3 solves the issue. Internally uridecodebin3 will be able to
reconfigure properly.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::setClient):
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
Canonical link: https://commits.webkit.org/260742@main
More information about the webkit-changes
mailing list