[webkit-changes] [WebKit/WebKit] 0c0a78: [WGSL] Move type checking into the validation stage

Tadeu Zagallo noreply at github.com
Thu Feb 23 01:41:25 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c0a78158493361033491779b9ec813d6da84fbf
      https://github.com/WebKit/WebKit/commit/0c0a78158493361033491779b9ec813d6da84fbf
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/TypeCheck.h
    M Source/WebGPU/WGSL/TypeDeclarations.js
    M Source/WebGPU/WGSL/WGSL.cpp

  Log Message:
  -----------
  [WGSL] Move type checking into the validation stage
https://bugs.webkit.org/show_bug.cgi?id=252760
rdar://105788936

Reviewed by Myles C. Maxfield.

At first, since there was very little of the type checking implemented, it was
only run right before generating and the errors behind a compiler-time flag.
While the type checker is still far from complete, it can now correctly check
the examples we've been using for development, so we can move it into the
validation phase.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
(WGSL::typeCheck):
* Source/WebGPU/WGSL/TypeCheck.h:
* Source/WebGPU/WGSL/TypeDeclarations.js:
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::staticCheck):
(WGSL::prepareImpl):

Canonical link: https://commits.webkit.org/260735@main




More information about the webkit-changes mailing list