[webkit-changes] [WebKit/WebKit] 74387c: [GStreamer][WebRTC] Renegotiation signalling impro...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74387c514701e9fc47ee32f5d9b68fd2d7913071
      https://github.com/WebKit/WebKit/commit/74387c514701e9fc47ee32f5d9b68fd2d7913071
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] Renegotiation signalling improvement
https://bugs.webkit.org/show_bug.cgi?id=252756

Reviewed by Xabier Rodriguez-Calvar.

When webrtcbin emits its on-negotiation-needed it has already made sure the negotiation is really
needed according to the spec, but our implementation wasn't resetting the corresponding flag
afterwards. We now match the event serial number, similarly to the libwebrtc implementation.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::onNegotiationNeeded):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
(WebCore::GStreamerMediaEndpoint::isNegotiationNeeded const):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::isNegotiationNeeded const):

Canonical link: https://commits.webkit.org/260731@main