[webkit-changes] [WebKit/WebKit] 8dbd7e: [Xcode] Set MACOSX_DEPLOYMENT_TARGET on open sourc...

Elliott Williams noreply at github.com
Wed Feb 22 19:25:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8dbd7e57ce021a18b8942a639b8bef3ceaeb9433
      https://github.com/WebKit/WebKit/commit/8dbd7e57ce021a18b8942a639b8bef3ceaeb9433
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M Tools/Scripts/build-webkit

  Log Message:
  -----------
  [Xcode] Set MACOSX_DEPLOYMENT_TARGET on open source builds to match the system version
https://bugs.webkit.org/show_bug.cgi?id=252783

Reviewed by Alexey Proskuryakov.

While internal builds of WebKit do not support back deployment
(targeting an older OS than what an SDK was built for), it's possible to
make open source builds in this way. Currently, we assume that the SDK's
default deployment target is fine, and make no effort to ensure that
what we build is actually runnable on the system.

This feels like unnecessary friction for open source contributors,
especially since the Xcode available in an older OS's App Store contains
SDKs for newer macOS versions. Rather than building artifacts that won't
run on the host machine, we should gracefully fall back.

Achieve this in build-webkit by passing MACOSX_DEPLOYMENT_TARGET, based
on the system's version. The deployment target can be overridden (or
unset) by passing MACOSX_DEPLOYMENT_TARGET on the command line.

See also: https://commits.webkit.org/245182@main, which stopped setting
the *_DEPLOYMENT_TARGET settings automatically in order to support
building for minor-release deployment targets.

* Tools/Scripts/build-webkit:

Canonical link: https://commits.webkit.org/260719@main




More information about the webkit-changes mailing list