[webkit-changes] [WebKit/WebKit] 3fb058: Move GridLineNamesClass before ValueListClass

Chirag Shah noreply at github.com
Wed Feb 22 14:56:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fb0588a949df9c7c58ab9a6c2c4f7c65f9e7b9e
      https://github.com/WebKit/WebKit/commit/3fb0588a949df9c7c58ab9a6c2c4f7c65f9e7b9e
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    A LayoutTests/fast/css/css-grid-line-names-crash-expected.txt
    A LayoutTests/fast/css/css-grid-line-names-crash.html
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h

  Log Message:
  -----------
  Move GridLineNamesClass before ValueListClass
https://bugs.webkit.org/show_bug.cgi?id=252767
rdar://105773172

Reviewed by Darin Adler.

We need to move GridLineNamesClass above ValueListClass so that
CSSGridLineNamesValue is not treated as CSSValueContainingVector which
will result in a crash.

* LayoutTests/fast/css/css-grid-line-names-crash-expected.txt: Added.
* LayoutTests/fast/css/css-grid-line-names-crash.html: Added.
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::createDeprecatedCSSOMWrapper const):
* Source/WebCore/css/CSSValue.h:

Canonical link: https://commits.webkit.org/260703@main




More information about the webkit-changes mailing list