[webkit-changes] [WebKit/WebKit] b9b283: WebKitTestRunner: Non-Cocoa TestController::platfo...

Fujii Hironori noreply at github.com
Wed Feb 22 13:33:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9b283e66f3d9b56288ca4e0c502953945f80007
      https://github.com/WebKit/WebKit/commit/b9b283e66f3d9b56288ca4e0c502953945f80007
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  WebKitTestRunner: Non-Cocoa TestController::platformAdjustContext should recreate WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=252554

Reviewed by Darin Adler.

http/tests/misc/image-blocked-src-change.html was failing for WinCairo
WK2 at the first time, it passed in the retry time in layout tests.

http/tests/misc/favicon-loads-with-icon-loading-override.html has
"LoadsImagesAutomatically=false" webkit-test-runner header. This
modifies the WKPreferences object of TestController.

Cocoa's platformAdjustContext recreates the WKPreferences object.
But, non-Cocoa's implementation didn't.

* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::platformAdjustContext):
Recreate WKPreferences object.

Canonical link: https://commits.webkit.org/260699@main




More information about the webkit-changes mailing list