[webkit-changes] [WebKit/WebKit] 87c8ca: Move "subtitle" attribute from HTMLNames to HTMLAt...

Gerald Squelart noreply at github.com
Wed Feb 22 12:41:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87c8ca6824e54bbd244c7368b4ea41ed60de4c26
      https://github.com/WebKit/WebKit/commit/87c8ca6824e54bbd244c7368b4ea41ed60de4c26
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityAttachment.cpp
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/HTMLAttachmentElement.h
    M Source/WebCore/html/HTMLAttributeNames.in

  Log Message:
  -----------
  Move "subtitle" attribute from HTMLNames to HTMLAttachmentElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=252730
rdar://105697448

Reviewed by Tim Nguyen.

Because the "subtitle" attribute is only used in the non-standard Attachment element, it shouldn't be part of the list of standard HTML attribute names.

* Source/WebCore/accessibility/AccessibilityAttachment.cpp:
(WebCore::AccessibilityAttachment::accessibilityText const):
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::subtitleAttr):
(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::parseAttribute):
(WebCore::HTMLAttachmentElement::attachmentSubtitle const):
(WebCore::HTMLAttachmentElement::attachmentSubtitleForDisplay const):
(WebCore::HTMLAttachmentElement::updateAttributes):
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/html/HTMLAttributeNames.in:

Canonical link: https://commits.webkit.org/260696@main




More information about the webkit-changes mailing list