[webkit-changes] [WebKit/WebKit] 553ca1: On some versions of AppKit, the programmatic Paste...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 553ca1c5d0c25e616a74f03fa47aa1a5ee82072d
      https://github.com/WebKit/WebKit/commit/553ca1c5d0c25e616a74f03fa47aa1a5ee82072d
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  On some versions of AppKit, the programmatic Paste menu title shows up as "…"
https://bugs.webkit.org/show_bug.cgi?id=252753
rdar://105781726

Reviewed by Aditya Keerthi.

Simplify some of this logic for presenting and positioning the DOM paste popover when requesting
programmatic pasteboard access. Instead of using a confinement rect to force the popover into the
correct position on screen (which, on certain versions of macOS, now causes the menu item to be
clipped), we should just supply the correct mouse event location when presenting the menu item in
the first place by converting the mouse location from screen to window coordinates.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::requestDOMPasteAccess):
(-[WKDOMPasteMenuDelegate confinementRectForMenu:onScreen:]): Deleted.

Canonical link: https://commits.webkit.org/260689@main