[webkit-changes] [WebKit/WebKit] 310f67: Recognize CSSUnitType::CSS_X as a resolution calc ...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 310f6772fe38734a6592e9ed1fa2f068556e4500
      https://github.com/WebKit/WebKit/commit/310f6772fe38734a6592e9ed1fa2f068556e4500
  Author: Ryan Reno <rreno at apple.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html
    M Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp

  Log Message:
  -----------
  Recognize CSSUnitType::CSS_X as a resolution calc unit category
https://bugs.webkit.org/show_bug.cgi?id=252627
rdar://105700660

Reviewed by Tim Nguyen.

We will fail to parse an expression like calc(1x * 2) because we are expecting a Resolution
calculation category due to the first token in the expression being a Dimenson token. However,
'x' is not recognized by the mapping and is given the category Other.
This causes us to bail and not perform the calculation.

* Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::calcUnitCategory):

* LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html:

Canonical link: https://commits.webkit.org/260678@main