[webkit-changes] [WebKit/WebKit] 06cfbc: [popover] Stop bubbling beforetoggle events

Tim Nguyen noreply at github.com
Tue Feb 21 23:55:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06cfbc919d075d90ec2906bfae3b0b666993492f
      https://github.com/WebKit/WebKit/commit/06cfbc919d075d90ec2906bfae3b0b666993492f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.html
    M Source/WebCore/dom/ToggleEvent.cpp

  Log Message:
  -----------
  [popover] Stop bubbling beforetoggle events
https://bugs.webkit.org/show_bug.cgi?id=252692
rdar://105764253

Reviewed by Aditya Keerthi.

They should not bubble per https://github.com/whatwg/html/issues/8888

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-beforetoggle-opening-event.html:
Confirmed that the test throws when changing `assert_false` to `assert_true`.

* Source/WebCore/dom/ToggleEvent.cpp:
(WebCore::ToggleEvent::ToggleEvent):

Canonical link: https://commits.webkit.org/260661@main




More information about the webkit-changes mailing list