[webkit-changes] [WebKit/WebKit] 360f2f: Fix JPEGImageDecoder boolean enum and #define TRUE...
Giulio Benetti
noreply at github.com
Tue Feb 21 15:05:24 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 360f2f938bba406c0e9bff52710a13c74eb8d1e9
https://github.com/WebKit/WebKit/commit/360f2f938bba406c0e9bff52710a13c74eb8d1e9
Author: Giulio Benetti <giulio.benetti at benettiengineering.com>
Date: 2023-02-21 (Tue, 21 Feb 2023)
Changed paths:
M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.h
Log Message:
-----------
Fix JPEGImageDecoder boolean enum and #define TRUE/FALSE mix
https://bugs.webkit.org/show_bug.cgi?id=252666
Reviewed by Michael Catanzaro.
jpeglib.h contains a typedef enum for boolean type but LCMSUniquePtr.h
include files that can contain #define TRUE/FALSE. This way build fails
with:
JPEGImageDecoder.cpp:343:43: error: invalid conversion from ‘int’ to ‘boolean’
This is because TRUE or FALSE should be an enum instead they get defined
as 1 or 0. To fix this move jpeglib.h inclusion after LCMSUniquePtr.h
inclusion. Let's also use angular paranthesis since jpeglib.h is a
system path header.
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.h:
Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
Canonical link: https://commits.webkit.org/260633@main
More information about the webkit-changes
mailing list