[webkit-changes] [WebKit/WebKit] b49cf9: [cocoa] Add new error userinfo entry for failed ma...

Matthew Finkel noreply at github.com
Tue Feb 21 13:49:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b49cf90d54fed4fb0b4dd45e8ca3cf538e986032
      https://github.com/WebKit/WebKit/commit/b49cf90d54fed4fb0b4dd45e8ca3cf538e986032
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm

  Log Message:
  -----------
  [cocoa] Add new error userinfo entry for failed main resource loads when HTTPS-Only is enabled
https://bugs.webkit.org/show_bug.cgi?id=252243
rdar://101517222

Reviewed by Wenson Hsieh and BJ Burg.

We add a new entry in the NSError userinfo dictionary that indicates the error
is associated with a HTTPSOnly load failure. This means that the load:
  - had the HTTPSOnly policy bit set
  - did not have the HTTPSOnlyExplicitlyBypassedForDomain policy bit set
  - the requested URL has a https: scheme
  - the response error is associated with a misconfigured or malfunctioning
    server configuration, or simply a server that does not support HTTPS.

* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::createErrorWithRecoveryAttempter):
(WebKit::NavigationState::NavigationClient::didFailProvisionalNavigationWithError):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):

Canonical link: https://commits.webkit.org/260629@main




More information about the webkit-changes mailing list