[webkit-changes] [WebKit/WebKit] fab6d5: REGRESSION(260471 at main): The platform graphics con...

Said Abou-Hallawa noreply at github.com
Tue Feb 21 07:21:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fab6d531c24fb7f031b60684f8f00b983b26d8f8
      https://github.com/WebKit/WebKit/commit/fab6d531c24fb7f031b60684f8f00b983b26d8f8
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

  Log Message:
  -----------
  REGRESSION(260471 at main): The platform graphics context colorspace should not be adopted
https://bugs.webkit.org/show_bug.cgi?id=252629
rdar://105637444

Reviewed by Darin Adler.

When storing the return raw pointer of CGIOSurfaceContextGetColorSpace() or
CGBitmapContextGetColorSpace() in a RetainPtr, we should not be using adoptCF().
The refcount of the colorspace should be incremented when WebKit references it.

* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::colorSpace const):

Canonical link: https://commits.webkit.org/260609@main




More information about the webkit-changes mailing list