[webkit-changes] [WebKit/WebKit] e20450: [IFC][Integration][Multicol] Allow non-top level m...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e204504c8a952d4d670fff06144a9b30906387b3
      https://github.com/WebKit/WebKit/commit/e204504c8a952d4d670fff06144a9b30906387b3
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/ios/fast/multicol/float-multicol-expected.txt
    M LayoutTests/platform/ios/fast/multicol/max-height-columns-block-expected.txt
    M LayoutTests/platform/mac/css3/unicode-bidi-isolate-basic-expected.txt
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp

  Log Message:
  -----------
  [IFC][Integration][Multicol] Allow non-top level multicol
https://bugs.webkit.org/show_bug.cgi?id=252596
rdar://105690424

Reviewed by Alan Baradlay.

We currently only enable top level pagination.

* LayoutTests/TestExpectations:

Mark fast/multicol/split-in-top-margin.html temporarily as a failure, see the linked bug.

* LayoutTests/platform/ios/fast/multicol/float-multicol-expected.txt:
* LayoutTests/platform/ios/fast/multicol/max-height-columns-block-expected.txt:
* LayoutTests/platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:

Non-visual test result changes.

* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::isPaginated const):
(WebCore::LayoutIntegration::LineLayout::contentBoxLogicalHeight const):

Take first line pagination shift into account when computing content height.

(WebCore::LayoutIntegration::LineLayout::adjustContent):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::isPaginated const): Deleted.

Move to InlineContent.

(): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::adjustLinePositionsForPagination):

Canonical link: https://commits.webkit.org/260603@main