[webkit-changes] [WebKit/WebKit] 173e3e: [GTK][WPE] UI process release log not shown
Carlos Garcia Campos
noreply at github.com
Tue Feb 21 02:39:25 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 173e3ebecf4fc597db7b4ce959e7bf451fa09ca4
https://github.com/WebKit/WebKit/commit/173e3ebecf4fc597db7b4ce959e7bf451fa09ca4
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2023-02-21 (Tue, 21 Feb 2023)
Changed paths:
M Source/WTF/wtf/unix/LoggingUnix.cpp
M Source/WebCore/platform/unix/LoggingUnix.cpp
M Source/WebKit/Platform/unix/LoggingUnix.cpp
M Source/WebKit/Shared/WebKit2Initialize.cpp
Log Message:
-----------
[GTK][WPE] UI process release log not shown
https://bugs.webkit.org/show_bug.cgi?id=252558
Reviewed by Michael Catanzaro.
The problem is that logLevelString() implementation in WebKit layer
doesn't take RELEASE_LOG_DISABLED into account. Actually the
implementation of logLevelString() in all layers does the same, getting
th value of WEBKIT_DEBUG env var, but with a few differences. We can
have a single implementation in WTF and use WTF::logLevelString() from
WebCore and WebKit.
* Source/WTF/wtf/unix/LoggingUnix.cpp:
(WTF::logLevelString):
* Source/WebCore/platform/unix/LoggingUnix.cpp:
(WebCore::logLevelString):
* Source/WebKit/Platform/unix/LoggingUnix.cpp:
(WebKit::logLevelString):
* Source/WebKit/Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2): Remove log initialization here since it's already done in UIProcessLogInitialization.cpp.
Canonical link: https://commits.webkit.org/260601@main
More information about the webkit-changes
mailing list