[webkit-changes] [WebKit/WebKit] 3bff13: [JSC] new BBQ should include enclosingHeight for c...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bff13ae469dae7117c08a806ac91a4eb8a9addb
      https://github.com/WebKit/WebKit/commit/3bff13ae469dae7117c08a806ac91a4eb8a9addb
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [JSC] new BBQ should include enclosingHeight for call-result computation
https://bugs.webkit.org/show_bug.cgi?id=252652
rdar://105713588

Reviewed by Mark Lam.

New BBQ's call's result assignment is incorrect. It should include enclosingHeight for calculation (see topValue implementation).
Otherwise, nested block with enclosing height will compute state height incorrectly.

    i32.const 32 // stack-height 1 slot
    block {
        call() // Return i32, then it should be stack-height 2 slots (1 + 1).
    }

This fixes JetStream2/tsf-wasm run.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::returnValuesFromCall):
(JSC::Wasm::BBQJIT::emitCCall):

Canonical link: https://commits.webkit.org/260595@main