[webkit-changes] [WebKit/WebKit] 7d8411: Clean up WebCore::IDBKeyData

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d84116a88ef2b79ebf76e99022aa38b78e6e42d
      https://github.com/WebKit/WebKit/commit/7d84116a88ef2b79ebf76e99022aa38b78e6e42d
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/CrossThreadCopier.h
    M Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
    M Source/WebCore/Modules/indexeddb/IDBKeyData.h
    M Source/WebCore/platform/ThreadSafeDataBuffer.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Clean up WebCore::IDBKeyData
https://bugs.webkit.org/show_bug.cgi?id=252515
rdar://105620836

Reviewed by Sihui Liu.

m_type and m_isNull were unnecessary and caused the serialization to
need the ReturnEarlyIfTrue attribute which can't be exposed to the IPC
testing API very well and was only used in two places, so this removes
half of it.  Also reduces memory use.

* Source/WTF/wtf/CrossThreadCopier.h:
* Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::type const):
(WebCore::IDBKeyData::maybeCreateIDBKey const):
(WebCore::IDBKeyData::isolatedCopy const):
(WebCore::IDBKeyData::encode const):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare const):
(WebCore::IDBKeyData::loggingString const):
(WebCore::IDBKeyData::setArrayValue):
(WebCore::IDBKeyData::setBinaryValue):
(WebCore::IDBKeyData::setStringValue):
(WebCore::IDBKeyData::setDateValue):
(WebCore::IDBKeyData::setNumberValue):
(WebCore::IDBKeyData::isValid const):
(WebCore::IDBKeyData::operator== const):
(WebCore::IDBKeyData::size const):
(WebCore::IDBKeyData::isolatedCopy): Deleted.
* Source/WebCore/Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::Date::isolatedCopy const):
(WebCore::IDBKeyData::Min::isolatedCopy const):
(WebCore::IDBKeyData::Max::isolatedCopy const):
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):
(WebCore::IDBKeyData::isNull const):
(WebCore::IDBKeyData::string const):
(WebCore::IDBKeyData::date const):
(WebCore::IDBKeyData::number const):
(WebCore::IDBKeyData::binary const):
(WebCore::IDBKeyData::array const):
(WebCore::IDBKeyData::value const):
(WebCore::IDBKeyData::type const): Deleted.
* Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:
(WebCore::decodeKey):
* Source/WebCore/platform/ThreadSafeDataBuffer.h:
(WebCore::ThreadSafeDataBuffer::isolatedCopy const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/260578@main