[webkit-changes] [WebKit/WebKit] ab29cf: Extraneous interaction regions for pseudo elements...

EWS noreply at github.com
Mon Feb 20 13:56:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab29cfa512af8fac599ae1f0e7bb19b99980cc52
      https://github.com/WebKit/WebKit/commit/ab29cfa512af8fac599ae1f0e7bb19b99980cc52
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    A LayoutTests/interaction-region/nested-composited-text-painter-expected.txt
    A LayoutTests/interaction-region/nested-composited-text-painter.html
    A LayoutTests/interaction-region/pseudo-element-expected.txt
    A LayoutTests/interaction-region/pseudo-element.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Extraneous interaction regions for pseudo elements and some composited childrens
https://bugs.webkit.org/show_bug.cgi?id=251995
<rdar://104140617>

Reviewed by Tim Horton.

Tweak the interaction regions generation heuristics to avoid extra
regions for:
- pseudo-elements
- children of block elements getting their own InteractionRegion

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
Keep track of the original RegionRenderer node separately of the one we
end up matching in order to tweak the heuristics.

* LayoutTests/interaction-region/nested-composited-text-painter-expected.txt: Added.
* LayoutTests/interaction-region/nested-composited-text-painter.html: Added.
* LayoutTests/interaction-region/pseudo-element-expected.txt: Added.
* LayoutTests/interaction-region/pseudo-element.html: Added.
Add tests for these cases.

Canonical link: https://commits.webkit.org/260567@main




More information about the webkit-changes mailing list