[webkit-changes] [WebKit/WebKit] e42cb6: Support the foreground color attribute in marked text

Richard Robinson noreply at github.com
Mon Feb 20 10:51:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e42cb64adc1b11a2f44bb54f8e4d4ee62e9c249f
      https://github.com/WebKit/WebKit/commit/e42cb64adc1b11a2f44bb54f8e4d4ee62e9c249f
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M LayoutTests/editing/input/composition-highlights-expected.html
    M LayoutTests/editing/input/composition-highlights.html
    M Source/WebCore/editing/CompositionHighlight.h
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextBoxPainter.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp

  Log Message:
  -----------
  Support the foreground color attribute in marked text
https://bugs.webkit.org/show_bug.cgi?id=252366
rdar://105182036

Reviewed by Alan Baradlay.

Add support for the foreground color attribute for marked text.

* Source/WebCore/editing/CompositionHighlight.h:
(WebCore::CompositionHighlight::CompositionHighlight):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionForeground):
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundAndDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionBackground):
* Source/WebCore/rendering/TextBoxPainter.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::validAttributesForMarkedText):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetComposition):

Canonical link: https://commits.webkit.org/260549@main




More information about the webkit-changes mailing list