[webkit-changes] [WebKit/WebKit] 19ae04: AX: aria-errormessage should not be exposed when a...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19ae041e1fa86ab7db41f40d76317792958973ba
      https://github.com/WebKit/WebKit/commit/19ae041e1fa86ab7db41f40d76317792958973ba
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M LayoutTests/accessibility/custom-elements/describedby-shadow.html
    M LayoutTests/accessibility/custom-elements/describedby.html
    M LayoutTests/accessibility/element-reflection-ariaerrormessage.html
    M LayoutTests/accessibility/ios-simulator/aria-errormessage-expected.txt
    M LayoutTests/accessibility/ios-simulator/aria-errormessage.html
    M LayoutTests/accessibility/mac/aria-errormessage-expected.txt
    M LayoutTests/accessibility/mac/aria-errormessage.html
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: aria-errormessage should not be exposed when aria-invalid is false
https://bugs.webkit.org/show_bug.cgi?id=230611
rdar://problem/83393652

Reviewed by Chris Fleizach.

Quoting https://www.w3.org/TR/wai-aria-1.2/#aria-errormessage:

  > User agents MUST NOT expose aria-errormessage for an object with an aria-invalid value of false.

This patch implements this behavior.

* LayoutTests/accessibility/custom-elements/describedby-shadow.html:
* LayoutTests/accessibility/custom-elements/describedby.html:
* LayoutTests/accessibility/element-reflection-ariaerrormessage.html:
This test relied on aria-errormessages being exposed despite
aria-invalid computing to false. This patch fixes this by adding
aria-invalid="true" to these tests where necessary.

* LayoutTests/accessibility/ios-simulator/aria-errormessage-expected.txt:
* LayoutTests/accessibility/ios-simulator/aria-errormessage.html:
* LayoutTests/accessibility/mac/aria-errormessage-expected.txt:
* LayoutTests/accessibility/mac/aria-errormessage.html:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityErrorMessageElements]):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/260545@main