[webkit-changes] [WebKit/WebKit] 37c7b0: location.href should throw "SyntaxError" DOMExcept...

Chris Dumez noreply at github.com
Mon Feb 20 09:13:43 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37c7b03669eb1e595bba2ff9967b163434607848
      https://github.com/WebKit/WebKit/commit/37c7b03669eb1e595bba2ff9967b163434607848
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M LayoutTests/fast/dom/location-new-window-no-crash-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/failure.html
    M Source/WebCore/page/Location.cpp

  Log Message:
  -----------
  location.href should throw "SyntaxError" DOMException on URL parser failure
https://bugs.webkit.org/show_bug.cgi?id=252535
rdar://105631453

Reviewed by Sihui Liu.

* LayoutTests/fast/dom/location-new-window-no-crash-expected.txt:
Rebaseline existing test due to different exception type.

* LayoutTests/imported/w3c/web-platform-tests/url/failure.html:
Resync WPT test after https://github.com/web-platform-tests/wpt/pull/38581.

* Source/WebCore/page/Location.cpp:
(WebCore::Location::setLocation):
Throw a SyntaxError instead of a TypeError when URL parsing failed.

Canonical link: https://commits.webkit.org/260539@main




More information about the webkit-changes mailing list