[webkit-changes] [WebKit/WebKit] e323cc: Block logging service in sandbox

[Per Arne Vollan]

  Branch: refs/heads/eng/Block-logging-service-in-sandbox
  Home:   https://github.com/WebKit/WebKit
  Commit: e323cc70be7cc4bb09413edbd7dc287c17da25d9
      https://github.com/WebKit/WebKit/commit/e323cc70be7cc4bb09413edbd7dc287c17da25d9
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/spi/cocoa/OSLogSPI.h
    M Source/WTF/wtf/spi/darwin/SandboxSPI.h
    M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
    M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  -----------
  Block logging service in sandbox
https://bugs.webkit.org/show_bug.cgi?id=252195
rdar://105416416

Reviewed by NOBODY (OOPS!).

Block logging service in the WebContent process sandbox unless the build is internal or the user has
opened the Feedback Assistant App at some point. This requires some tweaks at startup of the
WebContent process to avoid opening up a Mach connection to the service before determining if logging
should be enabled.

* Source/WTF/wtf/spi/darwin/SandboxSPI.h:
* Source/WTF/wtf/spi/cocoa/OSLogSPI.h:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::initializeCFPrefs):
(WebKit::auditTokenForSelf):
(WebKit::initializeLogd):
(WebKit::XPCServiceEventHandler):
(WebKit::XPCServiceMain):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::haveUsedFeedbackAssistant):
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::initializeLogd): Deleted.
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:


  Commit: cd793ceed3b49498810e176fb17cafc6be2e1ad3
      https://github.com/WebKit/WebKit/commit/cd793ceed3b49498810e176fb17cafc6be2e1ad3
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/spi/cocoa/OSLogSPI.h
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

  Log Message:
  -----------
  WIP

* Source/WTF/wtf/spi/cocoa/OSLogSPI.h:
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::blockLogdInSandbox):
(WebKit::registerLogHooks):
(WebKit::initializeLogd):
(WebKit::XPCServiceEventHandler):
(WebKit::crashDueWebKitFrameworkVersionMismatch):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::haveUsedFeedbackAssistant):
(WebKit::ProcessLauncher::launchProcess):


Compare: https://github.com/WebKit/WebKit/compare/e323cc70be7c%5E...cd793ceed3b4