[webkit-changes] [WebKit/WebKit] 940043: Twitter is not filtered by content filter
Per Arne Vollan
noreply at github.com
Sat Feb 18 18:09:01 PST 2023
Branch: refs/heads/eng/Twitter-is-not-filtered-by-content-filter
Home: https://github.com/WebKit/WebKit
Commit: 940043a405e1a8f4fa2739603956259b195da800
https://github.com/WebKit/WebKit/commit/940043a405e1a8f4fa2739603956259b195da800
Author: Per Arne Vollan <pvollan at apple.com>
Date: 2023-02-17 (Fri, 17 Feb 2023)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h
Log Message:
-----------
Twitter is not filtered by content filter
https://bugs.webkit.org/show_bug.cgi?id=252496
rdar://103032824
Reviewed by NOBODY (OOPS!).
Twitter is not filtered by content filter since service worker fetch is missing filtering code.
Make sure content filtering is started on service worker fetch, and let the content filter
intercept the fetch if it should be blocked.
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startContentFiltering):
(WebKit::NetworkResourceLoader::continueAfterDataReceived):
(WebKit::NetworkResourceLoader::continueAfterResponseReceived):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.h:
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::didReceiveDataFromPreloader):
(WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
Commit: b1eda011c8db4f82807534fff20f771d442953ed
https://github.com/WebKit/WebKit/commit/b1eda011c8db4f82807534fff20f771d442953ed
Author: Per Arne Vollan <pvollan at apple.com>
Date: 2023-02-18 (Sat, 18 Feb 2023)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
Log Message:
-----------
Test fix.
Commit: 227f69ed73fed69ad93058028025add587968255
https://github.com/WebKit/WebKit/commit/227f69ed73fed69ad93058028025add587968255
Author: Per Arne Vollan <pvollan at apple.com>
Date: 2023-02-18 (Sat, 18 Feb 2023)
Changed paths:
A LayoutTests/http/wpt/service-workers/basic-fetch-blocked.https-expected.txt
A LayoutTests/http/wpt/service-workers/basic-fetch-blocked.https.html
A LayoutTests/http/wpt/service-workers/basic-fetch-blocked.js
Log Message:
-----------
Added test.
* LayoutTests/http/wpt/service-workers/basic-fetch-blocked.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/basic-fetch-blocked.https.html: Added.
* LayoutTests/http/wpt/service-workers/basic-fetch-blocked.js: Added.
(doTest):
Compare: https://github.com/WebKit/WebKit/compare/940043a405e1%5E...227f69ed73fe
More information about the webkit-changes
mailing list