[webkit-changes] [WebKit/WebKit] 5354f8: [IFC][Partial layout] InlineItemsBuilder should ta...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5354f81c498e97ddd2678b232d4d11f676e6e976
      https://github.com/WebKit/WebKit/commit/5354f81c498e97ddd2678b232d4d11f676e6e976
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-18 (Sat, 18 Feb 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC][Partial layout] InlineItemsBuilder should take care of removing stale InlineItems from InlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=252372

Reviewed by Antti Koivisto.

Let's move InlineItem invalidation from invalidateFormattingState to InlineItemsBuilder (boxes and lines are moved out of InlineFormattingState during inline content construction anyway).

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::InlineFormattingContext::invalidateFormattingState): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::setInlineItems):
(WebCore::Layout::InlineFormattingState::appendInlineItems):
(WebCore::Layout::InlineFormattingState::clearInlineItems):
(WebCore::Layout::InlineFormattingState::addInlineItems): Deleted.
(WebCore::Layout::InlineFormattingState::clearLineAndBoxes): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::build):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::adjustGeometryForInitialLetterIfNeeded):

Canonical link: https://commits.webkit.org/260520@main