[webkit-changes] [WebKit/WebKit] cdbf64: [JSC] Make WEBASSEMBLY_SIGNALING_MEMORY hard requi...

Yusuke Suzuki noreply at github.com
Sat Feb 18 01:03:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdbf645e4854f058e82651b196fbafc73e4cb6e1
      https://github.com/WebKit/WebKit/commit/cdbf645e4854f058e82651b196fbafc73e4cb6e1
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-18 (Sat, 18 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp
    M Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp
    M Source/JavaScriptCore/runtime/BufferMemoryHandle.h
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp
    M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp
    M Source/JavaScriptCore/wasm/WasmMemory.cpp
    M Source/JavaScriptCore/wasm/WasmMemory.h
    M Source/WTF/wtf/PlatformEnable.h

  Log Message:
  -----------
  [JSC] Make WEBASSEMBLY_SIGNALING_MEMORY hard requirement for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=252517
rdar://105621940

Reviewed by Mark Lam.

Now, all wasm platforms have signaling memory implementation. And signaling memory
is part of wasm shared memory. Thus, we should make this mandatory for wasm implementation.
This patch makes WEBASSEMBLY_SIGNALING_MEMORY hard requirement for wasm. And remove WEBASSEMBLY_SIGNALING_MEMORY
flag.

* Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp:
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
* Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp:
(JSC::BufferMemoryHandle::fastMappedBytes):
(JSC::BufferMemoryManager::freeFastMemory):
(JSC::BufferMemoryManager::isInGrowableOrFastMemory):
(JSC::BufferMemoryManager::dump const):
(JSC::BufferMemoryHandle::BufferMemoryHandle):
(JSC::BufferMemoryHandle::~BufferMemoryHandle):
* Source/JavaScriptCore/runtime/BufferMemoryHandle.h:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::overrideDefaults):
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp:
(JSC::Wasm::AirIRGenerator64::emitCheckAndPreparePointer):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitCheckAndPreparePointer):
* Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:
(JSC::Wasm::activateSignalingMemory):
(JSC::Wasm::prepareSignalingMemory):
* Source/JavaScriptCore/wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::tryCreate):
(JSC::Wasm::Memory::growShared):
(JSC::Wasm::Memory::grow):
* Source/JavaScriptCore/wasm/WasmMemory.h:
* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/260502@main




More information about the webkit-changes mailing list