[webkit-changes] [WebKit/WebKit] 58784c: WebKit_iosmac builds fail with ASan enabled

EWS noreply at github.com
Fri Feb 17 12:34:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58784ce9f87d5c3e93834da2fa49b9aa3dd0b94b
      https://github.com/WebKit/WebKit/commit/58784ce9f87d5c3e93834da2fa49b9aa3dd0b94b
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-02-17 (Fri, 17 Feb 2023)

  Changed paths:
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp

  Log Message:
  -----------
  WebKit_iosmac builds fail with ASan enabled
https://bugs.webkit.org/show_bug.cgi?id=252494
<rdar://105597825>

Reviewed by Alexey Proskuryakov.

This adds #if/#endif macros to guard code that uses identifiers
that are not available on the iosmac platform.

* Source/WebKit/Scripts/webkit/messages.py:
(conditions_for_header):
- Add conditions for identifier headers.  Because these
  identifiers have a one-to-one relationship with the headers
  where they are defined, this was the simplest way to add
  support for conditionalizing the identifiers (in addition to
  their headers).
(generate_message_argument_description_implementation):
- Check for conditions when emitting code that references an
  identifier, and output #if/#endif macros to guard it when
  needed.
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::serializedIdentifiers):
- Regenerate test file which now includes additional #if/#endif
  guards for these identifiers and their headers.

Canonical link: https://commits.webkit.org/260461@main




More information about the webkit-changes mailing list