[webkit-changes] [WebKit/WebKit] 6b4139: Use separate search field history for WebsiteDataS...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b4139142821cbbcfb7151ed36c27699f2756eba
      https://github.com/WebKit/WebKit/commit/6b4139142821cbbcfb7151ed36c27699f2756eba
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-02-17 (Fri, 17 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/SearchPopupMenu.h
    M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.h
    M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h
    M Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp
    M Source/WebKit/UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp
    M Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/SearchPopupMenuMac.h
    M Source/WebKitLegacy/mac/WebCoreSupport/SearchPopupMenuMac.mm

  Log Message:
  -----------
  Use separate search field history for WebsiteDataStore created with identifier
https://bugs.webkit.org/show_bug.cgi?id=252079
rdar://105296242

Reviewed by Chris Dumez.

Use separate search field history so it is not shared between sessions and can be cleared by WebsiteDataStore.

* Source/WebCore/platform/SearchPopupMenu.h:
(WebCore::RecentSearch::isolatedCopy const):
* Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.h:
* Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:
(WebCore::searchFieldRecentSearchesPlistPath):
(WebCore::readSearchFieldRecentSearchesPlist):
(WebCore::typeCheckedRecentSearchesRemovingRecentSearchesAddedAfterDate):
(WebCore::saveRecentSearchesToFile):
(WebCore::loadRecentSearchesFromFile):
(WebCore::removeRecentlyModifiedRecentSearchesFromFile):
(WebCore::searchFieldRecentSearchesStorageDirectory): Deleted.
(WebCore::writeEmptyRecentSearchesPlist): Deleted.
(WebCore::saveRecentSearches): Deleted.
(WebCore::loadRecentSearches): Deleted.
(WebCore::removeRecentlyModifiedRecentSearches): Deleted.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::defaultSearchFieldHistoryDirectory):
(WebKit::WebsiteDataStore::saveRecentSearches):
(WebKit::WebsiteDataStore::loadRecentSearches):
(WebKit::WebsiteDataStore::removeRecentSearches):
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Deleted.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::saveRecentSearches):
(WebKit::WebsiteDataStore::loadRecentSearches):
(WebKit::WebsiteDataStore::removeRecentSearches):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resolvedSearchFieldHistoryDirectory const):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::initializePaths):
(WebKit::WebsiteDataStoreConfiguration::copy const):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::searchFieldHistoryDirectory const):
(WebKit::WebsiteDataStoreConfiguration::setSearchFieldHistoryDirectory):
* Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Deleted.
* Source/WebKit/UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Deleted.
* Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp:
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/SearchPopupMenuMac.h:
* Source/WebKitLegacy/mac/WebCoreSupport/SearchPopupMenuMac.mm:
(defaultSearchFieldRecentSearchesStorageDirectory):
(SearchPopupMenuMac::SearchPopupMenuMac):
(SearchPopupMenuMac::saveRecentSearches):
(SearchPopupMenuMac::loadRecentSearches):

Canonical link: https://commits.webkit.org/260452@main