[webkit-changes] [WebKit/WebKit] 5a1c25: [UI-side compositing] Horizontal scrolling can tri...
Simon Fraser
noreply at github.com
Thu Feb 16 23:13:17 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a1c25af48a8f877299f911b8c793a5443b6c269
https://github.com/WebKit/WebKit/commit/5a1c25af48a8f877299f911b8c793a5443b6c269
Author: Simon Fraser <simon.fraser at apple.com>
Date: 2023-02-16 (Thu, 16 Feb 2023)
Changed paths:
M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp
M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
Log Message:
-----------
[UI-side compositing] Horizontal scrolling can trigger history swipes instead of scrolling
https://bugs.webkit.org/show_bug.cgi?id=252447
rdar://105574452
Reviewed by Tim Horton.
We can remove the call to willWheelEventStartSwipeGesture() in RemoteScrollingCoordinatorProxy::handleWheelEvent();
it's not used in the WebContent scrolling code path, other than when a wheel event has already been passed to script.
Here, it was incorrectly allowing a swipe from a "began" event.
Some come-along changes: make WheelEventHandlingResult loggable, and fix some logging.
* Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp:
(WebCore::operator<<):
* Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h:
* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::computeWheelProcessingSteps):
(WebCore::ScrollingTree::determineWheelEventProcessing):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent):
Canonical link: https://commits.webkit.org/260430@main
More information about the webkit-changes
mailing list